Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/ --- (Updated Aug. 7, 2014, 5:15 a.m.) Review request for KDE Frameworks, kwin

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

> On Aug. 6, 2014, 5:04 p.m., Thomas Lübking wrote: > > src/netwm.cpp, line 4779 > > > > > > -> qstrdup? > > (also "new code" issue) nstrdup is used all over the file, qstrdup not. Would it be wise to start

Re: Review Request 119588: Remove Qt5 debugfull hack from ECMConfig.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/ --- (Updated Aug. 6, 2014, 8:22 p.m.) Status -- This change has been mar

Jenkins build is back to stable : ktexteditor_master_qt5 #533

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #532

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: KCrash misses DrKonqi

On 05 Aug 2014, at 08:09 , David Faure wrote: > It's not a shared lib, it's a separate process started by KCrash. Oh, I see. I thought there was an executable called like that. Thanks for the info. Greets, Marko ___ Kde-frameworks-devel mailing list

Re: KAction Warning

Hi, for me it looks like KStandardAction itself triggers a lot of these warnings. I thought about adding a workaround like the already existing: if (pAction && parent && parent->inherits("KActionCollection")) { QMetaObject::invokeMethod(parent, "addAction", Q_ARG(QString, pAction->objectName

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review63939 --- src/netwm.cpp

Re: Making KFileMetaData a framework

On Wednesday 06 August 2014 17:29:40 Vishesh Handa wrote: > On Wednesday, August 06, 2014 04:09:19 PM Milian Wolff wrote: > > > Hmm, how would we do async? I thought people could just run it in > > > another > > > thread / process if they want. The only thing I can think of changing is > > > that t

Re: Review Request 119632: update kapidox version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/ --- (Updated Aug. 6, 2014, 3:18 p.m.) Status -- This change has been mar

Re: Making KFileMetaData a framework

On Wednesday, August 06, 2014 04:09:19 PM Milian Wolff wrote: > > > > Hmm, how would we do async? I thought people could just run it in another > > thread / process if they want. The only thing I can think of changing is > > that the plugins return the result later via a signal instead of doing al

Re: Review Request 119632: update kapidox version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/#review63929 --- increase_frameworks_version.sh

Re: Making KFileMetaData a framework

On Wednesday 06 August 2014 16:05:27 Vishesh Handa wrote: > On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > > Hello, > > > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > > I would appreciate it if everyone could review the code once before it > > > gets > > > into fram

Re: Making KFileMetaData a framework

On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > Hello, > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > I would appreciate it if everyone could review the code once before it > > gets > > into frameworks. > > metainfo.yaml should have "release: false" until it's part

Re: Making KFileMetaData a framework

On Tuesday 05 August 2014 19:58:03 David Edmundson wrote: > In general that's some of the tidied code I've seen in a long time. > > Comments below. One major, most not. > > > TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= > otherwise we shallow copy d. > > I can caus

Re: Review Request 119632: update kapidox version

> On Aug. 6, 2014, 11:23 a.m., David Faure wrote: > > yes, but... Alas I don't have commit rights to that repository - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/#re

Re: Review Request 119632: update kapidox version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/ --- (Updated Aug. 6, 2014, 11:35 a.m.) Review request for KDE Frameworks and

Re: Making KFileMetaData a framework

On Tuesday, August 05, 2014 07:58:03 PM David Edmundson wrote: > In general that's some of the tidied code I've seen in a long time. Thanks! > > Comments below. One major, most not. > > > TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= > otherwise we shallow copy d.

Re: Review Request 119632: update kapidox version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/#review63912 --- Ship it! yes, but... increase_frameworks_version.sh

For Book Sprint team: Sample Frameworks Cookbook

Hi folks, I've started a book for you to play with. Load up http://booki.flossmanuals.net/kde-frameworks-cookbook/_edit/ and have fun. Make a login, make some chapters, drag them around, and see what everything looks like. Unfortunately the editor won't save for me tonight; I actually did add con

Review Request 119632: update kapidox version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119632/ --- Review request for KDE Frameworks and David Faure. Repository: release-to