Re: Review Request 120165: Add support for input hint in NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/ --- (Updated Sept. 15, 2014, 7:15 a.m.) Status -- This change has been

Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120158/ --- (Updated Sept. 15, 2014, 7:15 a.m.) Status -- This change has been

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #96

2014-09-15 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-15 Thread David Faure
On Sept. 14, 2014, 12:26 p.m., Mark Gaiser wrote: My attempt at this. Feel free to use it as you see fit. diff --git a/src/urifilters/shorturi/kshorturifilter.cpp b/src/urifilters/shorturi/kshorturifilter.cpp index 00668d9..6c35393 100644 ---

Re: OSX/CI: plasmate fails to build on branch frameworks

2014-09-15 Thread Kevin Funk
On Sunday 14 September 2014 18:28:16 Marko Käning wrote: On 14 Sep 2014, at 16:24 , Marko Käning mk-li...@email.de wrote: Linux/CI hang, because there was a missing dependency to kdevplatform. This has been fixed by now, but Jenkins master hasn’t picked up the dependency change yet.

Broken KWindowInfoX11Test::testActivities on CI system

2014-09-15 Thread Martin Gräßlin
Hi Ivan, could you please have a look at KWindowInfoX11Test::testActivities. The unit test fails on the CI system and also locally with a setup similar to CI system (passes with KWin, though). To get a clean setup ensure to have an Xvfb running and an openbox on that Xvfb. The unit test looks

Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- Review request for KDE Frameworks, kwin and Ivan Čukić. Repository:

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119997/ --- (Updated Sept. 15, 2014, 10:28 a.m.) Status -- This change has been

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66519 --- Looks ok, does it pass now? - Ivan Čukić On Sept. 15,

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Martin Gräßlin
On Sept. 15, 2014, 10:32 a.m., Ivan Čukić wrote: Looks ok, does it pass now? this test already passed, the failing one is KWindowInfoTestX11. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-15 Thread Mark Gaiser
On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: My attempt at this. Feel free to use it as you see fit. diff --git a/src/urifilters/shorturi/kshorturifilter.cpp b/src/urifilters/shorturi/kshorturifilter.cpp index 00668d9..6c35393 100644 ---

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-15 Thread Arjun Ak
On Sept. 14, 2014, 5:56 p.m., Mark Gaiser wrote: My attempt at this. Feel free to use it as you see fit. diff --git a/src/urifilters/shorturi/kshorturifilter.cpp b/src/urifilters/shorturi/kshorturifilter.cpp index 00668d9..6c35393 100644 ---

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66527 --- Ship it! Ship It! - Ivan Čukić On Sept. 15, 2014, 8:14

Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem

Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- (Updated Sept. 15, 2014, 2:33 p.m.) Status -- This change has been

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #97

2014-09-15 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. - Christoph

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. I'm

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix.

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix.

Re: kconfigwidgets should install have kf5_entry.desktop

2014-09-15 Thread Aleix Pol
On Fri, Sep 12, 2014 at 5:56 PM, Albert Astals Cid aa...@kde.org wrote: Hi David, kf-ers KLanguageButton is using kf5_entry.desktop as seen on http://lxr.kde.org/search?v=kf5-qt5_filestring=_string=+KLanguageButton It seems that the packaging scripts are not aware of it and thus it is not

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix.

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #765

2014-09-15 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/765/ -- Started by upstream project plasma-framework_master_qt5 build number 765 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note:

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #766

2014-09-15 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/766/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kconfigwidgets should install have kf5_entry.desktop

2014-09-15 Thread Albert Astals Cid
El Dilluns, 15 de setembre de 2014, a les 17:45:06, Aleix Pol va escriure: On Fri, Sep 12, 2014 at 5:56 PM, Albert Astals Cid aa...@kde.org wrote: Hi David, kf-ers KLanguageButton is using kf5_entry.desktop as seen on

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix.

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66593 --- Yep, I think the name change is sensible.

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66594 --- Ship it! Ship It! - Alex Merry On Sept. 15, 2014, 6:56

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 7:11 p.m.) Status -- This change has been

Re: Review Request 120200: Only create one instance of defaultExecutor.

2014-09-15 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120200/ --- (Updated Sept. 15, 2014, 8:24 p.m.) Status -- This change has been

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/#review66605 --- Ship it! Minor notes only. However, I assume you also want

kdelibs4support does not contain any .po

2014-09-15 Thread Albert Astals Cid
Hi David, kf-ers I can't find any .po inside kdelibs4support tarball. David can you make sure the files get packaged and installed for the next frameworks release? Do you want a bug? Cheers, Albert ___ Kde-frameworks-devel mailing list

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/#review66618 --- If we merge, we should imo merge in NetWinInfo - having the

Re: desktoptojson man page

2014-09-15 Thread Alexander Richardson
Hi Micheal, 2014-09-15 19:57 GMT+02:00 Michael Palimaka kensing...@gentoo.org: Hi there, In kservice at b427f4c3889004d9d983939cd9bf7c1465e6beb3, desktoptojson was replaced/moved to kcoreaddons. However, it appears the man page was forgotten and that still exists in kservice. I'd move it

Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

2014-09-15 Thread Martin Gräßlin
On Sept. 16, 2014, 12:28 a.m., Thomas Lübking wrote: If we merge, we should imo merge in NetWinInfo - having the same function return different values in NetWinInfo and KWindowInfo feels wrong. I considered it, but decided against it as I consider NETWinInfo to be a level lower to X and

OSX/CI: ark fails to build on branch frameworks

2014-09-15 Thread Marko Käning
Is ark not yet fully ported to KF5 - on Linux perhaps as well? --- Users/marko/WC/KDECI-builds/ark/part/arkviewer.cpp:255:24: error: no matching constructor for initialization of 'KRun' KRun *runner = new KRun(url, 0, 0, false); ^

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
On Sept. 15, 2014, 10:34 p.m., Thomas Lübking wrote: Minor notes only. However, I assume you also want to add protocol invocation (like exists for pinging the window) and therefore a preemtive warning: I'll *strongly* veto exposing the sync protocol to random clients (since we

Re: OSX/CI: ark fails to build on branch frameworks

2014-09-15 Thread Bhushan Shah
On Tue, Sep 16, 2014 at 11:09 AM, Marko Käning mk-li...@email.de wrote: Users/marko/WC/KDECI-builds/ark/part/arkviewer.cpp:255:24: error: no matching constructor for initialization of 'KRun' KRun *runner = new KRun(url, 0, 0, false); ^

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- (Updated Sept. 16, 2014, 7:55 a.m.) Review request for KDE Frameworks.

Re: OSX/CI: ark fails to build on branch frameworks

2014-09-15 Thread Bhushan Shah
On Tue, Sep 16, 2014 at 11:13 AM, Bhushan Shah bhus...@gmail.com wrote: Umm strange, I don't see this error.. I myself have ported it and it works fine here.. let me try and see what can cause this error.. Okay now I see problem, in KF5 constructor is, KRun (const QUrl url, QWidget *window,