Re: Review Request 120165: Add support for input hint in NETWinInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/ --- (Updated Sept. 15, 2014, 7:15 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- The Input Hint is part of WM_HINTS property which is already processed for WM2GroupLeader and WM2Urgency. The default for input hint is true. ICCCM suggests to assume convenient values for all fields of WM_HINTS property if a window is mapped wihtout one. KWin sets this value to true, so the sane convenient value for the input field seems to be true. Diffs - autotests/netwininfotestclient.cpp 160f7599f3fba9398029db3be5841fe78bbf7cf0 src/netwm.h 0c89dc7385e2542e6e21da55985fd8b926fb3e37 src/netwm.cpp a0a2faeeb1dea432a7c2d1e72800de3cf6cb6d2a src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 src/netwm_p.h 2e4659e53adb3975d69f0bfffb88d26c0148edd6 Diff: https://git.reviewboard.kde.org/r/120165/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120158/ --- (Updated Sept. 15, 2014, 7:15 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- UrgencyHint is part of WM_HINTS property which is already processed for WM2GroupLeader. Diffs - autotests/netwininfotestclient.cpp 160f7599f3fba9398029db3be5841fe78bbf7cf0 src/netwm.h 0c89dc7385e2542e6e21da55985fd8b926fb3e37 src/netwm.cpp a0a2faeeb1dea432a7c2d1e72800de3cf6cb6d2a src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 src/netwm_p.h 2e4659e53adb3975d69f0bfffb88d26c0148edd6 Diff: https://git.reviewboard.kde.org/r/120158/diff/ Testing --- see added unit test Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #96
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120213: Add support for protocols to NETWinInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- NETWinInfo is now able to read all known protocols set on WM_PROTOCOLS property and provides the set protocols as flags. So far the following protocols are supported: * WM_TAKE_FOCUS (ICCCM 4.1.2.7) * WM_DELETE_WINDOW (ICCCM 4.1.2.7) * _NET_WM_SYNC_REQUEST (EWMH) * _NET_WM_PING (EWMH) * _NET_WM_CONTEXT_HELP (KDE specific extension to EWMH) CHANGELOG: NETWinInfo provides convenient wrapper for WM_PROTOCOLS. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa src/netwm.h 436ad2fd449b48a36d3bb15754f7c8c64f52c8dd src/netwm.cpp 1431cf6bae605050e2e86f7ca60357ddb7736d32 src/netwm_def.h 12abfff03af5b81a60ec03a5366b6ff0b95d35d0 src/netwm_p.h a586450211846af464c9014f586e14b0e808cd75 Diff: https://git.reviewboard.kde.org/r/120213/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120138: kshorturifilter : Treat ///... as /
On Sept. 14, 2014, 12:26 p.m., Mark Gaiser wrote:
My attempt at this. Feel free to use it as you see fit.
diff --git a/src/urifilters/shorturi/kshorturifilter.cpp
b/src/urifilters/shorturi/kshorturifilter.cpp
index 00668d9..6c35393 100644
--- a/src/urifilters/shorturi/kshorturifilter.cpp
+++ b/src/urifilters/shorturi/kshorturifilter.cpp
@@ -130,6 +130,24 @@ bool KShortUriFilter::filterUri( KUriFilterData data
) const
//QUrl url = data.uri();
QString cmd = data.typedString();
+ // If a string starts with forward slashes, replace it by one forward
slash.
+ if (cmd.startsWith('/')) {
+ const int cmdLength = cmd.length();
+ for (int i = 0; i cmdLength; i++) {
+ if (cmd[i] != '/') {
+ QString slashes = cmd.left(i).replace(QRegExp(/+), /);
+ cmd.replace(0, i, slashes);
+ break;
+ }
+
+ // The full string contains slashes..
+ if (i == cmdLength - 1) {
+ cmd = /;
+ break;
+ }
+ }
+ }
+
// Replicate what KUrl(cmd) did in KDE4. This could later be folded into
the checks further down...
QUrl url(cmd);
if (QDir::isAbsolutePath(cmd)) {
I'm not sure if this approach is always OK. It works with the current test
cases and those two that Arjun added.
Mark Gaiser wrote:
Reviewboard kinda screwed that paste up.. Here is a better paste:
http://paste.kde.org/p96gvcrcp (1 month lifetime)
Alexander Richardson wrote:
Wouldn't it be more efficent to find the index of the first non-slash
char and then use QString::mid(lastSlashIndex) instead of QRegExp?
Mark Gaiser wrote:
Yes, that would be better.
Urgh, asking for speed and seeing a QRegExp in the answer... :-)
I was thinking simply of
bool onlySlashes = true;
for (int i = 0; i cmd.length() onlySlashes; ++i) {
onlySlashes = cmd.at(i) == '/';
}
if (onlySlashes) {
cmd.resize(1);
}
But indeed this leaves the question of what to do with //something.
I think I was wrong previously, there's no particular reason to assume
file://host or smb://host from that (it's not \host).
So we could also remove leading slashes even if the string isn't only just
slashes.
int firstNonSlash = 0;
while (firstNonSlash cmd.length() cmd.at(firstNonSlash) == '/') {
++firstNonSlash;
}
if (firstNonSlash 1) {
cmd = cmd.mid(firstNonSlash - 1);
}
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/#review66454
---
On Sept. 11, 2014, 8:50 a.m., Arjun Ak wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/
---
(Updated Sept. 11, 2014, 8:50 a.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
///... should produce `QUrl(file:///)` not `QUrl(file://)`
Diffs
-
autotests/kurifiltertest.cpp b84dcd0
src/urifilters/shorturi/kshorturifilter.cpp 00668d9
Diff: https://git.reviewboard.kde.org/r/120138/diff/
Testing
---
Thanks,
Arjun Ak
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: plasmate fails to build on branch frameworks
On Sunday 14 September 2014 18:28:16 Marko Käning wrote: On 14 Sep 2014, at 16:24 , Marko Käning mk-li...@email.de wrote: Linux/CI hang, because there was a missing dependency to kdevplatform. This has been fixed by now, but Jenkins master hasn’t picked up the dependency change yet. After two hours I triggered another rebuild, which pulled the corrected deps in and eventually resulted in the same error as the OSX/CI system. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Note: Plasmate needs to be fixed to work on the current kdevplatform. We've done the invasive KUrl-QUrl port there which of course broke source compatibility. Greets -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Broken KWindowInfoX11Test::testActivities on CI system
Hi Ivan, could you please have a look at KWindowInfoX11Test::testActivities. The unit test fails on the CI system and also locally with a setup similar to CI system (passes with KWin, though). To get a clean setup ensure to have an Xvfb running and an openbox on that Xvfb. The unit test looks somewhat wrong to me. E.g. there is an initial activity set which doesn't fit the NETWinInfo code. To me it looks like the test is dependent on behavior of KWin. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120214: Extend NetWinInfoTestClient::testActivities()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- Review request for KDE Frameworks, kwin and Ivan Čukić. Repository: kwindowsystem Description --- Use NETWinInfo.setActivities instead of changing the property manually. And extend the test cases so that all special cases for all activities are also covered. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa Diff: https://git.reviewboard.kde.org/r/120214/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119997: Add documentation to KConfig::sync()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119997/ --- (Updated Sept. 15, 2014, 10:28 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kconfig Description --- The docs at api.kde.org shows just Reimplemented from superclass. for the sync() method, however the superclass, KConfigBase, is not available at the api.kde.org. So this copies the documentation from KConfigBase to KConfig so the text can actually be visible at api.kde.org Diffs - src/core/kconfig.h d7d4b7d Diff: https://git.reviewboard.kde.org/r/119997/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66519 --- Looks ok, does it pass now? - Ivan Čukić On Sept. 15, 2014, 8:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- (Updated Sept. 15, 2014, 8:14 a.m.) Review request for KDE Frameworks, kwin and Ivan Čukić. Repository: kwindowsystem Description --- Use NETWinInfo.setActivities instead of changing the property manually. And extend the test cases so that all special cases for all activities are also covered. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa Diff: https://git.reviewboard.kde.org/r/120214/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()
On Sept. 15, 2014, 10:32 a.m., Ivan Čukić wrote: Looks ok, does it pass now? this test already passed, the failing one is KWindowInfoTestX11. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66519 --- On Sept. 15, 2014, 10:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- (Updated Sept. 15, 2014, 10:14 a.m.) Review request for KDE Frameworks, kwin and Ivan Čukić. Repository: kwindowsystem Description --- Use NETWinInfo.setActivities instead of changing the property manually. And extend the test cases so that all special cases for all activities are also covered. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa Diff: https://git.reviewboard.kde.org/r/120214/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120138: kshorturifilter : Treat ///... as /
On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote:
My attempt at this. Feel free to use it as you see fit.
diff --git a/src/urifilters/shorturi/kshorturifilter.cpp
b/src/urifilters/shorturi/kshorturifilter.cpp
index 00668d9..6c35393 100644
--- a/src/urifilters/shorturi/kshorturifilter.cpp
+++ b/src/urifilters/shorturi/kshorturifilter.cpp
@@ -130,6 +130,24 @@ bool KShortUriFilter::filterUri( KUriFilterData data
) const
//QUrl url = data.uri();
QString cmd = data.typedString();
+ // If a string starts with forward slashes, replace it by one forward
slash.
+ if (cmd.startsWith('/')) {
+ const int cmdLength = cmd.length();
+ for (int i = 0; i cmdLength; i++) {
+ if (cmd[i] != '/') {
+ QString slashes = cmd.left(i).replace(QRegExp(/+), /);
+ cmd.replace(0, i, slashes);
+ break;
+ }
+
+ // The full string contains slashes..
+ if (i == cmdLength - 1) {
+ cmd = /;
+ break;
+ }
+ }
+ }
+
// Replicate what KUrl(cmd) did in KDE4. This could later be folded into
the checks further down...
QUrl url(cmd);
if (QDir::isAbsolutePath(cmd)) {
I'm not sure if this approach is always OK. It works with the current test
cases and those two that Arjun added.
Mark Gaiser wrote:
Reviewboard kinda screwed that paste up.. Here is a better paste:
http://paste.kde.org/p96gvcrcp (1 month lifetime)
Alexander Richardson wrote:
Wouldn't it be more efficent to find the index of the first non-slash
char and then use QString::mid(lastSlashIndex) instead of QRegExp?
Mark Gaiser wrote:
Yes, that would be better.
David Faure wrote:
Urgh, asking for speed and seeing a QRegExp in the answer... :-)
I was thinking simply of
bool onlySlashes = true;
for (int i = 0; i cmd.length() onlySlashes; ++i) {
onlySlashes = cmd.at(i) == '/';
}
if (onlySlashes) {
cmd.resize(1);
}
But indeed this leaves the question of what to do with //something.
I think I was wrong previously, there's no particular reason to assume
file://host or smb://host from that (it's not \host).
So we could also remove leading slashes even if the string isn't only
just slashes.
int firstNonSlash = 0;
while (firstNonSlash cmd.length() cmd.at(firstNonSlash) == '/') {
++firstNonSlash;
}
if (firstNonSlash 1) {
cmd = cmd.mid(firstNonSlash - 1);
}
You have to love QRegExp :)
But yeah, the while loop works better.
- Mark
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/#review66454
---
On sep 11, 2014, 8:50 a.m., Arjun Ak wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/
---
(Updated sep 11, 2014, 8:50 a.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
///... should produce `QUrl(file:///)` not `QUrl(file://)`
Diffs
-
autotests/kurifiltertest.cpp b84dcd0
src/urifilters/shorturi/kshorturifilter.cpp 00668d9
Diff: https://git.reviewboard.kde.org/r/120138/diff/
Testing
---
Thanks,
Arjun Ak
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120138: kshorturifilter : Treat ///... as /
On Sept. 14, 2014, 5:56 p.m., Mark Gaiser wrote:
My attempt at this. Feel free to use it as you see fit.
diff --git a/src/urifilters/shorturi/kshorturifilter.cpp
b/src/urifilters/shorturi/kshorturifilter.cpp
index 00668d9..6c35393 100644
--- a/src/urifilters/shorturi/kshorturifilter.cpp
+++ b/src/urifilters/shorturi/kshorturifilter.cpp
@@ -130,6 +130,24 @@ bool KShortUriFilter::filterUri( KUriFilterData data
) const
//QUrl url = data.uri();
QString cmd = data.typedString();
+ // If a string starts with forward slashes, replace it by one forward
slash.
+ if (cmd.startsWith('/')) {
+ const int cmdLength = cmd.length();
+ for (int i = 0; i cmdLength; i++) {
+ if (cmd[i] != '/') {
+ QString slashes = cmd.left(i).replace(QRegExp(/+), /);
+ cmd.replace(0, i, slashes);
+ break;
+ }
+
+ // The full string contains slashes..
+ if (i == cmdLength - 1) {
+ cmd = /;
+ break;
+ }
+ }
+ }
+
// Replicate what KUrl(cmd) did in KDE4. This could later be folded into
the checks further down...
QUrl url(cmd);
if (QDir::isAbsolutePath(cmd)) {
I'm not sure if this approach is always OK. It works with the current test
cases and those two that Arjun added.
Mark Gaiser wrote:
Reviewboard kinda screwed that paste up.. Here is a better paste:
http://paste.kde.org/p96gvcrcp (1 month lifetime)
Alexander Richardson wrote:
Wouldn't it be more efficent to find the index of the first non-slash
char and then use QString::mid(lastSlashIndex) instead of QRegExp?
Mark Gaiser wrote:
Yes, that would be better.
David Faure wrote:
Urgh, asking for speed and seeing a QRegExp in the answer... :-)
I was thinking simply of
bool onlySlashes = true;
for (int i = 0; i cmd.length() onlySlashes; ++i) {
onlySlashes = cmd.at(i) == '/';
}
if (onlySlashes) {
cmd.resize(1);
}
But indeed this leaves the question of what to do with //something.
I think I was wrong previously, there's no particular reason to assume
file://host or smb://host from that (it's not \host).
So we could also remove leading slashes even if the string isn't only
just slashes.
int firstNonSlash = 0;
while (firstNonSlash cmd.length() cmd.at(firstNonSlash) == '/') {
++firstNonSlash;
}
if (firstNonSlash 1) {
cmd = cmd.mid(firstNonSlash - 1);
}
Mark Gaiser wrote:
You have to love QRegExp :)
But yeah, the while loop works better.
From
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap04.html#tag_04_11:
A pathname that begins with two successive slashes may be interpreted in an
implementation-defined manner, although more than two leading slashes shall
be treated as a single slash.
So, what should be done with two slashes?
- Arjun
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/#review66454
---
On Sept. 11, 2014, 2:20 p.m., Arjun Ak wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/
---
(Updated Sept. 11, 2014, 2:20 p.m.)
Review request for KDE Frameworks.
Repository: kio
Description
---
///... should produce `QUrl(file:///)` not `QUrl(file://)`
Diffs
-
autotests/kurifiltertest.cpp b84dcd0
src/urifilters/shorturi/kshorturifilter.cpp 00668d9
Diff: https://git.reviewboard.kde.org/r/120138/diff/
Testing
---
Thanks,
Arjun Ak
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/#review66527 --- Ship it! Ship It! - Ivan Čukić On Sept. 15, 2014, 8:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- (Updated Sept. 15, 2014, 8:14 a.m.) Review request for KDE Frameworks, kwin and Ivan Čukić. Repository: kwindowsystem Description --- Use NETWinInfo.setActivities instead of changing the property manually. And extend the test cases so that all special cases for all activities are also covered. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa Diff: https://git.reviewboard.kde.org/r/120214/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- If WM2Urgency is passed to the ctor of KWindowInfo, ::state() checks the urgency state is set and adds NET::DemandsAttention. This allows to easily check whether the window demands attention either through EWMH or ICCCM. The change does not affect existing code as one has to explicitly pass WM2Urgency and this one is new in 5.3, too. This change only affects platform X11. CHANGELOG: KWindowInfo::state can map urgency to NET::DemandsAttention Diffs - autotests/kwindowinfox11test.cpp 3ff6a49447a99d9afdabe6c96361b276083de525 src/kwindowinfo.h b00e115f293231b661934d20e97be4d186f679de src/kwindowinfo_x11.cpp 2a32692a0f664d6a9884e6d1a1209e88e02944ec Diff: https://git.reviewboard.kde.org/r/120217/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120214: Extend NetWinInfoTestClient::testActivities()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120214/ --- (Updated Sept. 15, 2014, 2:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kwin and Ivan Čukić. Repository: kwindowsystem Description --- Use NETWinInfo.setActivities instead of changing the property manually. And extend the test cases so that all special cases for all activities are also covered. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa Diff: https://git.reviewboard.kde.org/r/120214/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #97
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. - Aleix Pol Gonzalez On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kconfigwidgets should install have kf5_entry.desktop
On Fri, Sep 12, 2014 at 5:56 PM, Albert Astals Cid aa...@kde.org wrote: Hi David, kf-ers KLanguageButton is using kf5_entry.desktop as seen on http://lxr.kde.org/search?v=kf5-qt5_filestring=_string=+KLanguageButton It seems that the packaging scripts are not aware of it and thus it is not getting packaged/installed. David can you make sure the files get packaged and installed for the next frameworks release? Do you want a bug? Cheers, Albert Maybe it should get installed by KConfigWidgets rather than kdelibs4support? I'm getting this file installed as prefix/share/locale/en_US/kf5_entry.desktop I remember there were 2 kinds of entry.desktop files back in kdelibs4, I'm unsure if this one is the one we need now... Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Christoph Cullmann wrote: Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? Yes, +1 to that. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 14, 2014, 10:19 a.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindGIT2.rst PRE-CREATION find-modules/FindGIT2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #765
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/765/ -- Started by upstream project plasma-framework_master_qt5 build number 765 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson8815982495190903815.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 2662081..a159208 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 2662081 Don't include configmodel in doxygen Success build forhudson.tasks.Shell@298ad8c git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/plasma-framework.git # timeout=10 Fetching upstream changes from git://anongit.kde.org/plasma-framework.git git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/plasma-framework.git +refs/heads/*:refs/remotes/origin/* Checking out Revision 052a0c32ae554a3af068b9d89a0aed6a4d342125 (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f 052a0c32ae554a3af068b9d89a0aed6a4d342125 git rev-list 052a0c32ae554a3af068b9d89a0aed6a4d342125 # timeout=10 [LINBUILDER] $ /bin/sh -xe /tmp/hudson327039002482743109.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: ktexteditor - Branch master polkit-qt-1 - Branch master kauth - Branch master dogtail - Branch master cmake - Branch master kglobalaccel - Branch master kwindowsystem - Branch master kbookmarks - Branch master attica - Branch master kiconthemes - Branch master kio - Branch master kdbusaddons - Branch master kdoctools - Branch master solid - Branch master kunitconversion - Branch master karchive - Branch master kcompletion - Branch master sonnet - Branch master kcoreaddons - Branch master kdeclarative - Branch master kparts - Branch master kjs - Branch master kconfigwidgets - Branch master threadweaver - Branch master kxmlgui - Branch master kidletime - Branch master kcmutils - Branch master kdnssd - Branch master kwidgetsaddons - Branch master kitemviews - Branch master kguiaddons - Branch master qt5 - Branch stable knotifications - Branch master kactivities - Branch master phonon - Branch master kcrash - Branch master extra-cmake-modules - Branch master kwallet - Branch master ki18n - Branch master ktextwidgets - Branch master kservice - Branch master kjobwidgets - Branch master kitemmodels - Branch master kross - Branch master kcodecs - Branch master kconfig - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server ssh: connect to host build.kde.org port 2022: Connection timed out rsync: connection unexpectedly closed (0 bytes received so far) [Receiver] rsync error: unexplained error (code 255) at io.c(605) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #766
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/766/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kconfigwidgets should install have kf5_entry.desktop
El Dilluns, 15 de setembre de 2014, a les 17:45:06, Aleix Pol va escriure: On Fri, Sep 12, 2014 at 5:56 PM, Albert Astals Cid aa...@kde.org wrote: Hi David, kf-ers KLanguageButton is using kf5_entry.desktop as seen on http://lxr.kde.org/search?v=kf5-qt5_filestring=_string=+KLanguageButton It seems that the packaging scripts are not aware of it and thus it is not getting packaged/installed. David can you make sure the files get packaged and installed for the next frameworks release? Do you want a bug? Cheers, Albert Maybe it should get installed by KConfigWidgets rather than kdelibs4support? Yes, that's what i am suggesting. Cheers, Albert I'm getting this file installed as prefix/share/locale/en_US/kf5_entry.desktop I remember there were 2 kinds of entry.desktop files back in kdelibs4, I'm unsure if this one is the one we need now... Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Changes --- Rename to FindLibGit2 Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs (updated) - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. Aleix Pol Gonzalez wrote: I'm unsure it's inconsistent. The project is actually called libgit2, because it's a library that does git things: https://libgit2.github.com/ As an example, here's archlinux: https://www.archlinux.org/packages/extra/i686/git/ https://www.archlinux.org/packages/community/x86_64/libgit2/ And in general, archlinux doesn't prefix the lib for frameworks anyway: https://www.archlinux.org/packages/extra/x86_64/kcoreaddons/ Does that make sense? :) Christoph Cullmann wrote: Ok, that seems to be reasonable, will change that, if Alex is ok with that, too ;=) Other remarks? Christoph Cullmann wrote: Btw., that rename would imply that the vars are LIBGIT2_... and the Target would be LibGit2::LibGit2, or? Aleix Pol Gonzalez wrote: Yes, +1 to that. Renamed, its ok? Need to retest it again, but in principle should work. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 15, 2014, 6:30 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66593 --- Yep, I think the name change is sensible. find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46410 Whitespace find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46413 Remove this comment (I know it's in other modules, but the comment isn't really true, especially once you remove VERSION_STRING). find-modules/FindLibGit2.cmake https://git.reviewboard.kde.org/r/120196/#comment46412 Don't need this one in a completely new module. - Alex Merry On Sept. 15, 2014, 6:30 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks and Alex Merry. Changes --- Fixed stuff in comments ;) Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs (updated) - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66594 --- Ship it! Ship It! - Alex Merry On Sept. 15, 2014, 6:56 p.m., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120196: Find-Module to detect libgit2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 7:11 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake-modules Description --- Add a find module that allows to detect libgit2. Will be used by KTextEditor Kate. Will remove the copy in KTextEditor after this is merged. Diffs - docs/find-module/FindLibGit2.rst PRE-CREATION find-modules/FindLibGit2.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120200: Only create one instance of defaultExecutor.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120200/ --- (Updated Sept. 15, 2014, 8:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: threadweaver Description --- Being declared with file-local linkage in a header file we ended up with six instances, one per file that includes job_p.h. Diffs - src/job_p.h 937e9d40d72ea88094a412943a1291fa1c290f0e src/job_p.cpp 4bfc7d6db278a223774f4fd849468868b2eafa6c Diff: https://git.reviewboard.kde.org/r/120200/diff/ Testing --- Thanks, Volker Krause ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120213: Add support for protocols to NETWinInfo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120213/#review66605
---
Ship it!
Minor notes only.
However, I assume you also want to add protocol invocation (like exists for
pinging the window) and therefore a preemtive warning:
I'll *strongly* veto exposing the sync protocol to random clients (since we
know the effects of a double sync ;-)
src/netwm.cpp
https://git.reviewboard.kde.org/r/120213/#comment46415
p-protocols = NoProtocol;?
(ie. have an enum for the empty case and also why operate on a temp
variable?)
src/netwm.cpp
https://git.reviewboard.kde.org/r/120213/#comment46417
switch(*it) { ... might be more readable, but i've no preference ;-)
src/netwm.cpp
https://git.reviewboard.kde.org/r/120213/#comment46416
Tarzan speech. Consider:
- TakeFocusProtocol
- Protocol::TakeFocus
src/netwm_def.h
https://git.reviewboard.kde.org/r/120213/#comment46414
by the client?
- Thomas Lübking
On Sept. 15, 2014, 7:29 vorm., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120213/
---
(Updated Sept. 15, 2014, 7:29 vorm.)
Review request for KDE Frameworks and kwin.
Repository: kwindowsystem
Description
---
NETWinInfo is now able to read all known protocols set on WM_PROTOCOLS
property and provides the set protocols as flags.
So far the following protocols are supported:
* WM_TAKE_FOCUS (ICCCM 4.1.2.7)
* WM_DELETE_WINDOW (ICCCM 4.1.2.7)
* _NET_WM_SYNC_REQUEST (EWMH)
* _NET_WM_PING (EWMH)
* _NET_WM_CONTEXT_HELP (KDE specific extension to EWMH)
CHANGELOG: NETWinInfo provides convenient wrapper for WM_PROTOCOLS.
Diffs
-
autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa
src/netwm.h 436ad2fd449b48a36d3bb15754f7c8c64f52c8dd
src/netwm.cpp 1431cf6bae605050e2e86f7ca60357ddb7736d32
src/netwm_def.h 12abfff03af5b81a60ec03a5366b6ff0b95d35d0
src/netwm_p.h a586450211846af464c9014f586e14b0e808cd75
Diff: https://git.reviewboard.kde.org/r/120213/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kdelibs4support does not contain any .po
Hi David, kf-ers I can't find any .po inside kdelibs4support tarball. David can you make sure the files get packaged and installed for the next frameworks release? Do you want a bug? Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/#review66618 --- If we merge, we should imo merge in NetWinInfo - having the same function return different values in NetWinInfo and KWindowInfo feels wrong. - Thomas Lübking On Sept. 15, 2014, 1:29 nachm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- (Updated Sept. 15, 2014, 1:29 nachm.) Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- If WM2Urgency is passed to the ctor of KWindowInfo, ::state() checks the urgency state is set and adds NET::DemandsAttention. This allows to easily check whether the window demands attention either through EWMH or ICCCM. The change does not affect existing code as one has to explicitly pass WM2Urgency and this one is new in 5.3, too. This change only affects platform X11. CHANGELOG: KWindowInfo::state can map urgency to NET::DemandsAttention Diffs - autotests/kwindowinfox11test.cpp 3ff6a49447a99d9afdabe6c96361b276083de525 src/kwindowinfo.h b00e115f293231b661934d20e97be4d186f679de src/kwindowinfo_x11.cpp 2a32692a0f664d6a9884e6d1a1209e88e02944ec Diff: https://git.reviewboard.kde.org/r/120217/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: desktoptojson man page
Hi Micheal, 2014-09-15 19:57 GMT+02:00 Michael Palimaka kensing...@gentoo.org: Hi there, In kservice at b427f4c3889004d9d983939cd9bf7c1465e6beb3, desktoptojson was replaced/moved to kcoreaddons. However, it appears the man page was forgotten and that still exists in kservice. I'd move it myself, but I'm not confident in transferring the history correctly. Best regards, Michael I'm afraid I don't know how to transfer it while conserving the history. However, is this even possible? Building manpages seems to require KDocTools and kcoreaddons is a tier1 framework which would make this impossible. Do we really need a manpage for it? It seems to me that it is only used in cmake code and should no longer be necessary once we write the .json files directly instead of converting the existing .desktop files. Maybe we should just move it from bin to libexec? Regards, Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention
On Sept. 16, 2014, 12:28 a.m., Thomas Lübking wrote: If we merge, we should imo merge in NetWinInfo - having the same function return different values in NetWinInfo and KWindowInfo feels wrong. I considered it, but decided against it as I consider NETWinInfo to be a level lower to X and exposing it directly. KWindowInfo on the other hand is a convenient wrapper. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/#review66618 --- On Sept. 15, 2014, 3:29 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120217/ --- (Updated Sept. 15, 2014, 3:29 p.m.) Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- If WM2Urgency is passed to the ctor of KWindowInfo, ::state() checks the urgency state is set and adds NET::DemandsAttention. This allows to easily check whether the window demands attention either through EWMH or ICCCM. The change does not affect existing code as one has to explicitly pass WM2Urgency and this one is new in 5.3, too. This change only affects platform X11. CHANGELOG: KWindowInfo::state can map urgency to NET::DemandsAttention Diffs - autotests/kwindowinfox11test.cpp 3ff6a49447a99d9afdabe6c96361b276083de525 src/kwindowinfo.h b00e115f293231b661934d20e97be4d186f679de src/kwindowinfo_x11.cpp 2a32692a0f664d6a9884e6d1a1209e88e02944ec Diff: https://git.reviewboard.kde.org/r/120217/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: ark fails to build on branch frameworks
Is ark not yet fully ported to KF5 - on Linux perhaps as well? --- Users/marko/WC/KDECI-builds/ark/part/arkviewer.cpp:255:24: error: no matching constructor for initialization of 'KRun' KRun *runner = new KRun(url, 0, 0, false); ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/krun.h:85:5: note: candidate constructor not viable: no known conversion from 'bool' to 'const QByteArray' for 4th argument KRun(const QUrl url, QWidget *window, ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/krun.h:60:25: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 4 were provided class KIOWIDGETS_EXPORT KRun : public QObject ^ 4 warnings generated. Linking CXX executable ark.app/Contents/MacOS/ark 16 warnings and 1 error generated. make[2]: *** [part/CMakeFiles/arkpart.dir/arkviewer.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120213: Add support for protocols to NETWinInfo
On Sept. 15, 2014, 10:34 p.m., Thomas Lübking wrote: Minor notes only. However, I assume you also want to add protocol invocation (like exists for pinging the window) and therefore a preemtive warning: I'll *strongly* veto exposing the sync protocol to random clients (since we know the effects of a double sync ;-) No, I don't plan to add protocol invocation. The ping protocol is already implemented and it's using a virtual. So keeping the same approach without introducing a NETWinInfo2 is not possible and I have zero interest in that. On Sept. 15, 2014, 10:34 p.m., Thomas Lübking wrote: src/netwm.cpp, line 4630 https://git.reviewboard.kde.org/r/120213/diff/1/?file=312330#file312330line4630 Tarzan speech. Consider: - TakeFocusProtocol - Protocol::TakeFocus we are (to my understanding) not allowed to use the enum class from C++11. As netwm_def.h is shared between the implementations I cannot even argument with but it's not compiled on Windows. So I'll switch to the TakeFocusProtocol approach. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/#review66605 --- On Sept. 15, 2014, 9:29 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- (Updated Sept. 15, 2014, 9:29 a.m.) Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- NETWinInfo is now able to read all known protocols set on WM_PROTOCOLS property and provides the set protocols as flags. So far the following protocols are supported: * WM_TAKE_FOCUS (ICCCM 4.1.2.7) * WM_DELETE_WINDOW (ICCCM 4.1.2.7) * _NET_WM_SYNC_REQUEST (EWMH) * _NET_WM_PING (EWMH) * _NET_WM_CONTEXT_HELP (KDE specific extension to EWMH) CHANGELOG: NETWinInfo provides convenient wrapper for WM_PROTOCOLS. Diffs - autotests/netwininfotestclient.cpp e35ab8d83b1e0c1af42dacc7f330cbc3b9b899aa src/netwm.h 436ad2fd449b48a36d3bb15754f7c8c64f52c8dd src/netwm.cpp 1431cf6bae605050e2e86f7ca60357ddb7736d32 src/netwm_def.h 12abfff03af5b81a60ec03a5366b6ff0b95d35d0 src/netwm_p.h a586450211846af464c9014f586e14b0e808cd75 Diff: https://git.reviewboard.kde.org/r/120213/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: ark fails to build on branch frameworks
On Tue, Sep 16, 2014 at 11:09 AM, Marko Käning mk-li...@email.de wrote: Users/marko/WC/KDECI-builds/ark/part/arkviewer.cpp:255:24: error: no matching constructor for initialization of 'KRun' KRun *runner = new KRun(url, 0, 0, false); ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/krun.h:85:5: note: candidate constructor not viable: no known conversion from 'bool' to 'const QByteArray' for 4th argument KRun(const QUrl url, QWidget *window, ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio/inst/include/KF5/KIOWidgets/krun.h:60:25: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 4 were provided class KIOWIDGETS_EXPORT KRun : public QObject Umm strange, I don't see this error.. I myself have ported it and it works fine here.. let me try and see what can cause this error.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120213: Add support for protocols to NETWinInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- (Updated Sept. 16, 2014, 7:55 a.m.) Review request for KDE Frameworks. Changes --- updated as suggested Repository: kwindowsystem Description (updated) --- NETWinInfo is now able to read all known protocols set on WM_PROTOCOLS property and provides the set protocols as flags. So far the following protocols are supported: * WM_TAKE_FOCUS (ICCCM 4.1.2.7) * WM_DELETE_WINDOW (ICCCM 4.1.2.7) * _NET_WM_SYNC_REQUEST (EWMH) * _NET_WM_PING (EWMH) * _NET_WM_CONTEXT_HELP (KDE specific extension to EWMH) CHANGELOG: NETWinInfo provides convenient wrapper for WM_PROTOCOLS. Diffs (updated) - autotests/netwininfotestclient.cpp 7d941f4b32a546c8284ab81995f594cd9e69617e src/netwm.h 436ad2fd449b48a36d3bb15754f7c8c64f52c8dd src/netwm.cpp 1431cf6bae605050e2e86f7ca60357ddb7736d32 src/netwm_def.h 12abfff03af5b81a60ec03a5366b6ff0b95d35d0 src/netwm_p.h a586450211846af464c9014f586e14b0e808cd75 Diff: https://git.reviewboard.kde.org/r/120213/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: ark fails to build on branch frameworks
On Tue, Sep 16, 2014 at 11:13 AM, Bhushan Shah bhus...@gmail.com wrote: Umm strange, I don't see this error.. I myself have ported it and it works fine here.. let me try and see what can cause this error.. Okay now I see problem, in KF5 constructor is, KRun (const QUrl url, QWidget *window, bool showProgressInfo=true, const QByteArray asn=QByteArray()) While in KDE4 version constructor was, KRun (const KUrl url, QWidget *window, mode_t mode=0, bool isLocalFile=false, bool showProgressInfo=true, const QByteArray asn=QByteArray()) and in Linux somehow KRun *runner = new KRun(url, 0, 0, false); is working fine, will correct it in little time.. -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
