On 18 Sep 2014, at 07:52 , Martin Gräßlin mgraess...@kde.org wrote:
That's not what I meant. I mean we have things like frameworks which require
only Qt 5.2, but we also have things like e.g. KWin requiring Qt 5.3 (soon
5.4). This will require two Qt builds, while we currently have only one.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120257/
---
Review request for KDE Frameworks and kwin.
Repository: kwindowsystem
On Thu, Sep 18, 2014 at 6:04 PM, Marko Käning mk-li...@email.de wrote:
On 18 Sep 2014, at 07:52 , Martin Gräßlin mgraess...@kde.org wrote:
That's not what I meant. I mean we have things like frameworks which require
only Qt 5.2, but we also have things like e.g. KWin requiring Qt 5.3 (soon
On Thursday, 18 September 2014 10:10:41 CEST, Ben Cooksley wrote:
This would still apply even after the implementation of new scheme for
dependencies and other build metadata.
Where do I learn about these new features?
Cheers,
Jan
--
Trojitá, a fast Qt IMAP e-mail client --
On Thu, Sep 18, 2014 at 9:30 PM, Jan Kundrát j...@flaska.net wrote:
On Thursday, 18 September 2014 10:10:41 CEST, Ben Cooksley wrote:
This would still apply even after the implementation of new scheme for
dependencies and other build metadata.
Where do I learn about these new features?
See
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/
---
(Updated Set. 18, 2014, 10:06 a.m.)
Review request for KDE Frameworks
On Set. 17, 2014, 7:59 p.m., David Faure wrote:
Thanks for the patch. A few comments:
Is there any sort of spec or reference implementation for .hidden files?
Are they supposed to support wildcards, for instance?
Something else, it would be good to add a unittest to
On Sept. 13, 2014, 3:20 p.m., Milian Wolff wrote:
autotests/kmessagewidgetautotest.cpp, line 115
https://git.reviewboard.kde.org/r/120160/diff/1/?file=311761#file311761line115
Couldn't this actually check that no animation is running at all now?
We triggered the hide directly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/
---
(Updated Sept. 18, 2014, 10:40 a.m.)
Review request for KDE Frameworks,
On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote:
All in all, the patch looks good, but it misses emitting the signals
hideAnimationFinished() and showAnimationFinished().
Why? Without your patch, you can be *sure* that after calling show() or
animatedShow() the signal
On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote:
src/core/kcoredirlister.cpp, line 1218
https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line1218
const
Bruno Nova wrote:
What do you mean? `filesToHide` should be `const`?
(I thought I had added
Hi Ivan,
I've just learned that the KActivities framework is not co-installable with
kdelibs4.
We should fix that in a way or another, this makes the whole
plasma-framework (or anything else depending on KActivities) not
co-installable as well, which is quite bad as some applications still need
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/#review66825
---
Ship it!
some more nitpickery from my side, but otherwise
2014-09-17 14:12 GMT-03:00 Nicolás Alvarez nicolas.alva...@gmail.com:
If we'll keep the compiler requirements as-is, I volunteer to fix
what's broken in the minimum versions we claim to support. But I think
we need CI for gcc 4.5, otherwise it will keep breaking...
Okay, that wasn't so hard.
See
http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/104/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote:
All in all, the patch looks good, but it misses emitting the signals
hideAnimationFinished() and showAnimationFinished().
Why? Without your patch, you can be *sure* that after calling show() or
animatedShow() the signal
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120257/#review66844
---
Ship it!
src/netwm_def.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/
---
Review request for KDE Frameworks and David Faure.
Bugs: 339123
On Sept. 12, 2014, 10:49 a.m., Christoph Feck wrote:
Use KPixmapSequence if you need to access an FDO animation icon.
Dan Vrátil wrote:
That's the thing: I want to feed the animation icon to KPixmapSequence,
but KPixmapSequence only accepts full file path, or QPixmap. And I can't
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/#review66869
---
src/kmessagewidget.cpp
On Sept. 18, 2014, 8:52 p.m., Christoph Feck wrote:
src/kmessagewidget.cpp, line 412
https://git.reviewboard.kde.org/r/120160/diff/2/?file=313126#file313126line412
Would it make sense to emit hideAnimationFinished() before reversing
the direction to showing? Likewise for the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/#review66871
---
I would really like to hear Aurelien's opinion, but maybe you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120142/
---
(Updated Sept. 18, 2014, 9:14 p.m.)
Status
--
This change has been
On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote:
After some discussion with the SDK and Book groups in the sprint, I think
we should move this into the kde:kwidgetsaddons repository, in an examples
subdirectory.
Laurent Navet wrote:
do you want me to move this from
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119777/
---
(Updated Sept. 18, 2014, 9:43 p.m.)
Status
--
This change has been
25 matches
Mail list logo
