Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-07 Thread Marko Käning
Hi Bhushan, On 08 Oct 2014, at 08:44 , Bhushan Shah wrote: > #ifdef HAVE_BALOO >#include > -#include > #endif > +#include > > Can you try this? that fixed some stuff, but not all: --- [ 91%] [ 91%] Building CXX object dolphin/src/tests/CMakeFiles/viewpropertiestest.dir/testdir.cpp.o Bui

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-07 Thread Bhushan Shah
Hello On Wed, Oct 8, 2014 at 12:04 PM, Marko Käning wrote: > Dolphin is currently broken on OSX: > #ifdef HAVE_BALOO #include -#include #endif +#include Can you try this? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https:

OSX/CI: kde-baseapps fails to build on branch frameworks

2014-10-07 Thread Marko Käning
Dolphin is currently broken on OSX: --- [ 49%] Building CXX object konqueror/src/CMakeFiles/kdeinit_konqueror.dir/konqviewmanager.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/views/dolphinview.cpp:571:25: error: use of undeclared identifier 'KFormat' KForm

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/ --- (Updated Oct. 7, 2014, 8:04 p.m.) Status -- This change has been mar

Re: Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-10-07 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120387/#review68063 --- Ship it! Ship It! - Valentin Rusu On Sept. 27, 2014, 11:44

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #826

2014-10-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120479: Add full C++ KDE Frameworks template

2014-10-07 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120479/ --- (Updated Oct. 7, 2014, 3:28 p.m.) Status -- This change has been mar

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/ --- (Updated Oct. 7, 2014, 2:22 p.m.) Review request for KDE Frameworks and D

Re: Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/#review68047 --- Looks good, I'd like someone giving it a second look though

Review Request 120519: Don't call 'enableTestMode' when QStandardPaths::isTestModeEnabled is false

2014-10-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120519/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #825

2014-10-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel