Re: Moving SVGTextureNode to KDeclarative
On Fri, Oct 10, 2014 at 11:37 PM, David Faure fa...@kde.org wrote: On Friday 10 October 2014 18:18:40 Marco Martin wrote: (but even if it doesn't export symbols i'm not sure removing target_link_libraries is bc?) Depends if it was a PUBLIC or PRIVATE library (in the target_link_libraries line). From your question I guess it wasn't specified, though, in which case I would assume public and not remove it. the library was linked in the PRIVATE section -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 11:13 a.m.) Review request for KDE Frameworks, David Edmundson and Marco Martin. Changes --- Added API documentation. Moved ManagedTextureNode into a separate file. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs (updated) - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68302 --- src/quickaddons/imagetexturescache.h https://git.reviewboard.kde.org/r/120550/#comment47603 would like some apidocs: at the beginning of the class some doc on why and how use this class, and just a bit of apidoc on loadTexture() - Marco Martin On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 11:13 a.m.) Review request for KDE Frameworks, David Edmundson and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68307 --- Ship it! apart managedtexturenode needing a dpointer, looks good src/quickaddons/managedtexturenode.h https://git.reviewboard.kde.org/r/120550/#comment47616 even if will always remain just this member, just to me sure, it should be in a dpointer - Marco Martin On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 11:13 a.m.) Review request for KDE Frameworks, David Edmundson and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: src/quickaddons/managedtexturenode.h, line 52 https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52 even if will always remain just this member, just to me sure, it should be in a dpointer I don't think it's a good idea to add a d-pointer there. It's a class to encapsulate the object, I don't see why we should store more things in there. If needs changed, then I'd suggest to create another class. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68307 --- On Oct. 13, 2014, 11:13 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 11:13 a.m.) Review request for KDE Frameworks, David Edmundson and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 5:54 p.m.) Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: src/quickaddons/managedtexturenode.h, line 52 https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52 even if will always remain just this member, just to me sure, it should be in a dpointer Aleix Pol Gonzalez wrote: I don't think it's a good idea to add a d-pointer there. It's a class to encapsulate the object, I don't see why we should store more things in there. If needs changed, then I'd suggest to create another class. if it's exported, i prefer a dpointer anyways - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68307 --- On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 5:54 p.m.) Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I18n issues in frameworks + kf5
Hi, I have some serious issues/problems with translations in frameworks/kf5: My System: separate user for frameworks/kf5 with ~/Qt5.3.0/ binary/sources/translation with ~/kf5/ up to date build from sources switch in konsole to kf5 user and launch app via commandline or plasmashell -w My ~/.config5/kdeglobals has: [Translations] LANGUAGE=de use any locale except en_US + x-test (partly broken in kf5) eg ca, de, it, uk to check these problems, install a locale via https://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module (replace l10n-kde4 with l10n-kf5 + use LANGUAGE instead of KDE_LANG) 1) $ kdebugdialog5 Search: from kitemviews5_qt not translated Help, OK, Apply, Cancel (via KDialog-QDialog from Qt translations) not translated 2) $ kcmshell5 spellchecking all msgs from sonnet5_qt not translated conclusion: catalogs *_qt.po are apparently loaded, but translations from these catalogs are not displayed at runtime 3) $ kcmshell5 kcmshell commandline options translated (general option suntranslated see BR#339569) $ kcmshell5 --help kcmshell commandline options *untranslated* ??? Why translated/untranslated? different code paths catalog loading too late when untranslated 4) KWrite kwrite.po not loaded, so added add_definitions(-DTRANSLATION_DOMAIN=\kwrite\) in CMakeLists.txt, but still these i18n issues: Find Variants, Go To, Word Wrap, Borders, Code Folding, Word Completition, Spelling (from ktexteditor5.po data/katepartui.rc) Show Toolbar (from kconfig5_qt.po) DrClash involved here? all mags except Code Folding have no clash in po file, but in the gui via DrClash 5) Kate kate.po not loaded, so added add_definitions(-DTRANSLATION_DOMAIN=\kate\) in CMakeLists.txt, but still these i18n issues: same as KWrite + Split View, Sessions (from kate.po data/kateui.rc) DrClash? applications/kate/ has 26 translation catalogs, but only 8 are loaded, even the main catalogs kate.po + kwrite.po are NOT loaded 6) Print dialog launched from Kate/Kwrite - no strings from Qt translated Print dialog launched from designer - everything translated 7) all shortcuts Ctrl+Shift untranslated in menu items For me l10n/i18n in frameworks/kf5 is heavily broken :-( -- Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 120574: Add explicit to ctors with one parameter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Add explicit to ctors with one parameter Diffs - src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de Diff: https://git.reviewboard.kde.org/r/120574/diff/ Testing --- It builds and khotnewstuff test app still works. My only question is if this source incompatible change is allowed in frameworks or not. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: src/quickaddons/managedtexturenode.h, line 52 https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52 even if will always remain just this member, just to me sure, it should be in a dpointer Aleix Pol Gonzalez wrote: I don't think it's a good idea to add a d-pointer there. It's a class to encapsulate the object, I don't see why we should store more things in there. If needs changed, then I'd suggest to create another class. Marco Martin wrote: if it's exported, i prefer a dpointer anyways Can we please discuss this? I really don't think we want to be so cheap when it comes to memory usage. This means that each node in the scene will take a payload for no much reason. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68307 --- On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 5:54 p.m.) Review request for KDE Frameworks, Plasma, David Edmundson, and Marco Martin. Repository: kdeclarative Description --- Moves the caching types used in Plasma Workspace into a QuickAddons submodule. Adopts them in QIconItem by moving it from a QPainterItem to a QQuickPainter item. Uses the same strategies used in Plasma Framework for caching the textures. Diffs - src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 2977812 src/qmlcontrols/kquickcontrolsaddons/qiconitem.h 839a33f src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 0eb46b1 src/quickaddons/CMakeLists.txt PRE-CREATION src/quickaddons/imagetexturescache.h PRE-CREATION src/quickaddons/imagetexturescache.cpp PRE-CREATION src/quickaddons/managedtexturenode.h PRE-CREATION src/quickaddons/managedtexturenode.cpp PRE-CREATION tests/qiconitem_test.qml PRE-CREATION src/CMakeLists.txt eb0dfd3 Diff: https://git.reviewboard.kde.org/r/120550/diff/ Testing --- I added some manual test (that was impossible to run before the patch). Also tested it in KRunner and Muon Discover, which use the component. Everything still works. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
platforms
Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess not, is that correct? If not I can clean up some old ifdefs in knewstuff sources. thanks, Jeremy ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: platforms
It can be cleaned up ... other WinCE specifics had already been cleaned up in frameworks. 2014-10-13 20:59 GMT-03:00 Jeremy Whiting jpwhit...@kde.org: Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess not, is that correct? If not I can clean up some old ifdefs in knewstuff sources. thanks, Jeremy ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120574: Add explicit to ctors with one parameter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/#review68341 --- I think it's not allowed (though better ask Kevin or David) in which case I suggest: // TODO: KF6 make explicit - Martin Gräßlin On Oct. 14, 2014, 12:49 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- (Updated Oct. 14, 2014, 12:49 a.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Add explicit to ctors with one parameter Diffs - src/attica/atticaprovider_p.h 8638aff0e6548705a22f125a7adc25ff6b1db165 src/button.h 155b6dc5f4b032970bcd0e5400cf5dba12f76e81 src/core/engine_p.h f7a6884d9a22c56f1feff8b6c97fa242f46533da src/core/installation_p.h 9d855a26590dcee2259fe657fc7c3293669e3f81 src/core/xmlloader_p.h 7167417c1fcfbeafea1ceb9c7cb5eb56b9d8ac29 src/downloadwidget_p.h 37c7f0872fe0ff6fe65ab7bc63e1239f1b0d8e36 src/ui/itemsview_p.h df65d0b47abaddd404a171890e47af1b93c4203f src/ui/progressindicator_p.h 3d18bff8eac6b8a21f94da39b21b51ee334ec3de Diff: https://git.reviewboard.kde.org/r/120574/diff/ Testing --- It builds and khotnewstuff test app still works. My only question is if this source incompatible change is allowed in frameworks or not. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
