Re: Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120603/ --- (Updated Oct. 15, 2014, 11:30 p.m.) Status -- This change has been m

Re: Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120603/#review68528 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 15, 2014, 8

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 11:38 nachm.) Status -- This change has been

Re: Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120603/#review68523 --- Ship it! tnx. maybe KF5AuthMacros.cmake could also be adjuste

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/#review68522 --- Ship it! You're right that the comment, which I wrote, meant

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Oct. 15, 2014, 11:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
> On Oct. 15, 2014, 10:47 p.m., David Faure wrote: > > You're right that fromUserInput is wrong for relative paths (that should > > stay relative). fromUserInput turns them to http. > > > > However as the comment says, docPath could be either relative or absolute > > (at least both worked in K

Re: Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/#review68518 --- Well spotted, porting bug: (commit 3fde4d63887ecbb57ac92f61cc

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/#review68517 --- Ship it! Correct, thanks. But please also remove the redundan

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/#review68515 --- You're right that fromUserInput is wrong for relative paths (t

Review Request 120603: Use officially exported CMAKE paths

2014-10-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120603/ --- Review request for KDE Frameworks. Repository: kauth Description --

Re: Proxy Settings KCM

2014-10-15 Thread Albert Astals Cid
El Dimecres, 15 d'octubre de 2014, a les 12:03:17, Eike Hein va escriure: > Hi, > > I just noticed that we currently don't seem to have proxy > settings in Plasma 5, meaning that clicking "Proxy Settings" > in Rekonq or Google Chrome doesn't do anything because they > try to kcmshell something tha

Re: private export

2014-10-15 Thread Dominik Haumann
On Tuesday 14 October 2014 14:37:30 Jeremy Whiting wrote: > Hello, > > In KNewStuff autotests there are two disabled tests that build and > work if I export the Author and EntryInternal classes, but these two > classes are private (declared in _p.h files) so I'd rather not export > them, since the

Re: blogging about technical details (was: Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem)

2014-10-15 Thread Dominik Haumann
On Sunday 12 October 2014 22:57:33 David Faure wrote: > On Saturday 11 October 2014 16:40:55 Dominik Haumann wrote: > > Hi all, > > > > imho, these are changes that get mostly unnoticed, and hence close to no > > one will use this feature. I personally would find it very cool if there > > were lot

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #145

2014-10-15 Thread KDE CI System
See Changes: [montel] Port to QDialog -- [...truncated 2952 lines...] :253:40: warning: ‘void KUr

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #144

2014-10-15 Thread KDE CI System
See Changes: [montel] Port to QDialog -- [...truncated 2949 lines...] void KFindTreeView::removeItem(const KUrl & url) ^

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #143

2014-10-15 Thread KDE CI System
See Changes: [emmanuelpescosta099] Replaced the ItemState structure with QPair -- [...truncated 6997 lines...] KUrl m_popupUrl; ^

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #142

2014-10-15 Thread KDE CI System
See -- [...truncated 6949 lines...] KUrl::List currentURLs() const; ^

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

2014-10-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/#review68451 --- Ship it! Ship It! - Lukáš Tinkl On Říj. 15, 2014, 3:02 odp

Re: Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-15 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/ --- (Updated Říj. 15, 2014, 1:05 odp.) Review request for KDE Frameworks and

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

2014-10-15 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/ --- (Updated Říj. 15, 2014, 1:05 odp.) Review request for KDE Frameworks and

Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

2014-10-15 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-15 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120596/ --- (Updated Oct. 15, 2014, 11:24 a.m.) Status -- This change has been m

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 1:09 nachm.) Review request for KDE Frameworks an

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 1:08 nachm.) Review request for KDE Frameworks an

Re: Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120596/#review68445 --- Ship it! Inviala! - Marco Martin On Ott. 15, 2014, 10:50 a

Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120596/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 15, 2014, 10:50 a.m.) Status -- This change has been m

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Oct. 15, 2014, 10:42 a.m.) Review request for KDE Frameworks and

Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Proxy Settings KCM

2014-10-15 Thread Eike Hein
Hi, I just noticed that we currently don't seem to have proxy settings in Plasma 5, meaning that clicking "Proxy Settings" in Rekonq or Google Chrome doesn't do anything because they try to kcmshell something that doesn't exist. Turns out the KCM resides in Konqueror, much like Web Short- cuts

Jenkins build is back to stable : kservice_master_qt5 #191

2014-10-15 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel