Build failed in Jenkins: kde-baseapps_frameworks_qt5 #147

2014-10-16 Thread KDE CI System
See -- [...truncated 7556 lines...] [ 70%] [ 70%] Building CXX object dolphin/src/CMakeFiles/kcm_dolphingeneral.dir/settings/servicemodel.cpp.o Building CXX object dolphin/src/CMakeFiles/kdeinit_d

Re: Proxy Settings KCM

2014-10-16 Thread Burkhard Lück
Am Donnerstag, 16. Oktober 2014, 17:56:29 schrieb Michael Pyne: > On Wed, October 15, 2014 12:03:17 Eike Hein wrote: > > Hi, > > > > I just noticed that we currently don't seem to have proxy > > settings in Plasma 5, meaning that clicking "Proxy Settings" > > in Rekonq or Google Chrome doesn't do

Re: Proxy Settings KCM

2014-10-16 Thread Michael Pyne
On Wed, October 15, 2014 12:03:17 Eike Hein wrote: > Hi, > > I just noticed that we currently don't seem to have proxy > settings in Plasma 5, meaning that clicking "Proxy Settings" > in Rekonq or Google Chrome doesn't do anything because they > try to kcmshell something that doesn't exist. > > T

Build failed in Jenkins: solid_master_qt5 #118

2014-10-16 Thread KDE CI System
See Changes: [afiestas] Do not depend on backend job to return the value [afiestas] Adjust Power::States to reality since we are about to implement them [afiestas] Add LogindInhibitionArgument class [afiestas] Rename Power::PowerOff by Po

Re: Proxy Settings KCM

2014-10-16 Thread Andrea Diamantini
Yes, proxy KCM sets behavior of global KIO, so each application using it is involved. The same applies to cache, cookies, netprefs and useragent KCM settings. Basically all the kcm(s) present in konqueror/settings/kio. Regards, 2014-10-15 21:35 GMT+02:00 Albert Astals Cid : > El Dimecres, 15 d'o

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #146

2014-10-16 Thread KDE CI System
See Changes: [rdieter] Fix scrollbar appearing on FolderView [scripty] SVN_SILENT made messages (after extraction) [scripty] SVN_SILENT made messages (after extraction) [lueck] No file editing in preview, change KOffice to Call

Re: Review Request 120605: cleanup overlay icon usage

2014-10-16 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68567 --- Looks good! +1 from my side (Please use the CCBUG hook when y

Review Request 120605: cleanup overlay icon usage

2014-10-16 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- Review request for KDE Frameworks. Bugs: 339193 https://bugs.kde.org/

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread David Faure
> On Oct. 16, 2014, 2:09 p.m., Aleix Pol Gonzalez wrote: > > Can we maybe get a unit test for that? > > Jan Grulich wrote: > I don't think this is necessary, just take a look how it was implemented > before [1]. > > QString pathOrUrl = currentUrl.pathOrUrl(); vs QString path = > c

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/#review68557 --- src/filewidgets/kurlnavigator.cpp

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread Jan Grulich
> On Říj. 16, 2014, 2:09 odp., Aleix Pol Gonzalez wrote: > > Can we maybe get a unit test for that? I don't think this is necessary, just take a look how it was implemented before [1]. QString pathOrUrl = currentUrl.pathOrUrl(); vs QString path = currentUrl.toString(QUrl::PreferLocalFile); an

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/#review68553 --- Can we maybe get a unit test for that? - Aleix Pol Gonzalez

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/#review68552 --- Tested, works fine - Lukáš Tinkl On Říj. 16, 2014, 3:56 odp

Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-16 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-16 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/ --- (Updated Oct. 16, 2014, 7:55 a.m.) Status -- This change has been ma

Re: Review Request 120599: Properly construct QUrl for a temporary file which will be copied as a new file or edited

2014-10-16 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120599/ --- (Updated Oct. 16, 2014, 7:55 a.m.) Status -- This change has been ma

Re: Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/#review68536 --- Ship it! Ship It! - David Faure On Oct. 16, 2014, 7:42 a.m

Re: Review Request 120598: Offer also overwrite option when copying multiple files and there is a conflict

2014-10-16 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120598/ --- (Updated Říj. 16, 2014, 7:42 dop.) Review request for KDE Frameworks and