Re: About the _stable_ jenkins jobs
On Sun, Nov 16, 2014 at 4:40 AM, Albert Astals Cid aa...@kde.org wrote: El Dissabte, 15 de novembre de 2014, a les 09:29:52, Martin Gräßlin va escriure: On Friday 14 November 2014 17:33:18 Albert Astals Cid wrote: Yes, there's no frameworks stable branch, but our current jenkins setup (which hopefully will change in this SoK) is that if we want to have a kalgebra_stable_qt5 build, we need stable_qt5 builds for all it's dependencies, so i'm building all the frameworks with a stable_qt5 build that also tracks master. could you maybe set it to the latest tagged release? Of course it would mean a change every month, but it would mean that the stable jobs don't break just because we have a temporary breakage in master and means lesser builds triggered on the CI. To my close to inexistent setup on how our jenkins is setup, no. Maybe Ben can correct me though. Due to how the gitSetBranch functionality within the CI scripts works Albert is correct. It must always be a branch. Cheers, Albert Cheers Martin Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kwallet_stable_qt5 #3
See http://build.kde.org/job/kwallet_stable_qt5/3/
--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kwallet_stable_qt5/ws/
Running Prebuild steps
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson490773251968709.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 08459cf use correct ki18n_wrap_ui in ki18n based
frameworks/kwallet
Success build forhudson.tasks.Shell@31439a80
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kwallet # timeout=10
Fetching upstream changes from git://anongit.kde.org/kwallet
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/kwallet
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 08459cfa3ceda9a8a68fdead4e9208309bd4d12f
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 08459cfa3ceda9a8a68fdead4e9208309bd4d12f
git rev-list 08459cfa3ceda9a8a68fdead4e9208309bd4d12f # timeout=10
git tag -a -f -m Jenkins Build #3 jenkins-kwallet_stable_qt5-3 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson5929640093509688285.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kwallet - Branch master
== Build Dependencies:
kcodecs - Branch master
kcrash - Branch master
kauth - Branch master
kconfigwidgets - Branch master
kdbusaddons - Branch master
kconfig - Branch master
kwindowsystem - Branch master
kguiaddons - Branch master
karchive - Branch master
cmake - Branch master
qt5 - Branch stable
polkit-qt-1 - Branch master
kwidgetsaddons - Branch master
kitemviews - Branch master
kservice - Branch master
kiconthemes - Branch master
kdoctools - Branch master
phonon - Branch master
knotifications - Branch master
kcoreaddons - Branch master
dogtail - Branch master
ki18n - Branch master
extra-cmake-modules - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/knotifications/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kwallet failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kwallet_stable_qt5 #4
See http://build.kde.org/job/kwallet_stable_qt5/4/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kio_stable_qt5 #2
See http://build.kde.org/job/kio_stable_qt5/2/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdeclarative_stable_qt5 #2
See http://build.kde.org/job/kdeclarative_stable_qt5/2/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdesignerplugin_stable_qt5 #2
See http://build.kde.org/job/kdesignerplugin_stable_qt5/2/
--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kdesignerplugin_stable_qt5/ws/
Running Prebuild steps
[kdesignerplugin_stable_qt5] $ /bin/sh -xe /tmp/hudson8792476956566992040.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at faac68a Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@657a25fd
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kdesignerplugin #
timeout=10
Fetching upstream changes from git://anongit.kde.org/kdesignerplugin
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/kdesignerplugin
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision faac68a285376a8d27827bdcb3e3ef4f7074398b
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f faac68a285376a8d27827bdcb3e3ef4f7074398b
git rev-list faac68a285376a8d27827bdcb3e3ef4f7074398b # timeout=10
git tag -a -f -m Jenkins Build #2 jenkins-kdesignerplugin_stable_qt5-2 #
timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kdesignerplugin_stable_qt5] $ /bin/sh -xe /tmp/hudson285283026899024556.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kdesignerplugin - Branch master
== Build Dependencies:
kdbusaddons - Branch master
ki18n - Branch master
kio - Branch master
attica - Branch master
polkit-qt-1 - Branch master
kcodecs - Branch master
kxmlgui - Branch master
karchive - Branch master
kwallet - Branch master
qt5 - Branch stable
kconfigwidgets - Branch master
phonon - Branch master
kcompletion - Branch master
solid - Branch master
kcrash - Branch master
kglobalaccel - Branch master
kconfig - Branch master
kdewebkit - Branch master
kparts - Branch master
knotifications - Branch master
cmake - Branch master
kdoctools - Branch master
kplotting - Branch master
kjobwidgets - Branch master
kguiaddons - Branch master
kcoreaddons - Branch master
kauth - Branch master
kitemviews - Branch master
kiconthemes - Branch master
ktextwidgets - Branch master
extra-cmake-modules - Branch master
kwindowsystem - Branch master
sonnet - Branch master
kservice - Branch master
kbookmarks - Branch master
kwidgetsaddons - Branch master
dogtail - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kdewebkit/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdesignerplugin failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdewebkit_stable_qt5 #2
See http://build.kde.org/job/kdewebkit_stable_qt5/2/
--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kdewebkit_stable_qt5/ws/
Running Prebuild steps
[kdewebkit_stable_qt5] $ /bin/sh -xe /tmp/hudson6769377387585305916.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 9872800 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@bc0f99c
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kdewebkit # timeout=10
Fetching upstream changes from git://anongit.kde.org/kdewebkit
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/kdewebkit
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 9872800f66ff221614ee04921a4b03dc9198c624
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 9872800f66ff221614ee04921a4b03dc9198c624
git rev-list 9872800f66ff221614ee04921a4b03dc9198c624 # timeout=10
git tag -a -f -m Jenkins Build #2 jenkins-kdewebkit_stable_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kdewebkit_stable_qt5] $ /bin/sh -xe /tmp/hudson4586022141745745628.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kdewebkit - Branch master
== Build Dependencies:
kdbusaddons - Branch master
ki18n - Branch master
kconfig - Branch master
attica - Branch master
polkit-qt-1 - Branch master
kcodecs - Branch master
kxmlgui - Branch master
karchive - Branch master
kwallet - Branch master
qt5 - Branch stable
kconfigwidgets - Branch master
phonon - Branch master
kcompletion - Branch master
solid - Branch master
kglobalaccel - Branch master
kitemviews - Branch master
kio - Branch master
sonnet - Branch master
kparts - Branch master
kdoctools - Branch master
kservice - Branch master
cmake - Branch master
kcrash - Branch master
kjobwidgets - Branch master
kwindowsystem - Branch master
kcoreaddons - Branch master
kauth - Branch master
kiconthemes - Branch master
extra-cmake-modules - Branch master
kguiaddons - Branch master
ktextwidgets - Branch master
knotifications - Branch master
kbookmarks - Branch master
kwidgetsaddons - Branch master
dogtail - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kparts/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdewebkit failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kded_stable_qt5 #2
See http://build.kde.org/job/kded_stable_qt5/2/
--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kded_stable_qt5/ws/
Running Prebuild steps
[kded_stable_qt5] $ /bin/sh -xe /tmp/hudson1155468473990066762.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at 810b56b Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@723c940b
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kded # timeout=10
Fetching upstream changes from git://anongit.kde.org/kded
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/kded
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 810b56b806aa7c30337495c52d601b1782bf07ca
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f 810b56b806aa7c30337495c52d601b1782bf07ca
git rev-list 810b56b806aa7c30337495c52d601b1782bf07ca # timeout=10
git tag -a -f -m Jenkins Build #2 jenkins-kded_stable_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kded_stable_qt5] $ /bin/sh -xe /tmp/hudson5095656481329547666.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kded - Branch master
== Build Dependencies:
dogtail - Branch master
kwindowsystem - Branch master
kcodecs - Branch master
kbookmarks - Branch master
sonnet - Branch master
karchive - Branch master
kdbusaddons - Branch master
kconfigwidgets - Branch master
kconfig - Branch master
cmake - Branch master
polkit-qt-1 - Branch master
solid - Branch master
kxmlgui - Branch master
kcrash - Branch master
kwallet - Branch master
qt5 - Branch stable
kio - Branch master
phonon - Branch master
kglobalaccel - Branch master
kjobwidgets - Branch master
kcompletion - Branch master
kcoreaddons - Branch master
extra-cmake-modules - Branch master
kguiaddons - Branch master
kiconthemes - Branch master
kitemviews - Branch master
kdoctools - Branch master
attica - Branch master
kservice - Branch master
kwidgetsaddons - Branch master
ktextwidgets - Branch master
kinit - Branch master
kauth - Branch master
ki18n - Branch master
knotifications - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kinit/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kded failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdewebkit_stable_qt5 #3
See http://build.kde.org/job/kdewebkit_stable_qt5/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdesignerplugin_stable_qt5 #3
See http://build.kde.org/job/kdesignerplugin_stable_qt5/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #2
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/2/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) -- Started by upstream project plasma-framework_stable_qt5 build number 2 originally caused by: Started by user aacid Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson6662701561192997675.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 0e13fb9..0517bc2 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 0e13fb9 SVN_SILENT made messages (.desktop file) Success build forhudson.tasks.Shell@7ca7bdea git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/plasma-framework.git # timeout=10 Fetching upstream changes from git://anongit.kde.org/plasma-framework.git git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/plasma-framework.git +refs/heads/*:refs/remotes/origin/* Checking out Revision 0517bc2b624afe9ecf9f0f5fe6747270aa034023 (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f 0517bc2b624afe9ecf9f0f5fe6747270aa034023 git rev-list 0e13fb9833ebf443efd6ebc35fca92638413b133 # timeout=10 [LINBUILDER] $ /bin/sh -xe /tmp/hudson4208618770293734652.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: kparts - Branch master kcodecs - Branch master threadweaver - Branch master kbookmarks - Branch master kauth - Branch master kconfigwidgets - Branch master kactivities - Branch master kdbusaddons - Branch master kconfig - Branch master libgit2 - Branch master ktexteditor - Branch master kwindowsystem - Branch master solid - Branch master kcoreaddons - Branch master karchive - Branch master phonon - Branch master sonnet - Branch master kidletime - Branch master qt5 - Branch stable kross - Branch master ktextwidgets - Branch master kitemmodels - Branch master polkit-qt-1 - Branch master kjobwidgets - Branch master kwidgetsaddons - Branch master kglobalaccel - Branch master cmake - Branch master kcmutils - Branch master kservice - Branch master kwallet - Branch master kiconthemes - Branch master kguiaddons - Branch master kcrash - Branch master kjs - Branch master kcompletion - Branch master kitemviews - Branch master knotifications - Branch master kxmlgui - Branch master kdoctools - Branch master dogtail - Branch master kdeclarative - Branch master kdnssd - Branch master ki18n - Branch master extra-cmake-modules - Branch master attica - Branch master kunitconversion - Branch master kio - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/ktexteditor/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception hudson.AbortException: No test report files were found. Configuration error? at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:110) at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:86) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2665) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744)
Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #2
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=NoX11,label=LINBUILDER/2/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) -- Started by upstream project plasma-framework_stable_qt5 build number 2 originally caused by: Started by user aacid Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-framework_stable_qt5/Variation=NoX11,label=LINBUILDER/ws/ Running Prebuild steps [LINBUILDER] $ /bin/sh -xe /tmp/hudson3471766685635559550.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/plasma-framework 0e13fb9..0517bc2 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at 0e13fb9 SVN_SILENT made messages (.desktop file) Success build forhudson.tasks.Shell@7ca7bdea git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/plasma-framework.git # timeout=10 Fetching upstream changes from git://anongit.kde.org/plasma-framework.git git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/plasma-framework.git +refs/heads/*:refs/remotes/origin/* Checking out Revision 0517bc2b624afe9ecf9f0f5fe6747270aa034023 (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f 0517bc2b624afe9ecf9f0f5fe6747270aa034023 git rev-list 0e13fb9833ebf443efd6ebc35fca92638413b133 # timeout=10 [LINBUILDER] $ /bin/sh -xe /tmp/hudson3305716763349985974.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: phonon - Branch master kcodecs - Branch master kcmutils - Branch master kio - Branch master kbookmarks - Branch master kguiaddons - Branch master kauth - Branch master kwindowsystem - Branch master kconfigwidgets - Branch master cmake - Branch master kconfig - Branch master kdbusaddons - Branch master kcompletion - Branch master kross - Branch master ktexteditor - Branch master ktextwidgets - Branch master kdoctools - Branch master solid - Branch master kitemviews - Branch master karchive - Branch master sonnet - Branch master kidletime - Branch master qt5 - Branch stable kactivities - Branch master kitemmodels - Branch master kparts - Branch master kglobalaccel - Branch master polkit-qt-1 - Branch master threadweaver - Branch master kjobwidgets - Branch master extra-cmake-modules - Branch master kcoreaddons - Branch master kservice - Branch master kwallet - Branch master kiconthemes - Branch master libgit2 - Branch master kcrash - Branch master kjs - Branch master kdeclarative - Branch master knotifications - Branch master kxmlgui - Branch master dogtail - Branch master kdnssd - Branch master ki18n - Branch master kwidgetsaddons - Branch master attica - Branch master kunitconversion - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server rsync: change_dir /srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kross/inst failed: No such file or directory (2) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1530) [Receiver=3.0.9] Syncing dependencies from master server for project plasma-framework failed. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Skipping Cobertura coverage report as build was not UNSTABLE or better ... Recording test results ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception hudson.AbortException: No test report files were found. Configuration error? at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:110) at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:86) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2665) at hudson.remoting.UserRequest.perform(UserRequest.java:121) at hudson.remoting.UserRequest.perform(UserRequest.java:49) at hudson.remoting.Request$2.run(Request.java:324) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744)
Jenkins build is back to normal : kded_stable_qt5 #3
See http://build.kde.org/job/kded_stable_qt5/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: krunner_stable_qt5 #1
See http://build.kde.org/job/krunner_stable_qt5/1/
--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/krunner_stable_qt5/ws/
Running Prebuild steps
[krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson5721549244864673913.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a2d6951 SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@3fe27761
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/krunner # timeout=10
Fetching upstream changes from git://anongit.kde.org/krunner
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/krunner
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a2d6951930e0eb5de9e9946733d9ce12be452f75
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a2d6951930e0eb5de9e9946733d9ce12be452f75
First time build. Skipping changelog.
git tag -a -f -m Jenkins Build #1 jenkins-krunner_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson7461405724643435756.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: krunner - Branch master
== Build Dependencies:
kcodecs - Branch master
threadweaver - Branch master
kbookmarks - Branch master
kauth - Branch master
kconfigwidgets - Branch master
ktextwidgets - Branch master
kidletime - Branch master
kconfig - Branch master
dogtail - Branch master
kjs - Branch master
kwindowsystem - Branch master
solid - Branch master
kitemviews - Branch master
karchive - Branch master
kunitconversion - Branch master
kdbusaddons - Branch master
qt5 - Branch stable
kross - Branch master
cmake - Branch master
kcmutils - Branch master
kdoctools - Branch master
sonnet - Branch master
kio - Branch master
polkit-qt-1 - Branch master
kjobwidgets - Branch master
kitemmodels - Branch master
kcoreaddons - Branch master
knotifications - Branch master
plasma-framework - Branch master
libgit2 - Branch master
kiconthemes - Branch master
kwallet - Branch master
kcrash - Branch master
phonon - Branch master
ktexteditor - Branch master
kdeclarative - Branch master
kcompletion - Branch master
kservice - Branch master
kactivities - Branch master
kxmlgui - Branch master
kguiaddons - Branch master
kparts - Branch master
ki18n - Branch master
extra-cmake-modules - Branch master
kdnssd - Branch master
attica - Branch master
kglobalaccel - Branch master
kwidgetsaddons - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kjs/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project krunner failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is unstable: frameworkintegration_stable_qt5 #1
See http://build.kde.org/job/frameworkintegration_stable_qt5/1/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: krunner_stable_qt5 #2
See http://build.kde.org/job/krunner_stable_qt5/2/
--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/krunner_stable_qt5/ws/
Running Prebuild steps
[krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson1900161608573999035.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at a2d6951 SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@3fe27761
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/krunner # timeout=10
Fetching upstream changes from git://anongit.kde.org/krunner
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/krunner
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision a2d6951930e0eb5de9e9946733d9ce12be452f75
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f a2d6951930e0eb5de9e9946733d9ce12be452f75
git rev-list a2d6951930e0eb5de9e9946733d9ce12be452f75 # timeout=10
git tag -a -f -m Jenkins Build #2 jenkins-krunner_stable_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson7278488963900411559.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: krunner - Branch master
== Build Dependencies:
kcodecs - Branch master
kio - Branch master
kbookmarks - Branch master
kauth - Branch master
kconfigwidgets - Branch master
kidletime - Branch master
threadweaver - Branch master
dogtail - Branch master
kjs - Branch master
kwindowsystem - Branch master
solid - Branch master
kguiaddons - Branch master
karchive - Branch master
libgit2 - Branch master
sonnet - Branch master
kross - Branch master
kdbusaddons - Branch master
qt5 - Branch stable
cmake - Branch master
kdeclarative - Branch master
kcompletion - Branch master
kitemmodels - Branch master
kconfig - Branch master
polkit-qt-1 - Branch master
kjobwidgets - Branch master
kwidgetsaddons - Branch master
kcoreaddons - Branch master
ktextwidgets - Branch master
knotifications - Branch master
plasma-framework - Branch master
kdnssd - Branch master
kiconthemes - Branch master
kcmutils - Branch master
kglobalaccel - Branch master
kwallet - Branch master
kdoctools - Branch master
ktexteditor - Branch master
kcrash - Branch master
phonon - Branch master
kservice - Branch master
kxmlgui - Branch master
kitemviews - Branch master
kparts - Branch master
kactivities - Branch master
ki18n - Branch master
extra-cmake-modules - Branch master
attica - Branch master
kunitconversion - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
rsync: change_dir
/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/plasma-framework/inst
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project krunner failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_stable_qt5 » All,LINBUILDER #3
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_stable_qt5 » NoX11,LINBUILDER #3
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=NoX11,label=LINBUILDER/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : krunner_stable_qt5 #3
See http://build.kde.org/job/krunner_stable_qt5/3/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [RFC] [kservice] KPluginMetadata indexing
On Thursday, November 06, 2014 17:06:38 Mark Gaiser wrote: Ah right, i think i missed the I/O reducing goal in your initial post. I haven't checked your draft implementation in detail, but what you might want to do is: - Monitor all plugin folders for changes - If a change in any of the folders is detected: rebuild cache. That should keep the cache updated in a fairly easy way and remove the need to have a tool at all. You could do it more fine grained and only update the cache for the plugin that changed. It will be a bit more tricky to implement. Just an idea, but i hope it helps. I haven't worked on that at all, it's the kind of integration work to do once we nailed down the overall mechanics. I'd actually prefer if we could rely on the index updater run at install time, and assume caches are always correct. If that's realistic, we'll find out (hopefully during discussions rather than by bugreports and broken systems ;)). The problem with the change detection is of course - Which process is the one watching? - What to do when this process is not running during plugin installation? (User could be logged out, for example) I'd like to avoid having to run the updater on login, as that slows down that process. While the updater is quite fast, everything involving I/O at login is not really welcome. As I said, that's something to think about in a second stage, the above is my braindump, personal impression of it. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kservice_stable_qt5 #4
See http://build.kde.org/job/kservice_stable_qt5/4/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [RFC] [kservice] KPluginMetadata indexing
On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote:
Hi all, especially Alex and David,
tl;dr:
I've done a proof-of-concept implementation of a metadata index for
KPluginTrader::query(), the main entry point when it comes to finding binary
plugins. This index considerably speeds up all current use cases, but comes
at the cost of having to maintain the index. Code is in
kservice[sebas/kpluginindex], speeds up plugin quering a few times.
snip
Hey Sebas,
I just took a look at your code. What comes to my mind you'll find below.
a) you added a return; in the middle of a pluginlocatortest - why? no
comment either. If you expect failures, use QEXPECT_FAIL. I've added this also
to PluginTest::findPackageStructure now.
b) adding code in a merge commit is a very bad idea. Never do that. (see
3c9f33251708c6d935ed35fbfb6130c4389e69a7). One reason is that merge commits
are special and often omitted when looking at code. See e.g. git log -u
which won't show the code you added in the merge...
c) The code seems to contain tons of debug code, commented out code etc. pp..
Will you please clean that up before you merge this in? I.e. squash it locally
with the cleanup commits to not uglify the git history.
d) Overall I find it extremely hard to review the code since there is so much
unrelated stuff going on. Now that Alexander's work is in master (it is, no?)
could you maybe cleanup your branch and do a force-push rebased on top of
current master? If you do that together with c) I could actually see whats
supposed to be going on without being confused by tons of new code that's only
there for debug purposes.
e) // Less than two plugin means it's not worth indexing
I'd argue this code path can be removed. In a normal session there will always
be more than two plugins.
f) I urge you (and everybody else) to rethink some code structures around
conditionals. Most of the time one can greatly simplify functions (imo) by the
following (inspired by KPluginIndexer::removeIndex):
bool ok = true;
if (foo) {
if (bar) {
if (!asdf) {
ok = false;
qWarning()
} else {
// success
}
} else {
qWarning();
ok = false;
}
}
return ok;
rewrite this as:
if (!foo) {
return true;
}
if (!bar) {
return false;
}
if (!asdf) {
return false;
}
// success!
g) I still don't know how to benchmark your code.
Bye
--
Milian Wolff
m...@milianw.de
http://milianw.de
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()
On Nov. 14, 2014, 2:24 p.m., David Faure wrote:
if you want, but the sentence sounds like KRun only reads from that config
file, while it also writes into it. This is why I consider it an
implementation detail... the app doesnt need to care about it, right?
the app doesnt need to care about it, right?
In this case it does, the app might need to have an option to re-enable the
dialog(once Do not ask again has been set). If the name of the configuration
file is not mentioned in the documentation, the developer will have to go
through the source code to find it.
- Arjun
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120926/#review70361
---
On Nov. 1, 2014, 4:01 p.m., Arjun AK wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120926/
---
(Updated Nov. 1, 2014, 4:01 p.m.)
Review request for KDE Frameworks and David Faure.
Repository: kio
Description
---
Since `setShowScriptExecutionPrompt()` is used to specify whether a prompt
should be shown or not, we don't neither need to check it again nor do we
need to call `setRunExecutable()` inside KIO. The caller is anyway forced to
do something like:
if (value == alwaysAsk) {
run-setShowScriptExecutionPrompt(true);
} else {
run-setRunExecutables(value == execute);
}
Diffs
-
src/widgets/krun.h cd5bcaa
Diff: https://git.reviewboard.kde.org/r/120926/diff/
Testing
---
Thanks,
Arjun AK
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121099: Fix kautosave doesn't work with more than 1 file per application.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121099/#review70440 --- I am still very unsure about adding all this complexity with two lock files, some of it in order to add a second feature to KAutoSaveFile (backups). That doesn't really make this patch just a bugfix The docu patch mentions two usage scenarios, but the second one is about backups, not autosave. The backup feature belongs to another class (see KBackup). I would much rather see a patch for bugfixing the established use case for KAutoSaveFile (autosaving in order to recover unsaved data after a crash), and just that, no let's add another feature while at it. I might be missing something though, please enlighten me in that case. autotests/kautosavefiletest.cpp https://git.reviewboard.kde.org/r/121099/#comment49256 two spaces before autotests/kautosavefiletest.cpp https://git.reviewboard.kde.org/r/121099/#comment49257 two spaces after comma autotests/kautosavefiletest.cpp https://git.reviewboard.kde.org/r/121099/#comment49258 same - and there's another dozen that follow ;) autotests/kautosavefiletest.cpp https://git.reviewboard.kde.org/r/121099/#comment49260 this instance isn't deleted anywhere, it seems autotests/kautosavefiletest.cpp https://git.reviewboard.kde.org/r/121099/#comment49259 Better create on stack, for auto cleanup. src/lib/io/kautosavefile.h https://git.reviewboard.kde.org/r/121099/#comment49262 two spaces after removed src/lib/io/kautosavefile.h https://git.reviewboard.kde.org/r/121099/#comment49261 typo: destrctor - destructor ; comma should be at end of last line src/lib/io/kautosavefile.h https://git.reviewboard.kde.org/r/121099/#comment49263 This is for the first usage scenario of the previous paragraph, right? It's a bit confusing right now, to detail steps without associating them with the corresponding usage scenario. Or does this work for both? I don't really understand the second use case. - David Faure On Nov. 11, 2014, 1:16 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121099/ --- (Updated Nov. 11, 2014, 1:16 a.m.) Review request for KDE Frameworks and David Faure. Repository: kcoreaddons Description --- kautosave doesn't work when any app tries to use a second filename, because it doesn't filter on filename. The unit tests can be droppped into master to show the problem, if you remove the include on line 21. This patch: 1. Adds unit tests to test more behavior mentioned in the header. 2. Fixes kautosave working with multple files per application. 3. Fixes filenaming brittleness, which would cause kautosave to randomly fail when the last 3 randomly generated characters in the filename matched any 3 consequtive chracters in the managed filename. Original patch by Andreas Xavier (https://git.reviewboard.kde.org/r/119530) Items from original review have been fixed. Diffs - src/lib/io/kautosavefile_p.cpp PRE-CREATION autotests/kautosavefiletest.h cf70f4c6a4e1f093c431eff6ff25e6f510e84a53 autotests/kautosavefiletest.cpp ec0309e5fda95e01bbed31bd2fe91f9b7a48bec0 src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a src/lib/io/kautosavefile.h 05cc3aedc248665c8727ade3b86b524275c013ca src/lib/io/kautosavefile.cpp 13a13d7cfb26194be3edf7cbdcd1d39309b79465 src/lib/io/kautosavefile_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121099/diff/ Testing --- It builds and the test passes. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched. IMO, this topic requires more consideration. Some of the features that we could use if we raise msvc version to 11.0 and gcc to 4.6 or 4.7: - range-based for loops - variadic templates - override and final (gcc 4.7) - delegating constructors (gcc 4.7) - initializer lists - proper implementation of lambdas and move semantics Cheerio, Ivan -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [RFC] [kservice] KPluginMetadata indexing
Hi Sebas, Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a given plugin directory into a QJsonArray, and dumps that in Qt's json binary format to disk I didn't have time to look into details, but I have one question about the principle: Is the tool going to be run at plugin installation time? That's the best solution, IMHO, similar to update-mime-database and the like. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120902/ --- (Updated Nov. 16, 2014, 6:40 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Bugs: 339863 https://bugs.kde.org/show_bug.cgi?id=339863 Repository: kwidgetsaddons Description --- The old code converted the yellow star icon to grayscale for the unrated part. With icon themes that have no color, this means the rating cannot be read, because all stars look identical. This code adds support for a rating-unrated icon that theme creators can use for the unrated part. If the icon theme does not support this icon, it falls back to desaturating. Diffs - src/kratingpainter.cpp 8e8a6a3 Diff: https://git.reviewboard.kde.org/r/120902/diff/ Testing --- I couldn't actually test with breeze theme (Qt issue?), but I locally added a dedicated rating-unrated.png file to oxygen and tested both cases (present and not). Thanks, Christoph Feck ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121143: add translationDomain for katepartui.rc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121143/ --- Review request for KDE Frameworks. Repository: ktexteditor Description --- Translation messages in src/data/katepartui.rc are extracted into the catalog ktexteditor5 Without the definition of translationDomain in katepartui the queries for the translation of these strings in katepartui.rc are performed with the application translationDomain (e.g. kate or kwrite) and the strings are untranslated in the GUI. With this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ the queries for translation of these strings in katepartui.rc are performed with the translationDomain ktexteditor5 and e.g. the menu items in kate/kwrite are fully translated now. Diffs - src/data/katepartui.rc 6673b64 Diff: https://git.reviewboard.kde.org/r/121143/diff/ Testing --- Fully translated GUI in kate/kwrite Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121143: add translationDomain for katepartui.rc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121143/#review70477 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Nov. 16, 2014, 8:27 p.m., Burkhard Lück wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121143/ --- (Updated Nov. 16, 2014, 8:27 p.m.) Review request for KDE Frameworks. Repository: ktexteditor Description --- Translation messages in src/data/katepartui.rc are extracted into the catalog ktexteditor5 Without the definition of translationDomain in katepartui the queries for the translation of these strings in katepartui.rc are performed with the application translationDomain (e.g. kate or kwrite) and the strings are untranslated in the GUI. With this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ the queries for translation of these strings in katepartui.rc are performed with the translationDomain ktexteditor5 and e.g. the menu items in kate/kwrite are fully translated now. Diffs - src/data/katepartui.rc 6673b64 Diff: https://git.reviewboard.kde.org/r/121143/diff/ Testing --- Fully translated GUI in kate/kwrite Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121090: Move kio-mtp to kio-extras
On Thursday 13 November 2014 17:55:15 David Faure wrote: On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Aleix Pol Gonzalez wrote: Well, there's important kio's as well in kio-extras. Question is, is it useful outside the workspace? Would a cross-platform application use it? It seems to me they would, I can see amarok requiring it even on windows or gnome. Jan Grulich wrote: To me it makes more sense to have it in kio-extras with the rest of kioslaves. plasma-workspace isn't about importance. It's about what constitutes the pure desktop (a place where to show windows from applications). Actual functionality that would also work in other desktops and OSes (like dolphin, like kioslaves, and so on) belongs to Applications. kio-extras being under kde/workspace right now is really a bug, that I've been pleading against since day one. Please please move it out of there, it's nonsense for it to be there. kioslaves work in other environments. You are right. signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70478 --- autotests/CMakeLists.txt https://git.reviewboard.kde.org/r/121047/#comment49287 The more robust (and new in Qt5) way of doing this is QFINDTESTDATA in the test code. autotests/base64benchmark.cpp https://git.reviewboard.kde.org/r/121047/#comment49288 should be static, it doesn't use any members autotests/base64benchmark.cpp https://git.reviewboard.kde.org/r/121047/#comment49289 could use reserve(size) for speed autotests/rfc2047test.cpp https://git.reviewboard.kde.org/r/121047/#comment49290 src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49293 missing space after first comma. (I would remove the second comma) src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49294 missing space after first comma. (I would remove the second comma) src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49295 The Qt way to do this is to take a pointer, rather than a non-const ref. It makes things clearer when reading the calling code. src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49292 @since 5.5, in all new methods src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49296 The Qt way would be to use an enum rather than a bool, again to make the calling code more readable. src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49297 I doubt this whole comment will be picked up by doxygen, it doesn't seem to document anything in particular... Also, this particular line reads very strangely... src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49298 Any reason to use protected instead of private here? And then, if private, the two static things should be file-static instead (no need to pollute the header) src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49299 typo, Constructs src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49300 this withCRLF everywhere is definitely worth an enum src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49301 please port the documentation to the new namespace. Grep for KMime everywhere... src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49302 kFatal is deprecated src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49303 move to cpp src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49304 That is brief indeed :-) (merge with next line) src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49305 move all 3 members to a d pointer, if this class should indeed be public. src/kcodecs.cpp https://git.reviewboard.kde.org/r/121047/#comment49307 These qDebugs should be commented out, or converted to qCDebug with a default to off. No point in spamming users for data conversion errors, Qt definitely doesn't do that. src/kcodecs.cpp https://git.reviewboard.kde.org/r/121047/#comment49308 Always use QMutexLocker instead. src/kcodecs.cpp https://git.reviewboard.kde.org/r/121047/#comment49309 Yes, it does. Use value() instead. src/kcodecs.cpp https://git.reviewboard.kde.org/r/121047/#comment49310 This could be a qWarning (programmer error). src/kcodecs.cpp https://git.reviewboard.kde.org/r/121047/#comment49311 QScopedPointer would remove the need for all the delete dec statement in all 3 return paths. src/kcodecsbase64.h https://git.reviewboard.kde.org/r/121047/#comment49314 Does this class actually need to be exported? Isn't it enough to let apps find codecs by name, just like in Qt? This removes the need for exporting all the codec implementation classes. src/kcodecsbase64.h https://git.reviewboard.kde.org/r/121047/#comment49313 What a weird codec name?? - David Faure On Nov. 14, 2014, 12:41 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 14, 2014, 12:41 p.m.) Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64,
Re: Review Request 121143: add translationDomain for katepartui.rc
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121143/ --- (Updated Nov. 16, 2014, 9:13 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: ktexteditor Description --- Translation messages in src/data/katepartui.rc are extracted into the catalog ktexteditor5 Without the definition of translationDomain in katepartui the queries for the translation of these strings in katepartui.rc are performed with the application translationDomain (e.g. kate or kwrite) and the strings are untranslated in the GUI. With this patch and the patch from https://git.reviewboard.kde.org/r/121141/diff/ the queries for translation of these strings in katepartui.rc are performed with the translationDomain ktexteditor5 and e.g. the menu items in kate/kwrite are fully translated now. Diffs - src/data/katepartui.rc 6673b64 Diff: https://git.reviewboard.kde.org/r/121143/diff/ Testing --- Fully translated GUI in kate/kwrite Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #723
See http://build.kde.org/job/ktexteditor_master_qt5/723/changes Changes: [lueck] add translationDomain for katepartui.rc -- [...truncated 946 lines...] Automatic moc for target vimode_modes [ 20%] Automatic moc for target vimode_view Scanning dependencies of target katehighlightingindexer [ 20%] Building CXX object src/syntax/data/CMakeFiles/katehighlightingindexer.dir/katehighlightingindexer.cpp.o Generating moc_script_test_base.cpp Generating moc_scripting_test.cpp Generating moc_testutils.cpp Generating wordcompletiontest.moc http://build.kde.org/job/ktexteditor_master_qt5/ws/autotests/src/wordcompletiontest.cpp:0: Note: No relevant classes found. No output generated. [ 20%] Built target scripting_test_automoc [ 21%] Building CXX object src/syntax/data/CMakeFiles/katehighlightingindexer.dir/katehighlightingindexer_automoc.cpp.o Generating moc_wordcompletiontest.cpp [ 21%] Built target wordcompletiontest_automoc Generating moc_codecompletiontestmodel.cpp Generating moc_codecompletiontestmodels.cpp Generating moc_completion_test.cpp [ 21%] Built target completion_test_automoc Generating moc_base.cpp Generating moc_modes.cpp [ 21%] Built target vimode_modes_automoc Generating moc_base.cpp Generating moc_completion.cpp Generating moc_fakecodecompletiontestmodel.cpp [ 21%] Generating moc_base.cpp Generating moc_view.cpp Built target vimode_completion_automoc Generating moc_base.cpp Generating moc_fakecodecompletiontestmodel.cpp Generating moc_keys.cpp [ 21%] Built target vimode_view_automoc [ 21%] Built target vimode_keys_automoc Linking CXX executable katehighlightingindexer [ 21%] Built target katehighlightingindexer Scanning dependencies of target GenerateIndexFile [ 21%] Generating index.json Generating kateprinter.moc Generating moc_katetextbuffer.cpp Generating moc_katetextfolding.cpp Generating moc_expandingdelegate.cpp Generating moc_expandingwidgetmodel.cpp Generating moc_kateargumenthintmodel.cpp Generating moc_kateargumenthinttree.cpp Generating moc_katecompletionconfig.cpp Generating moc_katecompletionmodel.cpp Generating moc_katecompletiontree.cpp Generating moc_katecompletionwidget.cpp Generating moc_katekeywordcompletion.cpp Generating moc_katewordcompletion.cpp Generating moc_kateconfigpage.cpp Generating moc_katedialogs.cpp Generating moc_katebuffer.cpp Generating moc_katedocument.cpp Generating moc_annotationinterface.cpp Generating moc_application.cpp Generating moc_codecompletionmodel.cpp Generating moc_command.cpp Generating moc_configpage.cpp Generating moc_document.cpp Generating moc_editor.cpp Generating moc_mainwindow.cpp Generating moc_message.cpp Generating moc_plugin.cpp Generating moc_view.cpp Generating moc_katemodeconfigpage.cpp Generating moc_katemodemenu.cpp Generating moc_printconfigwidgets.cpp Generating moc_katelayoutcache.cpp Generating moc_katecolortreewidget.cpp Generating moc_kateschema.cpp Generating moc_kateschemaconfig.cpp Generating moc_katestyletreewidget.cpp Generating moc_katescriptaction.cpp Generating moc_katescriptdocument.cpp Generating moc_katescriptmanager.cpp Generating moc_katescriptview.cpp Generating moc_katesearchbar.cpp Generating moc_ontheflycheck.cpp Generating moc_spellcheck.cpp Generating moc_spellcheckbar.cpp Generating moc_spellcheckdialog.cpp Generating moc_spellingmenu.cpp Generating moc_kateswapdiffcreator.cpp Generating moc_kateswapfile.cpp Generating moc_katehighlightmenu.cpp Generating moc_katesyntaxmanager.cpp Generating moc_kateundomanager.cpp Generating moc_kateautoindent.cpp Generating moc_katebookmarks.cpp Generating moc_kateglobal.cpp Generating moc_katetemplatehandler.cpp Generating moc_katehelpbutton.cpp Generating moc_variableeditor.cpp Generating moc_variablelineedit.cpp Generating moc_variablelistview.cpp Generating moc_kateanimation.cpp Generating moc_katefadeeffect.cpp Generating moc_katemessagewidget.cpp Generating moc_katestatusbar.cpp Generating moc_katetextanimation.cpp Generating moc_kateview.cpp Generating moc_kateviewhelpers.cpp Generating moc_kateviewinternal.cpp Generating moc_appcommands.cpp Generating moc_configtab.cpp Generating moc_emulatedcommandbar.cpp Generating moc_keymapper.cpp Generating moc_marks.cpp Generating moc_insertvimode.cpp Generating moc_modebase.cpp Generating moc_normalvimode.cpp Generating moc_visualvimode.cpp [ 21%] Built target KF5TextEditor_automoc [ 21%] [ 21%] [ 21%] [ 22%] [ 22%] [ 23%] [ 23%] Generating ui_configwidget.h Generating ui_textareaappearanceconfigwidget.h Generating ui_commandmenuconfigwidget.h Generating ui_commandmenueditwidget.h Generating ui_bordersappearanceconfigwidget.h Generating ui_navigationconfigwidget.h Generating ui_completionconfigtab.h [ 23%] Generating ui_editconfigwidget.h [ 24%] [ 24%] [ 25%] [ 25%] [ 25%] [ 25%] [ 26%] Generating ui_filetypeconfigwidget.h Generating ui_indentationconfigwidget.h Generating ui_opensaveconfigwidget.h [ 26%] Generating ui_completionconfigwidget.h Generating
Re: [kde-frameworks-devel] Re: Review Request 121090: Move kio-mtp to kio-extras
On Sun, Nov 16, 2014 at 09:38:38PM +0100, Àlex Fiestas wrote: kio-extras being under kde/workspace right now is really a bug, that I've been pleading against since day one. Please please move it out of there, it's nonsense for it to be there. kioslaves work in other environments. You are right. Too late to move it for KDE Applications 14.12 but let's try to do this on the next release. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several *seconds* later. This way, i think it's not using the incubator at all, and i don't think it's really acceptable. In QML itself, QQuickView does internally use an incubator as well, even tough in a slightly different manner it seems. Well, since I started developing in Qt, I've been told that using nested event loops is bad parallelization. A good way to fix the WallpaperInterface issue (I understand it's an example, but still applies) is that instead of calling completeInitialization() (wallpaperinterface.cpp:147) we should be connect to a signal that notifies us about the background readiness (i.e. statusChanged) and then react to the initialization by connecting the object into the graphical elements, but forcing the end of the initialization is, of course, not parallelizable. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 --- On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 13, 2014, 6:24 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- We had a while loop which processed all application events whilst we were in the middle of creating objects. This leads to weird bugs, and workarounds in ShellCorona. Qt's methods forceCompletion does not seem to have the same problems and works just as well. Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched. IMO, this topic requires more consideration. Agreed, and thanks for a tentative improvement at the features white list to that effect. Some of the features that we could use if we raise msvc version to 11.0 and gcc to 4.6 or 4.7: - range-based for loops Agreed. - variadic templates Are you sure about that? IME variadic templates unfortunately don't work with that one. They are listed as unsupported here: http://msdn.microsoft.com/en-us/library/vstudio/hh567368%28v=vs.110%29.aspx - override and final (gcc 4.7) Agreed. - delegating constructors (gcc 4.7) Unsupported on VS2012. - initializer lists Unsupported on VS2012. - proper implementation of lambdas and move semantics Yep, those two were already in the white list, we kind of cut a corner there. Looks like the white list changes will be shorter than what you propose unfortunately. Here is a few more for consideration: * Strongly typed enums * extern templates * trailing return types * decltype * static_assert Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
