Re: Supporting MSVC2010 in ktexteditor framework
On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched. IMO, this topic requires more consideration. Agreed, and thanks for a tentative improvement at the features white list to that effect. Some of the features that we could use if we raise msvc version to 11.0 and gcc to 4.6 or 4.7: - range-based for loops Agreed. - variadic templates Are you sure about that? IME variadic templates unfortunately don't work Yeah, it looks like I've been looking at the CTP from November 2012 - for VS11 [1]. It would be awesome if somebody who has VS11 actually investigated this. Namely, the 11.0 proper should support variadics up to some number of arguments (yes, sounds really daft and hackish). If true, it would be able to cover more than a few use-cases I reckon. with that one. They are listed as unsupported here: http://msdn.microsoft.com/en-us/library/vstudio/hh567368%28v=vs.110%29.aspx - override and final (gcc 4.7) Agreed. - delegating constructors (gcc 4.7) Unsupported on VS2012. - initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the initializer lists should also be tested - maybe they also work if the number of arguments is less than ...) Here is a few more for consideration: * Strongly typed enums * extern templates * trailing return types * decltype * static_assert Yes, forgot those. +1 Cheerio, Ivan [1] https://wiki.apache.org/stdcxx/C++0xCompilerSupport KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121098: Restore filedialog functionality for modal dialogs.
On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote:
src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303
https://git.reviewboard.kde.org/r/121098/diff/1/?file=327582#file327582line301
Looking at QDialog docs, it says
modal : bool
This property holds whether show() should pop up the dialog as modal or
modeless.
So as the modal is being set here, shouldn't the if (windowModality ==
Qt::NonModal) { just be removed instead and always call show()?
Jeremy Whiting wrote:
Yep, I've tried just removing the if, that makes it appear when the
static QFileDialog methods are called, but you can't interact with it.
Clicking anywhere in the dialog itself does nothing. As reported here:
https://bugs.kde.org/show_bug.cgi?id=334963
Martin Klapetek wrote:
The main issue I see here is that show() is always expected to not block;
if the QML dialogs wanted to use the blocking version, it would internally
just call exec() rather than show(). So putting blocking exec() into show()
is imho not right.
Have you tried investigating why the dialog cannot be interacted with? I
can have a look if you want
Jeremy Whiting wrote:
I think removing the if is the right solution, but I've no idea where to
start looking to figure out why it's not interactive. If you've got some
ideas I can do the digging, otherwise you can look into it. I'm fine either
way, just want to get the underlying issue solved.
Ok, I'll have a look and post back.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121098/#review70384
---
On Nov. 10, 2014, 7:17 p.m., Jeremy Whiting wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121098/
---
(Updated Nov. 10, 2014, 7:17 p.m.)
Review request for KDE Frameworks and Eike Hein.
Repository: frameworkintegration
Description
---
Before David's astyle commit, the show method used to call m_dialog-exec
if the window flags weren't nonmodal (i.e. modal dialogs). This got removed
somehow.
BUG:334963
Diffs
-
src/platformtheme/kdeplatformfiledialoghelper.cpp
44eca192946f0da2b357b33e93a57ef0de05135b
Diff: https://git.reviewboard.kde.org/r/121098/diff/
Testing
---
fifteen puzzle config with patch from
https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you
choose a file.
Thanks,
Jeremy Whiting
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
Yeah, it looks like I've been looking at the CTP from November 2012 - for VS11 [1]. It would be awesome if somebody who has VS11 actually investigated this. Namely, the 11.0 proper should support variadics up to some number of arguments (yes, sounds really daft and hackish). If true, it would be able to cover more than a few use-cases I reckon. I managed to ping someone to test this - it seems that the 'we support variadic templates up to a predefined number of arguments' means that they have a lot of fun macros that make their STL implementation behave like there are variadics. They do not support typename... syntax. Damn! -- Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
El 17/11/2014, a las 06:03, Ivan Čukić ivan.cu...@kde.org escribió: On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: - initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the initializer lists should also be tested - maybe they also work if the number of arguments is less than ...) Apparently, MSVC2013 introduces initializer lists, but has such a serious bug (calling destructors twice in certain cases) that Qt pretends it doesn't support them and doesn't enable them in eg. containers, unless you have MSVC2013 Update 2 which fixes the bug. I'd expect the 2012 CTP to be similarly unusable wrt initializer lists. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Problem with kdeinit and StartupInfo
On Sat, Oct 4, 2014 at 1:47 PM, Alex Merry alex.me...@kde.org wrote: On 2014-10-04 10:08, David Faure wrote: On Friday 03 October 2014 12:15:09 Alex Merry wrote: Note that KDBusService has a known limitation where it just doesn't work with startup notifications in unique mode - the necessary information is never passed to the main application by the secondary instance. I lost track a bit there -- do you know what's missing for this to happen? It's been so long since I looked at it, I can't really remember. I think the conclusion was that attempting to support the existing startup notification scheme was incredibly difficult/impossible due to a combination of how the X11 Qt platform plugin handles it and the KDBusAddons non-gui requirement. So the idea was to try to forge ahead with a D-Bus based alternative (which would also work on Wayland), but that stalled. I have an email from Ryan Lortie from a year ago about it, and about GNOME's implementation plans, but it's taken a back seat to other things. I may get round to revisiting it at some point, but if someone is keen to take it on, I can forward the email (which I think was also CCd to some XDG list or other). Is there some intermediate solution/workaround that could be used? This is still an issue which makes dolphin5 + kate5 an unusable combo :( Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
El domingo, 16 de noviembre de 2014, Ivan Čukić ivan.cu...@kde.org escribió: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched. The issue in question didn't yet get patched actually. I submitted proposed patches on separate git branches, and reviewing them is part of this discussion: if anyone thinks the patches I committed to the msvc2010 branch of the ktexteditor repo aren't acceptable, that's another argument for switching to 2012. Should I submit to reviewboard? -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
- initializer lists
Unsupported on VS2012.
Again, seems to be that CTP thingie, damn. (though, again, the initializer
lists should also be tested - maybe they also work if the number of arguments
is less than ...)
I've had problems with them even on VS2013, like return QHashint,
QByteArray({ {FooRole, foo} });
For QAbstractListModel::roleNames() which worked fine in recent clang and gcc.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several *seconds* later. This way, i think it's not using the incubator at all, and i don't think it's really acceptable. In QML itself, QQuickView does internally use an incubator as well, even tough in a slightly different manner it seems. Aleix Pol Gonzalez wrote: Well, since I started developing in Qt, I've been told that using nested event loops is bad parallelization. A good way to fix the WallpaperInterface issue (I understand it's an example, but still applies) is that instead of calling completeInitialization() (wallpaperinterface.cpp:147) we should be connect to a signal that notifies us about the background readiness (i.e. statusChanged) and then react to the initialization by connecting the object into the graphical elements, but forcing the end of the initialization is, of course, not parallelizable. eh, they shouldn't put it in the documentation as an example how to di ti ;) so ok, let's try to go for it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70364 --- On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 13, 2014, 6:24 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- We had a while loop which processed all application events whilst we were in the middle of creating objects. This leads to weird bugs, and workarounds in ShellCorona. Qt's methods forceCompletion does not seem to have the same problems and works just as well. Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [RFC] [kservice] KPluginMetadata indexing
Hi Milian,
Thanks for looking at my patches. Since the branch, as you noticed, is quite
contaminated with unrelated changes, merging in and out stuff, I'll push these
changes to a cleaned branch, and will address the issues you pointed out. I'll
post a new RR then.
On Sunday, November 16, 2014 14:13:39 Milian Wolff wrote:
On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote:
Hi all, especially Alex and David,
tl;dr:
I've done a proof-of-concept implementation of a metadata index for
KPluginTrader::query(), the main entry point when it comes to finding
binary plugins. This index considerably speeds up all current use cases,
but comes at the cost of having to maintain the index. Code is in
kservice[sebas/kpluginindex], speeds up plugin quering a few times.
snip
Hey Sebas,
I just took a look at your code. What comes to my mind you'll find below.
a) you added a return; in the middle of a pluginlocatortest - why? no
comment either. If you expect failures, use QEXPECT_FAIL. I've added this
also to PluginTest::findPackageStructure now.
b) adding code in a merge commit is a very bad idea. Never do that. (see
3c9f33251708c6d935ed35fbfb6130c4389e69a7). One reason is that merge commits
are special and often omitted when looking at code. See e.g. git log -u
which won't show the code you added in the merge...
c) The code seems to contain tons of debug code, commented out code etc.
pp.. Will you please clean that up before you merge this in? I.e. squash it
locally with the cleanup commits to not uglify the git history.
d) Overall I find it extremely hard to review the code since there is so
much unrelated stuff going on. Now that Alexander's work is in master (it
is, no?) could you maybe cleanup your branch and do a force-push rebased on
top of current master? If you do that together with c) I could actually see
whats supposed to be going on without being confused by tons of new code
that's only there for debug purposes.
e) // Less than two plugin means it's not worth indexing
I'd argue this code path can be removed. In a normal session there will
always be more than two plugins.
f) I urge you (and everybody else) to rethink some code structures around
conditionals. Most of the time one can greatly simplify functions (imo) by
the following (inspired by KPluginIndexer::removeIndex):
bool ok = true;
if (foo) {
if (bar) {
if (!asdf) {
ok = false;
qWarning()
} else {
// success
}
} else {
qWarning();
ok = false;
}
}
return ok;
rewrite this as:
if (!foo) {
return true;
}
if (!bar) {
return false;
}
if (!asdf) {
return false;
}
// success!
g) I still don't know how to benchmark your code.
Bye
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [RFC] [kservice] KPluginMetadata indexing
Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a given plugin directory into a QJsonArray, and dumps that in Qt's json binary format to disk I didn't have time to look into details, but I have one question about the principle: Is the tool going to be run at plugin installation time? That's the best solution, IMHO, similar to update-mime-database and the like. Yes, that's the plan. I'm solliciting feedback to the approach of doing it this way, and using QJson for it in this review, integrating this into the installation process would be one of the next steps. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks, Christoph Feck and David Faure. Repository: kwidgetsaddons Description --- This new widget adds a button on splitter to collapse it. Diffs - autotests/ksplittercollapserbuttontest.cpp PRE-CREATION autotests/ksplittercollapserbuttontest.h PRE-CREATION autotests/CMakeLists.txt 26c479f src/CMakeLists.txt 059d5d9 src/ksplittercollapserbutton.h PRE-CREATION src/ksplittercollapserbutton.cpp PRE-CREATION tests/CMakeLists.txt 5086ac0 tests/ksplittercollapserbuttongui_test.h PRE-CREATION tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side
On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font size, which might be different depending on which screen the widget is used. It's just a button with a icon not text. So why is it necessary ? On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 277 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line277 Please also expandTo the app's globalStrut for any clickable region, especially since you are making it smaller than the scroll bar size. You want that I increase size ? I don't understand what you want that I do. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70515 --- On nov. 17, 2014, 3:39 après-midi, Laurent Montel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 3:39 après-midi) Review request for KDE Frameworks, Christoph Feck and David Faure. Repository: kwidgetsaddons Description --- This new widget adds a button on splitter to collapse it. Diffs - autotests/ksplittercollapserbuttontest.cpp PRE-CREATION autotests/ksplittercollapserbuttontest.h PRE-CREATION autotests/CMakeLists.txt 26c479f src/CMakeLists.txt 059d5d9 src/ksplittercollapserbutton.h PRE-CREATION src/ksplittercollapserbutton.cpp PRE-CREATION tests/CMakeLists.txt 5086ac0 tests/ksplittercollapserbuttongui_test.h PRE-CREATION tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side
On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font size, which might be different depending on which screen the widget is used. Laurent Montel wrote: It's just a button with a icon not text. So why is it necessary ? With different DPI displays, we cannot hardcode any sizes, but need to adapt to values the system provides. Using pixelMetric() is a good way to get such a size, but it needs some information for which widget the sizes should be queried. So pass a QStyleOption (initialized from that widget) and optionally, also the widget itself to pixelMetric(). On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 277 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line277 Please also expandTo the app's globalStrut for any clickable region, especially since you are making it smaller than the scroll bar size. Laurent Montel wrote: You want that I increase size ? I don't understand what you want that I do. http://doc-snapshot.qt-project.org/qt5-dev/qapplication.html#globalStrut-prop - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70515 --- On Nov. 17, 2014, 3:39 p.m., Laurent Montel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks, Christoph Feck and David Faure. Repository: kwidgetsaddons Description --- This new widget adds a button on splitter to collapse it. Diffs - autotests/ksplittercollapserbuttontest.cpp PRE-CREATION autotests/ksplittercollapserbuttontest.h PRE-CREATION autotests/CMakeLists.txt 26c479f src/CMakeLists.txt 059d5d9 src/ksplittercollapserbutton.h PRE-CREATION src/ksplittercollapserbutton.cpp PRE-CREATION tests/CMakeLists.txt 5086ac0 tests/ksplittercollapserbuttongui_test.h PRE-CREATION tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121098: Restore filedialog functionality for modal dialogs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- (Updated Nov. 17, 2014, 9:39 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Eike Hein. Repository: frameworkintegration Description --- Before David's astyle commit, the show method used to call m_dialog-exec if the window flags weren't nonmodal (i.e. modal dialogs). This got removed somehow. BUG:334963 Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca192946f0da2b357b33e93a57ef0de05135b Diff: https://git.reviewboard.kde.org/r/121098/diff/ Testing --- fifteen puzzle config with patch from https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you choose a file. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 4:48 après-midi) Review request for KDE Frameworks, Christoph Feck and David Faure. Changes --- Adapt code with Christoph comment. Repository: kwidgetsaddons Description --- This new widget adds a button on splitter to collapse it. Diffs (updated) - src/ksplittercollapserbutton.h PRE-CREATION src/ksplittercollapserbutton.cpp PRE-CREATION tests/CMakeLists.txt 5086ac0 tests/ksplittercollapserbuttongui_test.h PRE-CREATION tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION autotests/CMakeLists.txt 26c479f autotests/ksplittercollapserbuttontest.h PRE-CREATION autotests/ksplittercollapserbuttontest.cpp PRE-CREATION src/CMakeLists.txt 059d5d9 Diff: https://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121153: Restore filedialog show() functionality for modal dialogs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- Review request for KDE Frameworks. Repository: frameworkintegration Description --- Based on https://git.reviewboard.kde.org/r/121098/ and on the GTK2 platform theme, which does the modal show() like this. Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca19 Diff: https://git.reviewboard.kde.org/r/121153/diff/ Testing --- All kinds of file dialogs from tests/qfiledialogtest work as expected Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121160: Add libgit2 compile-time check for threads support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add libgit2 compile-time check for threads support Diffs - CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 src/test_libgit2_threads.c PRE-CREATION src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121160: Add libgit2 compile-time check for threads support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70541 --- Ship it! Ship It! - Christoph Cullmann On Nov. 17, 2014, 8:11 p.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- (Updated Nov. 17, 2014, 8:11 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add libgit2 compile-time check for threads support Diffs - CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 src/test_libgit2_threads.c PRE-CREATION src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121163: Also allow absolute filepaths for configfile parameter.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Also allow absolute filepaths for configfile parameter. Diffs - src/core/engine.cpp 7fae48a09aa88565ab1bfafcbff23494fabf75b1 Diff: https://git.reviewboard.kde.org/r/121163/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/#review70545 --- Ship it! Works for me :) - Albert Astals Cid On nov. 17, 2014, 9:50 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- (Updated nov. 17, 2014, 9:50 p.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Also allow absolute filepaths for configfile parameter. Diffs - src/core/engine.cpp 7fae48a09aa88565ab1bfafcbff23494fabf75b1 Diff: https://git.reviewboard.kde.org/r/121163/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121160: Add libgit2 compile-time check for threads support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- (Updated Nov. 17, 2014, 10:45 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Add libgit2 compile-time check for threads support Diffs - CMakeLists.txt 5cace5fead7c80ede9fa82643426ab5a5e5a4035 src/test_libgit2_threads.c PRE-CREATION src/utils/kateglobal.cpp 6e3362802c213c914430a4775ab15e3515729474 Diff: https://git.reviewboard.kde.org/r/121160/diff/ Testing --- Should fix the CI failure. Compiles fine for me (with threads support) Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: gwenview build fails on branch master
1) Kdcraw is not found, although project libkdcraw is installed on the OSX/CI system. 2) I am wondering also why gwenview fails building on OSX for the not installed optional package Exiv2. --- . . . -- Could NOT find Exiv2 (missing: EXIV2_LIBRARY EXIV2_INCLUDE_DIR) (Required is at least version 0.12) . . . -- Check Kdcraw library using pkg-config... -- checking for module 'libkdcraw' -- package 'libkdcraw' not found . . . -- The following OPTIONAL packages have not been found: * Exiv2 * Kdcraw (required version = 2.4.2) CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: EXIV2_INCLUDE_DIR (ADVANCED) used as include directory in directory /Users/marko/WC/KDECI-builds/gwenview/lib used as include directory in directory /Users/marko/WC/KDECI-builds/gwenview/part EXIV2_LIBRARY (ADVANCED) linked by target gwenviewlib in directory /Users/marko/WC/KDECI-builds/gwenview/lib -- Configuring incomplete, errors occurred! See also /Users/marko/WC/KDECI-builds/gwenview/build/CMakeFiles/CMakeOutput.log. See also /Users/marko/WC/KDECI-builds/gwenview/build/CMakeFiles/CMakeError.log. KDE Continuous Integration Build == Building Project: gwenview - Branch master . . . ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- (Updated Nov. 17, 2014, 11:28 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Also allow absolute filepaths for configfile parameter. Diffs - src/core/engine.cpp 7fae48a09aa88565ab1bfafcbff23494fabf75b1 Diff: https://git.reviewboard.kde.org/r/121163/diff/ Testing --- Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70564 --- I tested this here and FileDialog qml still hangs the ui with this patch. (though at least the dialog appears) - Jeremy Whiting On Nov. 17, 2014, 10:46 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- (Updated Nov. 17, 2014, 10:46 a.m.) Review request for KDE Frameworks. Repository: frameworkintegration Description --- Based on https://git.reviewboard.kde.org/r/121098/ and on the GTK2 platform theme, which does the modal show() like this. Diffs - src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca19 Diff: https://git.reviewboard.kde.org/r/121153/diff/ Testing --- All kinds of file dialogs from tests/qfiledialogtest work as expected Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
