Re: Review Request 121173: Use correct version in kbuildsycoca5 executable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/ --- (Updated Nov. 19, 2014, 8:21 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Use correct version in kbuildsycoca5 executable Diffs - src/kbuildsycoca/kbuildsycoca.cpp 69b142745863218169d7da5a048293d6ab6b1978 Diff: https://git.reviewboard.kde.org/r/121173/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121090: Move kio-mtp to kio-extras
On Lis. 12, 2014, 10:04 odp., Àlex Fiestas wrote: I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). Aleix Pol Gonzalez wrote: Well, there's important kio's as well in kio-extras. Question is, is it useful outside the workspace? Would a cross-platform application use it? It seems to me they would, I can see amarok requiring it even on windows or gnome. Jan Grulich wrote: To me it makes more sense to have it in kio-extras with the rest of kioslaves. David Faure wrote: plasma-workspace isn't about importance. It's about what constitutes the pure desktop (a place where to show windows from applications). Actual functionality that would also work in other desktops and OSes (like dolphin, like kioslaves, and so on) belongs to Applications. kio-extras being under kde/workspace right now is really a bug, that I've been pleading against since day one. Please please move it out of there, it's nonsense for it to be there. kioslaves work in other environments. Could we move on with the review instead of discussing where kio-extras should belong? - Jan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review70301 --- On Lis. 10, 2014, 9:30 dop., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/ --- (Updated Lis. 10, 2014, 9:30 dop.) Review request for KDE Frameworks, David Faure and Philipp Schmidt. Repository: kio-extras Description --- This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style. Discussion about this move can be found here http://lists.kde.org/?l=kde-develm=141500903106761w=2 Diffs - mtp/kio_mtp_helpers.h PRE-CREATION mtp/kio_mtp_helpers.cpp PRE-CREATION mtp/mtp-network.desktop PRE-CREATION mtp/mtp.protocol PRE-CREATION mtp/solid_mtp.desktop PRE-CREATION mtp/filecache.cpp PRE-CREATION mtp/kio-mtp.kdev4 PRE-CREATION mtp/kio_mtp.h PRE-CREATION mtp/kio_mtp.cpp PRE-CREATION CMakeLists.txt 8f82688 mtp/CMakeLists.txt PRE-CREATION mtp/COPYING PRE-CREATION mtp/LICENCE PRE-CREATION mtp/Messages.sh PRE-CREATION mtp/README PRE-CREATION mtp/devicecache.h PRE-CREATION mtp/devicecache.cpp PRE-CREATION mtp/filecache.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121090/diff/ Testing --- I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine. Thanks, Jan Grulich ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: libnm-qt - a new KF5 framework for Tier 1?
On Thursday 13 of November 2014 16:39 Albert Astals Cid wrote: El Dijous, 13 de novembre de 2014, a les 16:27:20, Albert Astals Cid va escriure: El Dijous, 13 de novembre de 2014, a les 16:20:41, David Edmundson va escriure: ++ to the idea moving it. Super fast review: in the dbus folder the are 3 files called hand_edits.diff in different capitalisation. I removed them as they are not used. I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. Should we move it to private classes? As far as i understand the maintainers preferred to tie it to the nm releases and not to the frameworks releases. Has this changed? Oh man, that is what i get for email being weird and getting David answer before Jan's email, so yes i guess this has changed :D There is no plan to tie it with the NM releases. Having it released with the frameworks gives us opportunity to release fixes/changes more frequently. Cheers, Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/ --- (Updated Nov. 19, 2014, 10:39 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description --- We had a while loop which processed all application events whilst we were in the middle of creating objects. This leads to weird bugs, and workarounds in ShellCorona. Qt's methods forceCompletion does not seem to have the same problems and works just as well. Diffs - src/kdeclarative/qmlobject.cpp 029edaf Diff: https://git.reviewboard.kde.org/r/121113/diff/ Testing --- Ran plasmashell with many panels filled with applets Added debug on void ShellCorona::createWaitingPanels() to make sure it was never called with m_loading true. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70643 --- src/kcodecs.h https://git.reviewboard.kde.org/r/121047/#comment49426 The d pointers are actually accessed by implementations, so it has to be protected. - Daniel Vrátil On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64, uuencode), and the KMmime implementation of decodeRFC2047String() depends on them, I also brought over all the MIME codecs, and make use of them in all the KCodecs static methods. I believe that having a proper and more robust implementation available in a more generic framework like KCodecs is better, than if it was hidden in the KMime framework. As a result, we can make KMime framework to use KCodecs (it already depends on it anyway) for all the encodings, and only leave classes for storing and parsing the high-level message/rfc822 messages, and headers. It also reduces code duplication, and makes all applications use the same encode/decode implementations (which is cool, right? :-)) The main reason for this move is that I'm trying to move over to KCodecs one small class from KPimUtils framework in kdepimlibs (which is our universal dumping ground in kdepimlibs that I'm trying to get rid of) for generic email address validation, but it depends on proper implementations of encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The tiny Email class is not part of this review though, I'll wait for this to get in, then post another review. I believe that this is a rather useful tool that could find wide adoption outside PIM, therefor I decided not to move it from KPimUtils to KMime, but instead move all the interesting, and multi-purpose parts from KMime into KCodecs. I also moved over related KMime unit-tests (that's why the review is so big). Diffs - autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION autotests/kcodecstest.h PRE-CREATION autotests/kcodecstest.cpp PRE-CREATION autotests/rfc2047test.h PRE-CREATION autotests/rfc2047test.cpp PRE-CREATION src/CMakeLists.txt adc0f2a src/kcodecs.h 48effbb src/kcodecs.cpp 4fd660d src/kcodecs_p.h PRE-CREATION src/kcodecsbase64.h PRE-CREATION src/kcodecsbase64.cpp PRE-CREATION src/kcodecsidentity.h PRE-CREATION src/kcodecsidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION autotests/CMakeLists.txt 4c41ba2 autotests/base64benchmark.cpp PRE-CREATION autotests/codectest.h PRE-CREATION autotests/codectest.cpp PRE-CREATION autotests/data/codec_b/basic-decode.b PRE-CREATION autotests/data/codec_b/basic-decode.b.expected PRE-CREATION autotests/data/codec_b/basic-encode PRE-CREATION autotests/data/codec_b/basic-encode.expected PRE-CREATION autotests/data/codec_b/null-decode.b PRE-CREATION autotests/data/codec_b/null-decode.b.expected PRE-CREATION autotests/data/codec_b/null-encode PRE-CREATION autotests/data/codec_b/null-encode.expected PRE-CREATION autotests/data/codec_b/padding0-encode PRE-CREATION autotests/data/codec_b/padding0-encode.expected PRE-CREATION autotests/data/codec_b/padding1-encode PRE-CREATION autotests/data/codec_b/padding1-encode.expected PRE-CREATION autotests/data/codec_b/padding2-encode PRE-CREATION autotests/data/codec_b/padding2-encode.expected PRE-CREATION
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
On Nov. 18, 2014, 10:58 p.m., David Faure wrote: src/kcodecs.h, line 786 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327084#file327084line786 should be private, maybe? or is it used by subclasses? The d pointers are actually accessed by implementations, so it has to be protected. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70616 --- On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64, uuencode), and the KMmime implementation of decodeRFC2047String() depends on them, I also brought over all the MIME codecs, and make use of them in all the KCodecs static methods. I believe that having a proper and more robust implementation available in a more generic framework like KCodecs is better, than if it was hidden in the KMime framework. As a result, we can make KMime framework to use KCodecs (it already depends on it anyway) for all the encodings, and only leave classes for storing and parsing the high-level message/rfc822 messages, and headers. It also reduces code duplication, and makes all applications use the same encode/decode implementations (which is cool, right? :-)) The main reason for this move is that I'm trying to move over to KCodecs one small class from KPimUtils framework in kdepimlibs (which is our universal dumping ground in kdepimlibs that I'm trying to get rid of) for generic email address validation, but it depends on proper implementations of encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The tiny Email class is not part of this review though, I'll wait for this to get in, then post another review. I believe that this is a rather useful tool that could find wide adoption outside PIM, therefor I decided not to move it from KPimUtils to KMime, but instead move all the interesting, and multi-purpose parts from KMime into KCodecs. I also moved over related KMime unit-tests (that's why the review is so big). Diffs - autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION autotests/kcodecstest.h PRE-CREATION autotests/kcodecstest.cpp PRE-CREATION autotests/rfc2047test.h PRE-CREATION autotests/rfc2047test.cpp PRE-CREATION src/CMakeLists.txt adc0f2a src/kcodecs.h 48effbb src/kcodecs.cpp 4fd660d src/kcodecs_p.h PRE-CREATION src/kcodecsbase64.h PRE-CREATION src/kcodecsbase64.cpp PRE-CREATION src/kcodecsidentity.h PRE-CREATION src/kcodecsidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION autotests/CMakeLists.txt 4c41ba2 autotests/base64benchmark.cpp PRE-CREATION autotests/codectest.h PRE-CREATION autotests/codectest.cpp PRE-CREATION autotests/data/codec_b/basic-decode.b PRE-CREATION autotests/data/codec_b/basic-decode.b.expected PRE-CREATION autotests/data/codec_b/basic-encode PRE-CREATION autotests/data/codec_b/basic-encode.expected PRE-CREATION autotests/data/codec_b/null-decode.b PRE-CREATION autotests/data/codec_b/null-decode.b.expected PRE-CREATION autotests/data/codec_b/null-encode PRE-CREATION autotests/data/codec_b/null-encode.expected PRE-CREATION autotests/data/codec_b/padding0-encode PRE-CREATION autotests/data/codec_b/padding0-encode.expected PRE-CREATION autotests/data/codec_b/padding1-encode PRE-CREATION autotests/data/codec_b/padding1-encode.expected PRE-CREATION
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
On Nov. 19, 2014, 1:45 p.m., Daniel Vrátil wrote: src/kcodecs.h, line 786 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327084#file327084line786 The d pointers are actually accessed by implementations, so it has to be protected. Blah, this was supposed to be a comment to David's issue. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70643 --- On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64, uuencode), and the KMmime implementation of decodeRFC2047String() depends on them, I also brought over all the MIME codecs, and make use of them in all the KCodecs static methods. I believe that having a proper and more robust implementation available in a more generic framework like KCodecs is better, than if it was hidden in the KMime framework. As a result, we can make KMime framework to use KCodecs (it already depends on it anyway) for all the encodings, and only leave classes for storing and parsing the high-level message/rfc822 messages, and headers. It also reduces code duplication, and makes all applications use the same encode/decode implementations (which is cool, right? :-)) The main reason for this move is that I'm trying to move over to KCodecs one small class from KPimUtils framework in kdepimlibs (which is our universal dumping ground in kdepimlibs that I'm trying to get rid of) for generic email address validation, but it depends on proper implementations of encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The tiny Email class is not part of this review though, I'll wait for this to get in, then post another review. I believe that this is a rather useful tool that could find wide adoption outside PIM, therefor I decided not to move it from KPimUtils to KMime, but instead move all the interesting, and multi-purpose parts from KMime into KCodecs. I also moved over related KMime unit-tests (that's why the review is so big). Diffs - autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION autotests/kcodecstest.h PRE-CREATION autotests/kcodecstest.cpp PRE-CREATION autotests/rfc2047test.h PRE-CREATION autotests/rfc2047test.cpp PRE-CREATION src/CMakeLists.txt adc0f2a src/kcodecs.h 48effbb src/kcodecs.cpp 4fd660d src/kcodecs_p.h PRE-CREATION src/kcodecsbase64.h PRE-CREATION src/kcodecsbase64.cpp PRE-CREATION src/kcodecsidentity.h PRE-CREATION src/kcodecsidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION autotests/CMakeLists.txt 4c41ba2 autotests/base64benchmark.cpp PRE-CREATION autotests/codectest.h PRE-CREATION autotests/codectest.cpp PRE-CREATION autotests/data/codec_b/basic-decode.b PRE-CREATION autotests/data/codec_b/basic-decode.b.expected PRE-CREATION autotests/data/codec_b/basic-encode PRE-CREATION autotests/data/codec_b/basic-encode.expected PRE-CREATION autotests/data/codec_b/null-decode.b PRE-CREATION autotests/data/codec_b/null-decode.b.expected PRE-CREATION autotests/data/codec_b/null-encode PRE-CREATION autotests/data/codec_b/null-encode.expected PRE-CREATION autotests/data/codec_b/padding0-encode PRE-CREATION autotests/data/codec_b/padding0-encode.expected PRE-CREATION autotests/data/codec_b/padding1-encode PRE-CREATION autotests/data/codec_b/padding1-encode.expected
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
On Nov. 18, 2014, 10:58 p.m., David Faure wrote: src/kcodecs.cpp, line 113 https://git.reviewboard.kde.org/r/121047/diff/1-2/?file=327085#file327085line113 Sounds like we should at least add a TODO KF6: remove bool insertLFs, if it's useless? The alternative is to do it now: overload the method (1 arg, 2 args), and deprecate the 2 args one. (either of these can be done in a separate commit, anyhow) Added an overloaded method with just one argument and deprecated the original one. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70616 --- On Nov. 18, 2014, 2:31 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64, uuencode), and the KMmime implementation of decodeRFC2047String() depends on them, I also brought over all the MIME codecs, and make use of them in all the KCodecs static methods. I believe that having a proper and more robust implementation available in a more generic framework like KCodecs is better, than if it was hidden in the KMime framework. As a result, we can make KMime framework to use KCodecs (it already depends on it anyway) for all the encodings, and only leave classes for storing and parsing the high-level message/rfc822 messages, and headers. It also reduces code duplication, and makes all applications use the same encode/decode implementations (which is cool, right? :-)) The main reason for this move is that I'm trying to move over to KCodecs one small class from KPimUtils framework in kdepimlibs (which is our universal dumping ground in kdepimlibs that I'm trying to get rid of) for generic email address validation, but it depends on proper implementations of encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The tiny Email class is not part of this review though, I'll wait for this to get in, then post another review. I believe that this is a rather useful tool that could find wide adoption outside PIM, therefor I decided not to move it from KPimUtils to KMime, but instead move all the interesting, and multi-purpose parts from KMime into KCodecs. I also moved over related KMime unit-tests (that's why the review is so big). Diffs - autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION autotests/kcodecstest.h PRE-CREATION autotests/kcodecstest.cpp PRE-CREATION autotests/rfc2047test.h PRE-CREATION autotests/rfc2047test.cpp PRE-CREATION src/CMakeLists.txt adc0f2a src/kcodecs.h 48effbb src/kcodecs.cpp 4fd660d src/kcodecs_p.h PRE-CREATION src/kcodecsbase64.h PRE-CREATION src/kcodecsbase64.cpp PRE-CREATION src/kcodecsidentity.h PRE-CREATION src/kcodecsidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION autotests/CMakeLists.txt 4c41ba2 autotests/base64benchmark.cpp PRE-CREATION autotests/codectest.h PRE-CREATION autotests/codectest.cpp PRE-CREATION autotests/data/codec_b/basic-decode.b PRE-CREATION autotests/data/codec_b/basic-decode.b.expected PRE-CREATION autotests/data/codec_b/basic-encode PRE-CREATION autotests/data/codec_b/basic-encode.expected PRE-CREATION autotests/data/codec_b/null-decode.b PRE-CREATION autotests/data/codec_b/null-decode.b.expected PRE-CREATION autotests/data/codec_b/null-encode PRE-CREATION autotests/data/codec_b/null-encode.expected PRE-CREATION
Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 19, 2014, 1:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, KDEPIM-Libraries and David Faure. Repository: kcodecs Description --- KCodecs currently provides only decodeRFC2047String(), and even that has a comment saying more robust implementation available in KMime. This patch makes KCodecs::decodeRFC2047String() use the more robust implementation from KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using implementation from KMime. Since KMime also provides codecs implementing various MIME encodings (quoted-printable, base64, uuencode), and the KMmime implementation of decodeRFC2047String() depends on them, I also brought over all the MIME codecs, and make use of them in all the KCodecs static methods. I believe that having a proper and more robust implementation available in a more generic framework like KCodecs is better, than if it was hidden in the KMime framework. As a result, we can make KMime framework to use KCodecs (it already depends on it anyway) for all the encodings, and only leave classes for storing and parsing the high-level message/rfc822 messages, and headers. It also reduces code duplication, and makes all applications use the same encode/decode implementations (which is cool, right? :-)) The main reason for this move is that I'm trying to move over to KCodecs one small class from KPimUtils framework in kdepimlibs (which is our universal dumping ground in kdepimlibs that I'm trying to get rid of) for generic email address validation, but it depends on proper implementations of encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The tiny Email class is not part of this review though, I'll wait for this to get in, then post another review. I believe that this is a rather useful tool that could find wide adoption outside PIM, therefor I decided not to move it from KPimUtils to KMime, but instead move all the interesting, and multi-purpose parts from KMime into KCodecs. I also moved over related KMime unit-tests (that's why the review is so big). Diffs - autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION autotests/kcodecstest.h PRE-CREATION autotests/kcodecstest.cpp PRE-CREATION autotests/rfc2047test.h PRE-CREATION autotests/rfc2047test.cpp PRE-CREATION src/CMakeLists.txt adc0f2a src/kcodecs.h 48effbb src/kcodecs.cpp 4fd660d src/kcodecs_p.h PRE-CREATION src/kcodecsbase64.h PRE-CREATION src/kcodecsbase64.cpp PRE-CREATION src/kcodecsidentity.h PRE-CREATION src/kcodecsidentity.cpp PRE-CREATION src/kcodecsqp.h PRE-CREATION src/kcodecsqp.cpp PRE-CREATION src/kcodecsuuencode.h PRE-CREATION src/kcodecsuuencode.cpp PRE-CREATION autotests/CMakeLists.txt 4c41ba2 autotests/base64benchmark.cpp PRE-CREATION autotests/codectest.h PRE-CREATION autotests/codectest.cpp PRE-CREATION autotests/data/codec_b/basic-decode.b PRE-CREATION autotests/data/codec_b/basic-decode.b.expected PRE-CREATION autotests/data/codec_b/basic-encode PRE-CREATION autotests/data/codec_b/basic-encode.expected PRE-CREATION autotests/data/codec_b/null-decode.b PRE-CREATION autotests/data/codec_b/null-decode.b.expected PRE-CREATION autotests/data/codec_b/null-encode PRE-CREATION autotests/data/codec_b/null-encode.expected PRE-CREATION autotests/data/codec_b/padding0-encode PRE-CREATION autotests/data/codec_b/padding0-encode.expected PRE-CREATION autotests/data/codec_b/padding1-encode PRE-CREATION autotests/data/codec_b/padding1-encode.expected PRE-CREATION autotests/data/codec_b/padding2-encode PRE-CREATION autotests/data/codec_b/padding2-encode.expected PRE-CREATION autotests/data/codec_base64/basic-decode.base64 PRE-CREATION autotests/data/codec_base64/basic-decode.base64.expected PRE-CREATION autotests/data/codec_base64/basic-encode PRE-CREATION autotests/data/codec_base64/basic-encode.expected PRE-CREATION autotests/data/codec_base64/corrupt.base64 PRE-CREATION autotests/data/codec_base64/corrupt.base64.expected PRE-CREATION autotests/data/codec_base64/very_small-encode PRE-CREATION autotests/data/codec_base64/very_small-encode.expected PRE-CREATION
Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/ --- Review request for KDE Frameworks and David Faure. Repository: kcodecs Description --- This class can be very useful to many applications that need to deal with email address validation, and so it should not be hidden somewhere in PIM, but should be available in some more visibile framework. Also I need to kill the KPimUtils framework, and we don't really have any better-fitting framework available at this moment :) Diffs - autotests/CMakeLists.txt 825e9e8 autotests/kemailaddresstest.h PRE-CREATION autotests/kemailaddresstest.cpp PRE-CREATION src/CMakeLists.txt 8b5c4a0 src/kemailaddress.h PRE-CREATION src/kemailaddress.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121175/diff/ Testing --- Test passes. Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: lokalize fails to build on branch frameworks
Hi, I was giving lokalize a try on OSX/CI, but it failed, as it couldn’t locate hunspell properly, which is installed via MacPorts on the OSX/CI system below prefix /opt/local: --- $ port installed hunspell* The following ports are currently installed: hunspell @1.3.3_0 (active) hunspell-dict-en_GB @2008-04-24_0 (active) $ port contents hunspell | grep config /opt/local/lib/pkgconfig/hunspell.pc $ ./build.sh lokalize Calling build script BUILD FAILED == --- The build logs states that the needed cmake file is missing: --- CMake Error at src/CMakeLists.txt:4 (find_package): By not providing FindHUNSPELL.cmake in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by HUNSPELL, but CMake did not find one. Could not find a package configuration file provided by HUNSPELL with any of the following names: HUNSPELLConfig.cmake hunspell-config.cmake Add the installation prefix of HUNSPELL to CMAKE_PREFIX_PATH or set HUNSPELL_DIR to a directory containing one of the above files. If HUNSPELL provides a separate development package or SDK, be sure it has been installed. --- and it is not surprising this error arises, as it is indeed not in the MacPorts package! I figure lokalize needs for hunspell some additional configure options then... Or, it could make use of pkgconfig. Any hints? Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121178: Fix build of kdelibs4support on OSX/CI
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121178/ --- (Updated nov. 19, 2014, 9:29 p.m.) Review request for KDE Frameworks and Daniel Vrátil. Repository: kdelibs4support Description --- This was a new bug introduced by kcodecs' commit ca74c40ab79cb8d5fbffc4418c83a53071040218 ``` [ 92%] [ 93%] Building CXX object.o Undefined symbols for architecture x86_64: KCodecs::base64Encode(QByteArray const), referenced from: testCodec(char const*, Codec, bool) in kmdcodectest.cpp.o ld: symbol(s) not found for architecture x86_64 Built target kfiletreeviewtest clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [tests/kmdcodectest.app/Contents/MacOS/kmdcodectest] Error 1 make[1]: *** [tests/CMakeFiles/kmdcodectest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs ``` and can be fixed by adding the boolean parameter explicitely. Diffs - tests/kmdcodectest.cpp fb0902f Diff: https://git.reviewboard.kde.org/r/121178/diff/ Testing --- Builds fine on OSX/CI Thanks, Marko Käning ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs4support_master_qt5 #301
See http://build.kde.org/job/kdelibs4support_master_qt5/301/ -- [...truncated 1415 lines...] ^ Scanning dependencies of target kglobalstatictest [ 77%] Building CXX object autotests/CMakeFiles/kglobalstatictest.dir/kglobalstatictest.cpp.o Linking CXX executable kglobalsettingsclient Scanning dependencies of target kglobaltest [ 78%] Building CXX object autotests/CMakeFiles/kglobaltest.dir/kglobaltest.cpp.o Linking CXX executable kfilemetainfotest [ 78%] Built target kdialog_unittest [ 78%] Building CXX object autotests/CMakeFiles/kglobalstatictest.dir/kglobalstatictest_automoc.cpp.o [ 78%] Built target kfadewidgeteffecttest Scanning dependencies of target klibloadertest [ 78%] Building CXX object autotests/CMakeFiles/klibloadertest.dir/klibloadertest.cpp.o Scanning dependencies of target klibloadertestmodule3 [ 79%] Building CXX object autotests/CMakeFiles/klibloadertestmodule3.dir/klibloadertest3_module.cpp.o [ 79%] Built target kglobalsettingsclient [ 79%] [ 79%] Building CXX object autotests/CMakeFiles/klibloadertestmodule3.dir/klibloadertestmodule3_automoc.cpp.o Built target kfilemetainfotest [ 79%] Building CXX object autotests/CMakeFiles/kglobaltest.dir/kglobaltest_automoc.cpp.o Linking CXX executable kdelibs4support-kdatetimeformattertest [ 79%] Building CXX object autotests/CMakeFiles/klibloadertest.dir/klibloadertest_automoc.cpp.o Scanning dependencies of target klibloadertestmodule5 [ 79%] Building CXX object autotests/CMakeFiles/klibloadertestmodule5.dir/klibloadertest5_module.cpp.o Linking CXX executable kglobalstatictest [ 79%] Built target kdelibs4support-kdatetimeformattertest [ 80%] Building CXX object autotests/CMakeFiles/klibloadertestmodule5.dir/klibloadertestmodule5_automoc.cpp.o Linking CXX executable kglobalsettingstest [ 80%] Built target kglobalstatictest Scanning dependencies of target klocaletimeformattest Scanning dependencies of target klockfile_testlock [ 80%] Building CXX object autotests/CMakeFiles/klockfile_testlock.dir/klockfile_testlock.cpp.o [ 80%] Building CXX object autotests/CMakeFiles/klocaletimeformattest.dir/klocaletimeformattest.cpp.o Linking CXX shared module klibloadertestmodule3.so [ 80%] Building CXX object autotests/CMakeFiles/klockfile_testlock.dir/klockfile_testlock_automoc.cpp.o [ 80%] Built target kglobalsettingstest [ 80%] Building CXX object autotests/CMakeFiles/klocaletimeformattest.dir/klocaletimeformattest_automoc.cpp.o [ 80%] Scanning dependencies of target klockfiletest Built target klibloadertestmodule3 Scanning dependencies of target kmd5benchmark [ 80%] Building CXX object autotests/CMakeFiles/klockfiletest.dir/klockfiletest.cpp.o [ 80%] Building CXX object autotests/CMakeFiles/kmd5benchmark.dir/kmd5benchmark.cpp.o Scanning dependencies of target kmimetype_nomimetypes [ 80%] Building CXX object autotests/CMakeFiles/kmimetype_nomimetypes.dir/kmimetype_nomimetypes.cpp.o Linking CXX shared module klibloadertestmodule5.so Linking CXX executable klockfile_testlock Linking CXX executable kglobaltest [ 80%] Built target klibloadertestmodule5 [ 80%] Building CXX object autotests/CMakeFiles/kmd5benchmark.dir/kmd5benchmark_automoc.cpp.o Linking CXX executable klibloadertest [ 81%] Building CXX object autotests/CMakeFiles/klockfiletest.dir/klockfiletest_automoc.cpp.o [ 82%] Building CXX object autotests/CMakeFiles/kmimetype_nomimetypes.dir/kmimetype_nomimetypes_automoc.cpp.o [ 82%] Built target klockfile_testlock [ 82%] Scanning dependencies of target kmimetypetest Built target kglobaltest [ 82%] Building CXX object autotests/CMakeFiles/kmimetypetest.dir/kmimetypetest.cpp.o Scanning dependencies of target ksavefiletest [ 82%] Building CXX object autotests/CMakeFiles/ksavefiletest.dir/ksavefiletest.cpp.o [ 82%] Built target klibloadertest [ 82%] Building CXX object autotests/CMakeFiles/kmimetypetest.dir/kmimetypetest_automoc.cpp.o Scanning dependencies of target ksharedptrtest [ 82%] Building CXX object autotests/CMakeFiles/ksharedptrtest.dir/ksharedptrtest.cpp.o Scanning dependencies of target kstandarddirstest [ 82%] Building CXX object autotests/CMakeFiles/kstandarddirstest.dir/kstandarddirstest.cpp.o Linking CXX executable kmimetype_nomimetypes Linking CXX executable klocaletimeformattest Linking CXX executable klockfiletest [ 82%] Built target kmimetype_nomimetypes [ 82%] Building CXX object autotests/CMakeFiles/ksharedptrtest.dir/ksharedptrtest_automoc.cpp.o [ 82%] Built target klocaletimeformattest [ 82%] Building CXX object autotests/CMakeFiles/ksavefiletest.dir/ksavefiletest_automoc.cpp.o Scanning dependencies of target ktabwidget_unittest [ 83%] Building CXX object autotests/CMakeFiles/ktabwidget_unittest.dir/ktabwidget_unittest.cpp.o Linking CXX executable kmd5benchmark [ 83%] Built target klockfiletest [ 84%] Building CXX object autotests/CMakeFiles/kstandarddirstest.dir/kstandarddirstest_automoc.cpp.o [ 84%] Built target kmd5benchmark Scanning dependencies of
Build failed in Jenkins: kcodecs_master_qt5 #71
See http://build.kde.org/job/kcodecs_master_qt5/71/changes
Changes:
[Daniel Vrátil] Fix linker error when building against KCodecs
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace
http://build.kde.org/job/kcodecs_master_qt5/ws/
Running Prebuild steps
[kcodecs_master_qt5] $ /bin/sh -xe /tmp/hudson7344964206026258136.sh
+ /home/jenkins/scripts/setup-env.sh
Preparing to perform KDE Continuous Integration build
== Setting Up Sources
From git://anongit.kde.org/kcodecs
ca74c40..deb77a4 master - origin/master
Branch jenkins set up to track remote branch master from origin.
== Cleaning Source Tree
HEAD is now at ca74c40 Resolve ambiguity in base64Encode() overloads introduced
by my previous commit
Removing build/
Removing dotdata/
Removing local-inst/
Success build forhudson.tasks.Shell@4e5d0974
git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url git://anongit.kde.org/kcodecs # timeout=10
Fetching upstream changes from git://anongit.kde.org/kcodecs
git --version # timeout=10
git fetch --tags --progress git://anongit.kde.org/kcodecs
+refs/heads/*:refs/remotes/origin/*
git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision deb77a47654c3ce2b0a6ad10908a2a8a6fb61fb7
(refs/heads/jenkins)
git config core.sparsecheckout # timeout=10
git checkout -f deb77a47654c3ce2b0a6ad10908a2a8a6fb61fb7
git rev-list ca74c40ab79cb8d5fbffc4418c83a53071040218 # timeout=10
git tag -a -f -m Jenkins Build #71 jenkins-kcodecs_master_qt5-71 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck
results]
[kcodecs_master_qt5] $ /bin/sh -xe /tmp/hudson8229158916894843072.sh
+ /home/jenkins/scripts/execute-job.sh
KDE Continuous Integration Build
== Building Project: kcodecs - Branch master
== Build Dependencies:
dogtail - Branch master
qt5 - Branch stable
extra-cmake-modules - Branch master
cmake - Branch master
== Applying Patches
=== No patches to apply
== Syncing Dependencies from Master Server
== Configuring Build
-- The C compiler identification is GNU 4.8.2
-- The CXX compiler identification is GNU 4.8.2
-- Check for working C compiler: /home/jenkins/bin/cc
-- Check for working C compiler: /home/jenkins/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /home/jenkins/bin/c++
-- Check for working CXX compiler: /home/jenkins/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Success
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
CMake Warning (dev) at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kdesupport/extra-cmake-modules/inst/share/ECM/modules/ECMGeneratePriFile.cmake:156
(file):
Policy CMP0053 is not set: Simplify variable reference and escape sequence
evaluation. Run cmake --help-policy CMP0053 for policy details. Use the
cmake_policy command to set the policy and suppress this warning.
For input:
'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@
QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@
QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@
QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@
QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@
QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@
QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@
QT.@PRI_TARGET_BASENAME@.private_includes =
QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@
QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@
'
the old evaluation rules produce:
'QT.KCodecs.VERSION = 5.5.0
QT.KCodecs.MAJOR_VERSION = 5
QT.KCodecs.MINOR_VERSION = 5
QT.KCodecs.PATCH_VERSION = 0
QT.KCodecs.name = KF5Codecs
QT.KCodecs.defines =
QT.KCodecs.includes =
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcodecs/inst/include/KF5/KCodecs
QT.KCodecs.private_includes =
QT.KCodecs.libs =
Jenkins build is back to normal : kcodecs_master_qt5 #72
See http://build.kde.org/job/kcodecs_master_qt5/72/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdelibs4support_master_qt5 #302
See http://build.kde.org/job/kdelibs4support_master_qt5/302/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121178: Fix build of kdelibs4support on OSX/CI
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121178/ --- (Updated Nov. 19, 2014, 10:54 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Daniel Vrátil. Repository: kdelibs4support Description --- This was a new bug introduced by kcodecs' commit ca74c40ab79cb8d5fbffc4418c83a53071040218 ``` [ 92%] [ 93%] Building CXX object.o Undefined symbols for architecture x86_64: KCodecs::base64Encode(QByteArray const), referenced from: testCodec(char const*, Codec, bool) in kmdcodectest.cpp.o ld: symbol(s) not found for architecture x86_64 Built target kfiletreeviewtest clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [tests/kmdcodectest.app/Contents/MacOS/kmdcodectest] Error 1 make[1]: *** [tests/CMakeFiles/kmdcodectest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs ``` and can be fixed by adding the boolean parameter explicitely. Diffs - tests/kmdcodectest.cpp fb0902f Diff: https://git.reviewboard.kde.org/r/121178/diff/ Testing --- Builds fine on OSX/CI Thanks, Marko Käning ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121181: kcmshell: return -1 if module wasn't found
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- (Updated Nov. 19, 2014, 11:42 p.m.) Review request for KDE Frameworks. Repository: kde-cli-tools Description --- This oneliner makes kcmshell to return -1 when no module was found. This is useful to get feedback whether a module was launched or not on systems shipping both kcmshell4 and kcmshell5. For example digikam is using kcmshell4 to launch colors KCM, which is only launchable through kcmshell5 on systems running the KF5 desktop. A better approach would be nice to have though as kcmshell may not be available on all platforms. Tried KServiceTypeTrader to load the module and embedded it into a custom dialog, but as the module is available only from kf5's ksycoca that doesn't work.. Diffs - kcmshell/main.cpp 7d0ec1a Diff: https://git.reviewboard.kde.org/r/121181/diff/ Testing --- Thanks, Teemu Rytilahti ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121181: kcmshell: return -1 if module wasn't found
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- Review request for KDE Frameworks. Repository: kde-cli-tools Description --- This oneliner makes kcmshell to return -1 when no module was found. This is useful to get feedback whether a module was launched or not on systems shipping both kcmshell4 and kcmshell5. For example digikam is using kcmshell4 to launch colors KCM, which is only launchable through kcmshell5 on systems running the KF5 desktop. A better approach would be nice to have though as kcmshell may not be available on all platforms. Tried KServiceTypeTrader to load the module and embedded it into a custom dialog, but as the module is available only from kf5's ksycoca that doesn't work.. Diffs - kcmshell/main.cpp 7d0ec1a Diff: https://git.reviewboard.kde.org/r/121181/diff/ Testing --- Thanks, Teemu Rytilahti ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121181: kcmshell: return -1 if module wasn't found
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/#review70672 --- +1 looks good to me. - Aleix Pol Gonzalez On Nov. 19, 2014, 11:42 p.m., Teemu Rytilahti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121181/ --- (Updated Nov. 19, 2014, 11:42 p.m.) Review request for KDE Frameworks. Repository: kde-cli-tools Description --- This oneliner makes kcmshell to return -1 when no module was found. This is useful to get feedback whether a module was launched or not on systems shipping both kcmshell4 and kcmshell5. For example digikam is using kcmshell4 to launch colors KCM, which is only launchable through kcmshell5 on systems running the KF5 desktop. A better approach would be nice to have though as kcmshell may not be available on all platforms. Tried KServiceTypeTrader to load the module and embedded it into a custom dialog, but as the module is available only from kf5's ksycoca that doesn't work.. Diffs - kcmshell/main.cpp 7d0ec1a Diff: https://git.reviewboard.kde.org/r/121181/diff/ Testing --- Thanks, Teemu Rytilahti ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121076: Do not require KF5::Su on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Status -- This change has been marked as submitted. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- kdepasswd, which requires it, is already disabled on Windows. There is also konq-plugins/shellcmdplugins which was also disabled on Windows, but konq-plugins is entirely disabled now. Diffs - CMakeLists.txt f02b069 Diff: https://git.reviewboard.kde.org/r/121076/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Status -- This change has been marked as submitted. Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- Use CMake's generate_export_header whenever possible, and fix some inconsistent exports. Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). Diffs - dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 dolphin/src/views/dolphinitemlistview.h 7fd72e5 dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b dolphin/src/views/viewmodecontroller.h 9ea717a dolphin/src/views/viewproperties.h d3ea428 keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 keditbookmarks/main.cpp bc64193 konqueror/client/kfmclient.cpp 276452b konqueror/src/CMakeLists.txt 6831c88 konqueror/src/konq_statusbarmessagelabel.h a115d39 konqueror/src/konqmain.cpp 7a73231 konqueror/src/konqprivate_export.h 2dec78b dolphin/src/libdolphin_export.h ff0f125 dolphin/src/main.cpp 91d32a0 dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 dolphin/src/CMakeLists.txt c074908 dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 dolphin/src/kitemviews/kitemlistcontroller.h 99df531 dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 dolphin/src/kitemviews/kitemlistheader.h fe2d0ac dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e dolphin/src/kitemviews/kitemlistview.h cc0754f dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 dolphin/src/kitemviews/kitemlistwidget.h 07fc789 dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 dolphin/src/kitemviews/kstandarditem.h 59190bf dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 Diff: https://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kde-baseapps_frameworks_qt5 #199
See http://build.kde.org/job/kde-baseapps_frameworks_qt5/199/changes
Changes:
[andriusmao] Do not require KF5::Su on Windows.
[andriusmao] Fix Exports.
--
[...truncated 1578 lines...]
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/konqueror/src/konqhistorysettings.cpp:64:32:
warning: ‘const KComponentData KGlobal::mainComponent()’ is deprecated
(declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:362)
[-Wdeprecated-declarations]
if (KGlobal::mainComponent().componentName() == QLatin1String(konqueror))
^
[ 34%] Building CXX object
keditbookmarks/CMakeFiles/kdeinit_keditbookmarks.dir/faviconupdater.cpp.o
[ 34%] Building CXX object
konqueror/settings/kio/CMakeFiles/kcm_kio.dir/useragentselectordlg.cpp.o
[ 35%] Building CXX object
konqueror/settings/kio/CMakeFiles/kcm_kio.dir/netpref.cpp.o
[ 36%] Building CXX object
keditbookmarks/CMakeFiles/kdeinit_keditbookmarks.dir/exporters.cpp.o
In file included from
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/moc_kfindtreeview.cpp:9:0,
from
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/kfind_automoc.cpp:4:
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:63:37:
warning: ‘KUrl’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
[-Wdeprecated-declarations]
void removeItem(const KUrl );
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:64:37:
warning: ‘KUrl’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
[-Wdeprecated-declarations]
bool isInserted(const KUrl );
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:107:45:
warning: ‘KUrl’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
[-Wdeprecated-declarations]
void beginSearch(const KUrl baseUrl);
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:111:41:
warning: ‘KUrl’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
[-Wdeprecated-declarations]
void removeItem(const KUrl url);
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:113:41:
warning: ‘KUrl’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109)
[-Wdeprecated-declarations]
bool isInserted(const KUrl url) { return m_model-isInserted( url );
}
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/../../kfind/kfindtreeview.h:124:33:
warning: ‘List’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143)
[-Wdeprecated-declarations]
KUrl::List selectedUrls();
^
In file included from
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/kfind_automoc.cpp:4:0:
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/moc_kfindtreeview.cpp:
In static member function ‘static void
KFindTreeView::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/moc_kfindtreeview.cpp:183:30:
warning: ‘List’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143)
[-Wdeprecated-declarations]
case 3: { KUrl::List _r = _t-selectedUrls();
^
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/moc_kfindtreeview.cpp:184:53:
warning: ‘List’ is deprecated (declared at
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143)
[-Wdeprecated-declarations]
if (_a[0]) *reinterpret_cast KUrl::List*(_a[0]) = _r; } break;
^
In file included from
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/moc_kftabdlg.cpp:9:0,
from
http://build.kde.org/job/kde-baseapps_frameworks_qt5/ws/build/kfind/kfind_automoc.cpp:5:
Re: Review Request 121078: Fix exports.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70678 --- This breaks compilation on Linux (was this tested?) and on CI: fatal error: libdolphin_export.h: No such file or directory - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/ --- (Updated Nov. 20, 2014, 3:29 a.m.) Review request for KDE Base Apps, KDE Frameworks and kdewin. Repository: kde-baseapps Description --- Use CMake's generate_export_header whenever possible, and fix some inconsistent exports. Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit apps (removing kdemacros.h where KDE_EXPORT was being in use). Diffs - dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 dolphin/src/views/dolphinitemlistview.h 7fd72e5 dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b dolphin/src/views/viewmodecontroller.h 9ea717a dolphin/src/views/viewproperties.h d3ea428 keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 keditbookmarks/main.cpp bc64193 konqueror/client/kfmclient.cpp 276452b konqueror/src/CMakeLists.txt 6831c88 konqueror/src/konq_statusbarmessagelabel.h a115d39 konqueror/src/konqmain.cpp 7a73231 konqueror/src/konqprivate_export.h 2dec78b dolphin/src/libdolphin_export.h ff0f125 dolphin/src/main.cpp 91d32a0 dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 dolphin/src/CMakeLists.txt c074908 dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 dolphin/src/kitemviews/kitemlistcontroller.h 99df531 dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 dolphin/src/kitemviews/kitemlistheader.h fe2d0ac dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e dolphin/src/kitemviews/kitemlistview.h cc0754f dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 dolphin/src/kitemviews/kitemlistwidget.h 07fc789 dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 dolphin/src/kitemviews/kstandarditem.h 59190bf dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 Diff: https://git.reviewboard.kde.org/r/121078/diff/ Testing --- It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending to review today). Kdebase-apps is still not very functional, though (missing icons and weird UI). Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
