Re: Review Request 121063: use correct ki18n_wrap_ui in ki18n based framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121063/ --- (Updated Nov. 29, 2014, 2:27 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs4support Description --- see summary Diffs - src/kssl/kcm/CMakeLists.txt 4e5ac11 tests/CMakeLists.txt 25275e8 Diff: https://git.reviewboard.kde.org/r/121063/diff/ Testing --- builds Thanks, Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121289/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- Return type is QList and not QVector for this method. Diffs - src/lib/plugin/kpluginloader.h 855786b Diff: https://git.reviewboard.kde.org/r/121289/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121289/#review71089 --- Ship it! Ship It! - David Edmundson On Nov. 29, 2014, 7:27 p.m., Andreas Cord-Landwehr wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121289/ --- (Updated Nov. 29, 2014, 7:27 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Return type is QList and not QVector for this method. Diffs - src/lib/plugin/kpluginloader.h 855786b Diff: https://git.reviewboard.kde.org/r/121289/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121289/ --- (Updated Nov. 29, 2014, 7:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcoreaddons Description --- Return type is QList and not QVector for this method. Diffs - src/lib/plugin/kpluginloader.h 855786b Diff: https://git.reviewboard.kde.org/r/121289/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/#review71092 --- +1 from me. If no-one else comments, consider it a ship it, but I don't really know this code or X startup src/kioexec/main.cpp https://git.reviewboard.kde.org/r/121230/#comment49660 where do you use this? - David Edmundson On Nov. 24, 2014, 5:52 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/ --- (Updated Nov. 24, 2014, 5:52 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- The code was hard disabled due to usage of Q_WS_X11. The task is to get the startupid passed to kioexec and forward it to the process started by kioexec. As Qt's xcb plugin removes the DESKTOP_STARTUP_ID environment variable once it is read, this needs special handling to setup the enivornment for the process to be started. Unfortunately the fix requires Qt 5.4 as the startupId is only provided by QX11Extras since 5.4. Diffs - CMakeLists.txt 888edff2bee476b4d2098b375a38a2b3a86135e8 src/kioexec/CMakeLists.txt 6c587e19310a5395f0db455f48fe18a27e9ec386 src/kioexec/config-kioexec.h.cmake PRE-CREATION src/kioexec/main.cpp f0e282394c4f65df0bf52141290d37ba6b32ad8c Diff: https://git.reviewboard.kde.org/r/121230/diff/ Testing --- used DESKTOP_STARTUP_ID=FOO kioexec gwenview %U file:///path/to/local/file.png with and without the change and inspected /proc/x/environ for the started gwenview process. Without the patch DESKTOP_STARTUP_ID is not set, with the patch it's properly set to FOO in this case. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/#review71093 --- Ship it! I just tested the Linux build still compiles fine. Ship it - David Edmundson On Oct. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- (Updated Oct. 29, 2014, 2:27 a.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2
On June 26, 2014, 7:29 a.m., Thomas Lübking wrote: this is however not ABI relevant, so depending on schedules one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-) Martin Gräßlin wrote: yeah I'm fine with delaying to post 5.0 in frameworks. Means KWin 5.0 will not have full support for it. But if it gets into KWindowSystem 5.1 we can still add it in a minor KWin relase (and get killed by distros for increasing requirement in a minor release :-P ). Thomas Lübking wrote: if this is causing downstream dep issues, maybe a generic NETRootInfo::setSupported(const QString property) might be a good idea? Martin Gräßlin wrote: could be something to look into for 5.1, good idea. 5.1 has been and gone. What's the status of this? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118946/#review60994 --- On June 26, 2014, 7:22 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118946/ --- (Updated June 26, 2014, 7:22 a.m.) Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2 Although non-standard it needs to be added to the NET::PRoperties2 in order to have KWin announce it in the supported section. As soon as this gets standardized WM2ShowWindowMenu can be changed to point to both the proprietary GTK hint and the standardized hint. Diffs - autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 Diff: https://git.reviewboard.kde.org/r/118946/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2
On Juni 26, 2014, 7:29 vorm., Thomas Lübking wrote: this is however not ABI relevant, so depending on schedules one *could* wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop symbol: removing it from the enum is oc. not API stable, thus not possible) and be introduced even with KWin 5.0.3 or whatever the final name scheme will be ;-) Martin Gräßlin wrote: yeah I'm fine with delaying to post 5.0 in frameworks. Means KWin 5.0 will not have full support for it. But if it gets into KWindowSystem 5.1 we can still add it in a minor KWin relase (and get killed by distros for increasing requirement in a minor release :-P ). Thomas Lübking wrote: if this is causing downstream dep issues, maybe a generic NETRootInfo::setSupported(const QString property) might be a good idea? Martin Gräßlin wrote: could be something to look into for 5.1, good idea. David Edmundson wrote: 5.1 has been and gone. What's the status of this? There hasn't even been a request from gtk+ devs to get this into NETWM. I was about to rant that the GTK (gnome first) devs give a damn about interoperability and expect to run after us!, but google (wanted to be sure ;-) pushed up http://people.freedesktop.org/~cbrill/dri-log//dri-devel-2014-05-08.log 07:45 #wayland: Jasper mgraesslin, whenever I send mails to wm-spec-list I don't get any replies, so I stopped bothering Jasper is apparently the one who added support to mutter. --- @Martin I would suggest to either declare NETWM dead XOR formalize the board. Eg. one would define a high council consisting of the maintainers of the relevant™ WMs (KWin, Mutter, Openbox and Enlightenment for sure. Compiz IFF Canonical promises to behave. Eventually awesome? I probably forgot an obvious one) an setup some rules. a) A proposal of a high council member w/o veto of any other HC member within 21 days is in. b) A proposal of a non member that has seen no reaction from high council or delegates within 21 days causes reposts with increasing frequence. c) New features MUST be announced as supported by the WM, ignoring that hint and just expecting it is a client bug by definition. d) A proposal containing the term should or any equivalent is auto-invalid ;-) I'd also suggest to move from wm-spec-l...@gnome.org to sth. like ne...@lists.freedesktop.org and/or have a fdo bugzilla bugtracker for handling concerns/proposals. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118946/#review60994 --- On Juni 26, 2014, 7:22 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118946/ --- (Updated Juni 26, 2014, 7:22 vorm.) Review request for KDE Frameworks and kwin. Repository: kwindowsystem Description --- Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2 Although non-standard it needs to be added to the NET::PRoperties2 in order to have KWin announce it in the supported section. As soon as this gets standardized WM2ShowWindowMenu can be changed to point to both the proprietary GTK hint and the standardized hint. Diffs - autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 Diff: https://git.reviewboard.kde.org/r/118946/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
