Re: Review Request 121299: Add NET::OSD window type

> On Nov. 30, 2014, 10:45 nachm., Thomas Lübking wrote: > > Please notice that override redirects are above EVERY managed window, ie. > > if you fullscreen window happens to be an SDL(? some toolkit does this at > > least) game, the new layer will fail its job. > > > > Random 3¢: > > So either

Re: Review Request 121299: Add NET::OSD window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/ --- (Updated Dez. 1, 2014, 6:49 nachm.) Review request for KDE Frameworks, kw

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Dec. 1, 2014, 7:40 p.m.) Review request for KDE Frameworks and M

Re: Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/ --- (Updated Dec. 1, 2014, 6:18 p.m.) Status -- This change has been mar

Re: Review Request 121317: Add JSON metadata to the kded modules

> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? > > Aleix Pol Gonzalez wrote: > Sorry, I meant KCM. > > Alexander Richardson wrote: > `grep -irn "background" /kf5-install/share/kservices5/kded` does n

Re: Review Request 121317: Add JSON metadata to the kded modules

> On Dez. 1, 2014, 4:59 nachm., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? > > Aleix Pol Gonzalez wrote: > Sorry, I meant KCM. `grep -irn "background" /kf5-install/share/kservices5/kded` does not give any results for me, where c

Re: Review Request 121317: Add JSON metadata to the kded modules

> On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: > > Have you checked if the "Background Services" kded still works after this? Sorry, I meant KCM. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 121317: Add JSON metadata to the kded modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review71202 --- Have you checked if the "Background Services" kded still works

Review Request 121317: Add JSON metadata to the kded modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo

Re: Review Request 121314: KPluginInfo: store d->entryPath in KPluginMetaData instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121314/ --- (Updated Dec. 1, 2014, 4:30 p.m.) Status -- This change has been mar

Review Request 121315: Allow using kded modules with JSON metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121315/ --- Review request for KDE Frameworks and David Faure. Repository: kded Des

Re: Review Request 121314: KPluginInfo: store d->entryPath in KPluginMetaData instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121314/#review71200 --- Ship it! Nice! - Sebastian Kügler On Dec. 1, 2014, 4:26 p.

Re: Review Request 121305: convert to new signal slot syntax and categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121305/ --- (Updated Dec. 1, 2014, 4:27 p.m.) Status -- This change has been mar

Review Request 121314: KPluginInfo: store d->entryPath in KPluginMetaData instead

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121314/ --- Review request for KDE Frameworks and Sebastian Kügler. Repository: kserv

Re: Review Request 121313: Introduce KPluginMetaData::metaDataSource()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121313/ --- (Updated Dec. 1, 2014, 4:14 p.m.) Status -- This change has been mar

Re: Review Request 121313: Introduce KPluginMetaData::metaDataSource()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121313/#review71195 --- Ship it! Suggesting metaDataFile(), otherwise looks good. s

Review Request 121313: Introduce KPluginMetaData::metaDataSource()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121313/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo

Jenkins build is back to stable : kcoreaddons_master_qt5 #168

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kcoreaddons_stable_qt5 #6

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118946: Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2

> On June 26, 2014, 9:29 a.m., Thomas Lübking wrote: > > this is however not ABI relevant, so depending on schedules one *could* > > wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop > > symbol: removing it from the enum is oc. not API stable, thus not possible) > > a

Jenkins build is back to stable : kservice_master_qt5 #206

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/ --- (Updated Dec. 1, 2014, 2:57 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kservice_stable_qt5 #6

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kcoreaddons_master_qt5 #166

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kcoreaddons_stable_qt5 #4

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71188 --- Ship it! Ship It! - David Faure On Dec. 1, 2014, 2:02 p.m.

Re: Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/#review71185 --- Ship it! autotests/kemailaddresstest.cpp

Re: Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

> On Nov. 23, 2014, 4:26 p.m., David Faure wrote: > > Problem: I don't think anyone looking for this functionality would think of > > looking in KCodecs. This is not related to codecs at all. > > > > kcoreaddons/src/lib/text/ has more similar stuff, like > > KStringHandler::tagUrls. > > > > T

Re: Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121308/ --- (Updated Dec. 1, 2014, 2:37 p.m.) Status -- This change has been mar

Re: Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

> On Nov. 23, 2014, 5:26 p.m., David Faure wrote: > > Problem: I don't think anyone looking for this functionality would think of > > looking in KCodecs. This is not related to codecs at all. > > > > kcoreaddons/src/lib/text/ has more similar stuff, like > > KStringHandler::tagUrls. > > > > T

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Dec. 1, 2014, 3:02 p.m.) Review request for KDE Frameworks and D

Re: Review Request 121305: convert to new signal slot syntax and categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121305/#review71178 --- Ship it! Ship It! - Sebastian Kügler On Dec. 1, 2014, 11:1

Jenkins build became unstable: kio_stable_qt5 #5

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/ --- (Updated Dec. 1, 2014, 1:16 p.m.) Status -- This change has been mar

Re: Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121308/#review71171 --- Ship it! Yes indeed. Using the CWD makes no sense, in a GUI p

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

> On Dec. 1, 2014, 1:45 p.m., David Faure wrote: > > This isn't a Qt5/KF5 porting issue, right? IIUC the same issue happens in > > kdelibs4? This isn't an argument against fixing it, of course, I'm just > > curious. I haven't checked the kdelibs4 version, but I assume it's the same there. -

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/#review71169 --- Ship it! Ship It! - Marco Martin On Nov. 14, 2014, 6:08 p.

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/#review71168 --- This isn't a Qt5/KF5 porting issue, right? IIUC the same issue

Re: Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121308/#review71166 --- I see no problem with it, but would like to let it hang on RB

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/#review71165 --- Ship it! Looks good to me once the open issues have be solved

Re: Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/#review71164 --- Ship it! Ship It! - David Faure On Nov. 24, 2014, 5:52 p.m

Review Request 121308: Do not require KPluginMetaData::fileName() to always be absolute

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121308/ --- Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repo

Re: Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec

> On Nov. 29, 2014, 8:36 p.m., David Edmundson wrote: > > src/kioexec/main.cpp, line 47 > > > > > > where do you use this? directly the next line: #if HAVE_X11 - Martin ---

Re: Review Request 121305: convert to new signal slot syntax and categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121305/#review71153 --- Ship it! Ship It! - David Faure On Dec. 1, 2014, 11:14 a.m

Review Request 121305: convert to new signal slot syntax and categorized logging

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121305/ --- Review request for KDE Frameworks and David Faure. Repository: kded Des

Re: Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121118/#review71148 --- Ship it! Depending on the addition of 121094 first ... - Aar

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/#review71147 --- src/lib/text/ktexttohtml_p.h

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

> On Nov. 30, 2014, 2:29 p.m., Milian Wolff wrote: > > src/kstandardaction.cpp, line 153 > > > > > > is the call to `setCheckable` not required anymore? b/c that is > > otherwise missing on the new patch now, no

Re: Review Request 121299: Add NET::OSD window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review71144 --- I don't like the usage of a TLA. Could we make it OnScreenDisp

Re: Review Request 121299: Add NET::OSD window type

> On Nov. 30, 2014, 11:45 p.m., Thomas Lübking wrote: > > Please notice that override redirects are above EVERY managed window, ie. > > if you fullscreen window happens to be an SDL(? some toolkit does this at > > least) game, the new layer will fail its job. > > > > Random 3¢: > > So either t

Re: Review Request 121299: Add NET::OSD window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review71142 --- src/netwm.cpp

Jenkins build is back to stable : kio_master_qt5 #439

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel