Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter 
On Wed, Dec 24, 2014 at 11:47 AM, David Edmundson
da...@davidedmundson.co.uk wrote:


 On Wed, Dec 17, 2014 at 12:47 PM, Harald Sitter sit...@kde.org wrote:

 alohas.

 recently the QCA maintainer and I got into a discussion [1] whether a
 qca-qt5 library should be a different config inside the same cmake
 package or an independent one (detailed discussion in the longest
 comment thread of the review).

  find_package(Qca NAMES Qca-qt5 Qca-QT5 Qca-5 Qca REQUIRES)

 or

  find_package(Qca-qt5)

 former is very much in line with the maintainer's expectation of how
 qca is supposed to have any odd suffix supplied by the distro [2] that
 would eventually disappear,


 If the prefix ever disappears, aren't we going to end up with exactly the
 same crisis in reverse, with Qt4 apps now accidentally linking against a Qt5
 library with exactly the same name?

Yes, although to be perfectly honest that is a general problem with
how we use cmake (or name our libraries, respectively the cmake
package).

If I have
- libfoo.1
and then do a BIC I'd bump to
- libfoo.2
on a CMake level the package is still called foo though.

An application using foo would have done something like this to use libfoo.1:
- find_package(foo 1.0)
Problem is that this still works after a soname change to libfoo.2
even though that new version is potentially not suitable. At this
point the best one can do is hope that something in the
compilation/linkage goes wrong and the build explodes.

I think(tm) the way to fix this properly (which I have not ever seen
done by us :P) is fiddling with the find_package related variables
(supposedly PACKAGE_VERSION_COMPATIBLE would be used) to indicate that
a given candidate package is not compatible for what was looked for.
This combined with the way find_package finds its cmake config
(globbing), by the way should allows for easy installation
compatibility even in the simplest of libraries.

i.e.

- cmake/libfoo1/FooConfig.cmake
  checks PACKAGE_FIND_VERSION - sets PACKAGE_VERSION_COMPATIBLE=false
if not something like 1.*

- cmake/libfoo2/FooConfig.cmake
  as libfoo2 but makes sure the looked for version is 2.*

- headers get installed to a soname'd dir (which we kind of have for
KF5 at large but not individual libs)

There, that went a bit off-topic but now I got that off my chest as well ^^

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: qca-qt5 package name

2014-12-27 Thread Alex Merry 
On Saturday 27 December 2014 12:24:25 Harald Sitter wrote:
 I think(tm) the way to fix this properly (which I have not ever seen
 done by us :P) is fiddling with the find_package related variables
 (supposedly PACKAGE_VERSION_COMPATIBLE would be used) to indicate that
 a given candidate package is not compatible for what was looked for.
 This combined with the way find_package finds its cmake config
 (globbing), by the way should allows for easy installation
 compatibility even in the simplest of libraries.
 
 i.e.
 
 - cmake/libfoo1/FooConfig.cmake
   checks PACKAGE_FIND_VERSION - sets PACKAGE_VERSION_COMPATIBLE=false
 if not something like 1.*
 
 - cmake/libfoo2/FooConfig.cmake
   as libfoo2 but makes sure the looked for version is 2.*
 
 - headers get installed to a soname'd dir (which we kind of have for
 KF5 at large but not individual libs)

Yes, this is exactly what the *ConfigVersion.cmake file is supposed to do. 
WRITE_BASIC_PACKAGE_VERSION_FILE()[0], which we use to write those files, even 
has a COMPATIBILITY SameMajorVersion option, which should be used by those 
projects for which that makes sense.

Alex

[0]: 
http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:CMakePackageConfigHelpers
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: qca-qt5 package name

2014-12-27 Thread Harald Sitter 
On Sat, Dec 27, 2014 at 1:47 PM, Alex Merry alex.me...@kde.org wrote:
 On Saturday 27 December 2014 12:24:25 Harald Sitter wrote:
 I think(tm) the way to fix this properly (which I have not ever seen
 done by us :P) is fiddling with the find_package related variables
 (supposedly PACKAGE_VERSION_COMPATIBLE would be used) to indicate that
 a given candidate package is not compatible for what was looked for.
 This combined with the way find_package finds its cmake config
 (globbing), by the way should allows for easy installation
 compatibility even in the simplest of libraries.

 i.e.

 - cmake/libfoo1/FooConfig.cmake
   checks PACKAGE_FIND_VERSION - sets PACKAGE_VERSION_COMPATIBLE=false
 if not something like 1.*

 - cmake/libfoo2/FooConfig.cmake
   as libfoo2 but makes sure the looked for version is 2.*

 - headers get installed to a soname'd dir (which we kind of have for
 KF5 at large but not individual libs)

 Yes, this is exactly what the *ConfigVersion.cmake file is supposed to do.
 WRITE_BASIC_PACKAGE_VERSION_FILE()[0], which we use to write those files, even
 has a COMPATIBILITY SameMajorVersion option, which should be used by those
 projects for which that makes sense.

Awesome. Now if only it wasn't hardcoded to AnyNewerVersion in
ECM_SETUP_VERSION() *nudge* ;)

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: QSP patch ( was KF5 Update Meeting Minutes 2014-w28 )

2014-12-27 Thread Andrius da Costa Ribas 
In our Windows Emerge scripts QStandardPaths is already being patched for a
while:

http://quickgit.kde.org/?p=emerge.gita=blobh=e716bf675669139059a96db6be76cc3470487d64hb=b64cc189fa1918894653f185068e1786b31bd02ef=portage%2Flibs%2Fqt5%2Fqtbase%2Fqtbase-20130714.patch



2014-12-15 19:12 GMT-02:00 Marko Käning mk-li...@email.de:

 Hi David,

 back to our discussion during this summer:

 On 10 Jul 2014, at 11:57 , David Faure fa...@kde.org wrote:
  Wrong approach. XDG is a freedesktop thing which doesn't apply to Mac.
 
  This should be fixed the other way around:
  1) finding out how Mac OS lets people configure the location for their
 files,
  or if this isn't configurable, coming up with QT_* environment variables.
  2) patching QStandardPaths to use these
  3) setting these vars in the CT scripts


 Since a fortnight we’re discussing the QStandardPaths patch needed for the
 OSX/CI
 system [0] on KDE-MAC [1,2] and it would be good if you’d join this
 discussion now,
 as Ben also wants to come up with a patch for Windows very soon.
 (Ian actually had already included you in his last post [3] to thread [1].)

 Can we have this discussion on KDE-MAC (or on both lists), as Ian and René
 aren’t
 subscribed to K-F-D?!

 Regards,
 Marko




 [0]
 http://quickgit.kde.org/?p=clones%2Fwebsites%2Fbuild-kde-org%2Fkaning%2Fmp-osx-ci.gita=blobh=27deb1cb8f8f70ea949fc241e049d9b47a10f6dfhb=8126ab8cb976f42a4ebe5d3b7d2cb7a3d42217d1f=patches%2Fqt5%2Fkf5-qt5%2Fpatch-qstandardpaths_mac.cpp.diff

 [1] http://mail.kde.org/pipermail/kde-mac/2014-December/002590.html

 [2] http://mail.kde.org/pipermail/kde-mac/2014-December/002705.html

 [3] http://mail.kde.org/pipermail/kde-mac/2014-December/002737.html
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: snippetextractor_master_qt5 #1

2014-12-27 Thread KDE CI System 
See http://build.kde.org/job/snippetextractor_master_qt5/1/

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 
http://build.kde.org/job/snippetextractor_master_qt5/ws/
Running Prebuild steps
[snippetextractor_master_qt5] $ /bin/sh -xe /tmp/hudson3133915640074358446.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources


== Cleaning Source Tree

Success build forhudson.tasks.Shell@2a382452
Cloning the remote Git repository
Cloning repository git://anongit.kde.org/kcoreaddons
  git init http://build.kde.org/job/snippetextractor_master_qt5/ws/ # 
  timeout=10
Fetching upstream changes from git://anongit.kde.org/kcoreaddons
  git --version # timeout=10
  git fetch --tags --progress git://anongit.kde.org/kcoreaddons 
  +refs/heads/*:refs/remotes/origin/*
  git config remote.origin.url git://anongit.kde.org/kcoreaddons # timeout=10
  git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
  timeout=10
  git config remote.origin.url git://anongit.kde.org/kcoreaddons # timeout=10
Fetching upstream changes from git://anongit.kde.org/kcoreaddons
  git fetch --tags --progress git://anongit.kde.org/kcoreaddons 
  +refs/heads/*:refs/remotes/origin/*
  git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
  git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
  git rev-parse refs/heads/jenkins^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-27 Thread Arjun AK 


 On Dec. 26, 2014, 1:44 p.m., David Faure wrote:
  This has been reverted for now, it broke the kio_trash unittest, because it 
  doesn't preserve extensions anymore. Please revisit.

Like i said in the ML, what should be done with the following files:
`.txt`
`..txt`
`...`


- Arjun


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121461/#review72518
---


On Dec. 23, 2014, 11:26 p.m., Arjun AK wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121461/
 ---
 
 (Updated Dec. 23, 2014, 11:26 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Bugs: 341773
 https://bugs.kde.org/show_bug.cgi?id=341773
 
 
 Repository: kio
 
 
 Description
 ---
 
 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains 
 dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the 
 extension.
 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, 
 instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't 
 be changing that.
 
 
 Diffs
 -
 
   autotests/globaltest.cpp 06cb500 
   src/core/global.cpp f18ac10 
 
 Diff: https://git.reviewboard.kde.org/r/121461/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Arjun AK
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kf5book_master_qt5 #2

2014-12-27 Thread KDE CI System 
See http://build.kde.org/job/kf5book_master_qt5/2/

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 
http://build.kde.org/job/kf5book_master_qt5/ws/
Running Prebuild steps
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson7787900241173264431.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at c76bd56 Handle top level headers as chapters.
Success build forhudson.tasks.Shell@1a15cf88
  git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  git config remote.origin.url git://anongit.kde.org/kcoreaddons # timeout=10
Fetching upstream changes from git://anongit.kde.org/kcoreaddons
  git --version # timeout=10
  git fetch --tags --progress git://anongit.kde.org/kcoreaddons 
  +refs/heads/*:refs/remotes/origin/*
  git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
  git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
  git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision c76bd56580c6eeeaf7764f4e766af58eec16a7a3 
(refs/heads/jenkins)
  git config core.sparsecheckout # timeout=10
  git checkout -f c76bd56580c6eeeaf7764f4e766af58eec16a7a3
  git rev-list c76bd56580c6eeeaf7764f4e766af58eec16a7a3 # timeout=10
  git tag -a -f -m Jenkins Build #2 jenkins-kf5book_master_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson1843693716991970107.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kf5book - Branch master
== Build Dependencies:
 snippetextractor - Branch master
 qt5 - Branch 5.3.2
 dogtail - Branch master
 extra-cmake-modules - Branch master
 cmake - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

CMake Error at CMakeLists.txt:11 (message):
  Need pandoc


-- Configuring incomplete, errors occurred!
See also 
http://build.kde.org/job/kf5book_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;.
Configure step exited with non-zero code, assuming failure to configure for 
project kf5book.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kf5book_master_qt5 #4

2014-12-27 Thread KDE CI System 
See http://build.kde.org/job/kf5book_master_qt5/4/

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 
http://build.kde.org/job/kf5book_master_qt5/ws/
Running Prebuild steps
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson4002282204328477374.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at c76bd56 Handle top level headers as chapters.
Success build forhudson.tasks.Shell@6bb9f552
  git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
  git config remote.origin.url git://anongit.kde.org/kf5book # timeout=10
Fetching upstream changes from git://anongit.kde.org/kf5book
  git --version # timeout=10
  git fetch --tags --progress git://anongit.kde.org/kf5book 
  +refs/heads/*:refs/remotes/origin/*
  git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
  git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
  git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision c76bd56580c6eeeaf7764f4e766af58eec16a7a3 
(refs/heads/jenkins)
  git config core.sparsecheckout # timeout=10
  git checkout -f c76bd56580c6eeeaf7764f4e766af58eec16a7a3
First time build. Skipping changelog.
  git tag -a -f -m Jenkins Build #4 jenkins-kf5book_master_qt5-4 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kf5book_master_qt5] $ /bin/sh -xe /tmp/hudson4713616851677646965.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kf5book - Branch master
== Build Dependencies:
 snippetextractor - Branch master
 qt5 - Branch 5.3.2
 dogtail - Branch master
 extra-cmake-modules - Branch master
 cmake - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server


== Configuring Build

CMake Error at CMakeLists.txt:36 (file):
  file COPY cannot find
  
http://build.kde.org/job/kf5book_master_qt5/ws/threadweaver/threadweaver/examples/screenshots;.


-- Configuring incomplete, errors occurred!
See also 
http://build.kde.org/job/kf5book_master_qt5/ws/build/CMakeFiles/CMakeOutput.log;.
Configure step exited with non-zero code, assuming failure to configure for 
project kf5book.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel