On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote:
+static const QString SUBSTITUTE_ME=QStringLiteral(%1);
I'm not sure that adding global static (non-POD) objects in libraries is a
good idea.
We've had many problems with that in the past (see below for details), and
they slow down
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122204/
---
(Updated Jan. 25, 2015, 3:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120621/
---
(Updated Jan. 25, 2015, 12:23 p.m.)
Status
--
This change has been
On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote:
+static const QString SUBSTITUTE_ME=QStringLiteral(%1);
I'm not sure that adding global static (non-POD) objects in libraries is a
good idea.
We've had many problems with that in the past (see below for details), and
they
On Sunday 25 January 2015 12:36:08 David Faure wrote:
On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote:
+static const QString SUBSTITUTE_ME=QStringLiteral(%1);
I'm not sure that adding global static (non-POD) objects in libraries is a
good idea.
We've had many problems with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122179/
---
(Updated Jan. 25, 2015, 6:49 p.m.)
Status
--
This change has been
On Jan. 24, 2015, 5:12 p.m., Matthew Dawson wrote:
autotests/kconfig_in_global_object.cpp, line 56
https://git.reviewboard.kde.org/r/122232/diff/1/?file=33#file33line56
This doesn't actually trigger anything when run without the fix below.
Since a name is provided in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122198/
---
(Updated Jan. 26, 2015, 7:52 a.m.)
Review request for KDE Frameworks,
On Jan. 23, 2015, 5:48 p.m., Thomas Lübking wrote:
I assume there's requirement for a setter as well (rather than even a
getter)?
Right now only the Oxygen kstyle is using the atom in the BlurHelpr. @Hugo:
would you like to have an easier to use setter?
- Martin
Because otherwise, it is a very bad thing to do. There is *no* reason to ever
do:
QString(%1).arg(foo);
There are no overloads of QString::number having fieldWidth argument.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
On Jan. 24, 2015, 12:12 p.m., Matthew Dawson wrote:
autotests/kconfig_in_global_object.cpp, line 56
https://git.reviewboard.kde.org/r/122232/diff/1/?file=33#file33line56
This doesn't actually trigger anything when run without the fix below.
Since a name is provided in
11 matches
Mail list logo