Re: [ki18n] src: small qstring optimizations

2015-01-25 Thread David Faure
On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote: +static const QString SUBSTITUTE_ME=QStringLiteral(%1); I'm not sure that adding global static (non-POD) objects in libraries is a good idea. We've had many problems with that in the past (see below for details), and they slow down

Re: Review Request 122204: Mark results as required.

2015-01-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122204/ --- (Updated Jan. 25, 2015, 3:53 p.m.) Status -- This change has been

Re: Review Request 120621: Add atlas support into ImagesTexturesCache

2015-01-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120621/ --- (Updated Jan. 25, 2015, 12:23 p.m.) Status -- This change has been

Re[2]: [ki18n] src: small qstring optimizations

2015-01-25 Thread Nick Shaforostoff
On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote: +static const QString SUBSTITUTE_ME=QStringLiteral(%1); I'm not sure that adding global static (non-POD) objects in libraries is a good idea. We've had many problems with that in the past (see below for details), and they

Re: [ki18n] src: small qstring optimizations

2015-01-25 Thread Milian Wolff
On Sunday 25 January 2015 12:36:08 David Faure wrote: On Wednesday 21 January 2015 21:32:07 Nick Shaforostoff wrote: +static const QString SUBSTITUTE_ME=QStringLiteral(%1); I'm not sure that adding global static (non-POD) objects in libraries is a good idea. We've had many problems with

Re: Review Request 122179: kded: port to KDEDModule::moduleForMessage

2015-01-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122179/ --- (Updated Jan. 25, 2015, 6:49 p.m.) Status -- This change has been

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-25 Thread David Faure
On Jan. 24, 2015, 5:12 p.m., Matthew Dawson wrote: autotests/kconfig_in_global_object.cpp, line 56 https://git.reviewboard.kde.org/r/122232/diff/1/?file=33#file33line56 This doesn't actually trigger anything when run without the fix below. Since a name is provided in

Re: Review Request 122198: Add support for _NET_WM_OPAQUE_REGION

2015-01-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122198/ --- (Updated Jan. 26, 2015, 7:52 a.m.) Review request for KDE Frameworks,

Re: Review Request 122198: Add support for _NET_WM_OPAQUE_REGION

2015-01-25 Thread Martin Gräßlin
On Jan. 23, 2015, 5:48 p.m., Thomas Lübking wrote: I assume there's requirement for a setter as well (rather than even a getter)? Right now only the Oxygen kstyle is using the atom in the BlurHelpr. @Hugo: would you like to have an easier to use setter? - Martin

Re[2]: [ki18n] src: small qstring optimizations

2015-01-25 Thread Nick Shaforostoff
Because otherwise, it is a very bad thing to do. There is *no* reason to ever do: QString(%1).arg(foo); There are no overloads of QString::number having fieldWidth argument. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-01-25 Thread Matthew Dawson
On Jan. 24, 2015, 12:12 p.m., Matthew Dawson wrote: autotests/kconfig_in_global_object.cpp, line 56 https://git.reviewboard.kde.org/r/122232/diff/1/?file=33#file33line56 This doesn't actually trigger anything when run without the fix below. Since a name is provided in