Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Ivan Čukić 
 My opinion is still the same on this matter: VS2012 (aka MSVC11).

I guessed as much. Just wanted to get the ball rolling again so that
we can reach a decision, instead of just talking about it.

I also think that (while insufficient for the most fun things of
c++11) MSVC11 (VS12) is the currently sanest choice (for frameworks).

If the ball stops again, I'll consider this a decision well made. :)

Cheers,
Ivan

On 29 January 2015 at 15:52, Ivan Čukić ivan.cu...@gmail.com wrote:
 My opinion is still the same on this matter: VS2012 (aka MSVC11).

 I guessed as much. Just wanted to get the ball rolling again so that
 we can reach a decision, instead of just talking about it.

 I also think that (while insufficient for the most fun things of
 c++11) MSVC11 (VS12) is the currently sanest choice.

 Cheers,
 Ivan


 Regards.
 --
 Kévin Ottens, http://ervin.ipsquad.net

 KDAB - proud supporter of KDE, http://www.kdab.com


 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel




 --
 KDE, ivan.cu...@kde.org, http://ivan.fomentgroup.org/
 gpg key id: 850B6F76



-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/#review74983
---


any updates on that?

here the patch works correctly after i make kdesu to be installed under 
CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR

I would push this asap, since kdesu in Plasma 5 is *still* broken.
if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the safest 
from a coinstallability pov), i'll move where kdesu is installed as well

- Marco Martin


On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120185/
 ---
 
 (Updated Oct. 4, 2014, 3:32 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Bugs: 338755
 https://bugs.kde.org/show_bug.cgi?id=338755
 
 
 Repository: kio
 
 
 Description
 ---
 
 kdesu is installed in libexec/ look for it there first. I left the 
 findExecutable search as a backup.
 Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be 
 installed in libexec/kf5?
 
 Insert 'kdesu' at the end to show a nicer error. If we leave this part out 
 the error is Could not launch 'root' which is somewhat correct but not as 
 easy to figure out as Could not launch 'kdesu'
 
 Also added an unrelated QFile::decodeName() call.
 
 
 Diffs
 -
 
   autotests/krununittest.cpp b1da9aa 
   src/core/desktopexecparser.cpp 9510697 
 
 Diff: https://git.reviewboard.kde.org/r/120185/diff/
 
 
 Testing
 ---
 
 Created .desktop file with X-KDE-SubstituteUID=true
 Now I can launch it as root and when I remove kdesu I got a normal error 
 message.
 
 Unit test no longer skips because kdesu is not found.
 
 
 Thanks,
 
 Maarten De Meyer
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin 


 On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote:
  any updates on that?
  
  here the patch works correctly after i make kdesu to be installed under 
  CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR
  
  I would push this asap, since kdesu in Plasma 5 is *still* broken.
  if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the 
  safest from a coinstallability pov), i'll move where kdesu is installed as 
  well

as in, would still need http://paste.opensuse.org/67799408


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/#review74983
---


On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120185/
 ---
 
 (Updated Oct. 4, 2014, 3:32 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Bugs: 338755
 https://bugs.kde.org/show_bug.cgi?id=338755
 
 
 Repository: kio
 
 
 Description
 ---
 
 kdesu is installed in libexec/ look for it there first. I left the 
 findExecutable search as a backup.
 Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be 
 installed in libexec/kf5?
 
 Insert 'kdesu' at the end to show a nicer error. If we leave this part out 
 the error is Could not launch 'root' which is somewhat correct but not as 
 easy to figure out as Could not launch 'kdesu'
 
 Also added an unrelated QFile::decodeName() call.
 
 
 Diffs
 -
 
   autotests/krununittest.cpp b1da9aa 
   src/core/desktopexecparser.cpp 9510697 
 
 Diff: https://git.reviewboard.kde.org/r/120185/diff/
 
 
 Testing
 ---
 
 Created .desktop file with X-KDE-SubstituteUID=true
 Now I can launch it as root and when I remove kdesu I got a normal error 
 message.
 
 Unit test no longer skips because kdesu is not found.
 
 
 Thanks,
 
 Maarten De Meyer
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122206: [kio] Make tests optional

2015-01-29 Thread Martin Gräßlin 


 On Jan. 23, 2015, 9:58 p.m., David Faure wrote:
  Not sure why this is suddenly triggering many philosophical discussions 
  about what users should be doing (IMHO, give them choice, this is 
  opensource).
  Similar changes have been done in most other frameworks long ago, this is 
  most certainly consistent.
  (see e.g. kcoreaddons - the find_package(Qt5Test) is being done in the 
  autotests subfolder, the same could be done here).
 
 Vishesh Handa wrote:
 It's not about users, it's about developers/packagers. We're not forcing 
 them to run the tests, we're telling them to compile them. They always have a 
 choice by modifying the code, we as upstream shouldn't be making it easier 
 for them to skip the most of basic of quality tests.

@Vishesh: as I went through the same thing I point you to 
https://git.reviewboard.kde.org/r/117393/ - it was a discussion for the same on 
KWin and now I think it was good that we accepted the solution in the end. 
Maybe the reasoning provided there helps to understand the packagers needs.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122206/#review74633
---


On Jan. 22, 2015, 8:48 p.m., Andreas Sturmlechner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122206/
 ---
 
 (Updated Jan. 22, 2015, 8:48 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kio
 
 
 Description
 ---
 
 [kio] Make tests optional
 This is a small patch to CMakeLists.txt to only depend on Qt5Test if 
 BUILD_TESTING.
 
 
 Diffs
 -
 
   CMakeLists.txt 7fe0be5d4b2d7d9475a7844b4f8d93fc2f0a00c3 
 
 Diff: https://git.reviewboard.kde.org/r/122206/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Andreas Sturmlechner
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Ivan Čukić 
Hi all,

So, the thread died out again.

Who is in favour of the following:
- Require MSVC10 like (aka status quo)
- Require MSVC11
- Require MSVC12

(it would be nice to get the input from kde windows guys as well)

Cheerio,
Ivan




On 17 November 2014 at 14:41, Kai Uwe Broulik k...@privat.broulik.de wrote:

   - initializer lists
  Unsupported on VS2012.

 Again, seems to be that CTP thingie, damn. (though, again, the initializer
 lists should also be tested - maybe they also work if the number of arguments
 is less than ...)

 I've had problems with them even on VS2013, like return QHashint, 
 QByteArray({ {FooRole, foo} });
 For QAbstractListModel::roleNames() which worked fine in recent clang and gcc.
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel



-- 
Cheerio,
Ivan

--
While you were hanging yourself on someone else's words
Dying to believe in what you heard
I was staring straight into the shining sun
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: reviving make uninstall?

2015-01-29 Thread Sebastian Kügler 
On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote:
  It's only used by developers anyways, so why bother? If it makes life
  simpler
  for devs, it should be there, no? Normal users who might get confused by
  it
  won't ever run make (un)install either, no?
 
 +1. I found myself many times typing make uninstall to no avail.
 Would be nice to have it back.

Same here, would love to have it back.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Andrius da Costa Ribas 
+1 for VC12 (I'm using msvc 2013)

--
Andrius.

2015-01-29 6:49 GMT-02:00 Ivan Čukić ivan.cu...@kde.org:

 Hi all,

 So, the thread died out again.

 Who is in favour of the following:
 - Require MSVC10 like (aka status quo)
 - Require MSVC11
 - Require MSVC12

 (it would be nice to get the input from kde windows guys as well)

 Cheerio,
 Ivan




 On 17 November 2014 at 14:41, Kai Uwe Broulik k...@privat.broulik.de
 wrote:
 
- initializer lists
   Unsupported on VS2012.
 
  Again, seems to be that CTP thingie, damn. (though, again, the
 initializer
  lists should also be tested - maybe they also work if the number of
 arguments
  is less than ...)
 
  I've had problems with them even on VS2013, like return QHashint,
 QByteArray({ {FooRole, foo} });
  For QAbstractListModel::roleNames() which worked fine in recent clang
 and gcc.
  ___
  Kde-frameworks-devel mailing list
  Kde-frameworks-devel@kde.org
  https://mail.kde.org/mailman/listinfo/kde-frameworks-devel



 --
 Cheerio,
 Ivan

 --
 While you were hanging yourself on someone else's words
 Dying to believe in what you heard
 I was staring straight into the shining sun
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_master_qt5 #216

2015-01-29 Thread KDE CI System 
See http://build.kde.org/job/kde-baseapps_master_qt5/216/changes

Changes:

[emmanuelpescosta099] Revert commit 0c6c76b038e868e225f7816fae39635d472bce0a 
and make the

--
[...truncated 3048 lines...]
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:103:84:
 warning: ‘bool QTest::kWaitForSignal(QObject*, const char*, int)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:48)
 [-Wdeprecated-declarations]
 QVERIFY(QTest::kWaitForSignal(view, SIGNAL(viewCompleted(KonqView*)), 
1));

^
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:
 In member function ‘void KonqHtmlTest::windowOpen()’:
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:118:24:
 warning: ‘KTemporaryFile’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktemporaryfile.h:52)
 [-Wdeprecated-declarations]
 KTemporaryFile tempFile;
^
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:122:24:
 warning: ‘KTemporaryFile’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/ktemporaryfile.h:52)
 [-Wdeprecated-declarations]
 KTemporaryFile origTempFile;
^
In file included from 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtTest/qtest.h:38:0,
 from 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include/QtTest/QtTest:7,
 from 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:23,
 from 
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:27:
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:140:24:
 warning: ‘bool QTest::kWaitForSignal(QObject*, const char*, int)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:48)
 [-Wdeprecated-declarations]
 QVERIFY(QTest::kWaitForSignal(view, SIGNAL(viewCompleted(KonqView*)), 
1));
^
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:140:84:
 warning: ‘bool QTest::kWaitForSignal(QObject*, const char*, int)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:48)
 [-Wdeprecated-declarations]
 QVERIFY(QTest::kWaitForSignal(view, SIGNAL(viewCompleted(KonqView*)), 
1));

^
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:
 In member function ‘void KonqHtmlTest::testJSError()’:
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:179:24:
 warning: ‘bool QTest::kWaitForSignal(QObject*, const char*, int)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:48)
 [-Wdeprecated-declarations]
 QVERIFY(QTest::kWaitForSignal(view, SIGNAL(viewCompleted(KonqView*)), 
2));
^
http://build.kde.org/job/kde-baseapps_master_qt5/ws/konqueror/src/tests/konqhtmltest.cpp:179:84:
 warning: ‘bool QTest::kWaitForSignal(QObject*, const char*, int)’ is 
deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/qtest_kde.h:48)
 [-Wdeprecated-declarations]
 QVERIFY(QTest::kWaitForSignal(view, SIGNAL(viewCompleted(KonqView*)), 
2));

^
[ 65%] Built target undomanagertest
[ 66%] Scanning dependencies of target kdeinit_dolphin
Building CXX object 
dolphin/src/CMakeFiles/kcm_dolphinnavigation.dir/settings/settingspagebase.cpp.o
[ 66%] Building CXX object 
dolphin/src/CMakeFiles/kdeinit_dolphin.dir/dolphinapplication.cpp.o
[ 66%] Building CXX object 
dolphin/src/CMakeFiles/kcm_dolphingeneral.dir/settings/general/previewssettingspage.cpp.o
[ 66%] Built target konqviewtest
http://build.kde.org/job/kde-baseapps_master_qt5/ws/dolphin/src/settings/general/behaviorsettingspage.cpp:
 In member function ‘virtual void BehaviorSettingsPage::applySettings()’:
http://build.kde.org/job/kde-baseapps_master_qt5/ws/dolphin/src/settings/general/behaviorsettingspage.cpp:116:75:
 warning: ‘static void

Re: Review Request 120040: Install kdesu under bin

2015-01-29 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120040/
---

(Updated Jan. 29, 2015, 3:16 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: kde-cli-tools


Description
---

this is a part of adressing the bug
https://bugs.kde.org/show_bug.cgi?id=338755
https://bugs.kde.org/show_bug.cgi?id=338756

in kde4 kdesu was installed under bin, and should still, being something that 
should be invokable 
but renames it to kdesu5, for coinstallability reasons

therefore, kio/src/core/desktopexecparser.cpp should be modified to search for 
kdesu5 instead of kdesu


Diffs
-

  kdesu/CMakeLists.txt 2a70831 

Diff: https://git.reviewboard.kde.org/r/120040/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: reviving make uninstall?

2015-01-29 Thread Mark Gaiser 
On Thu, Jan 29, 2015 at 12:46 PM, Sebastian Kügler se...@kde.org wrote:

 On Thursday, January 29, 2015 00:32:08 Martin Klapetek wrote:
   It's only used by developers anyways, so why bother? If it makes life
   simpler
   for devs, it should be there, no? Normal users who might get confused
 by
   it
   won't ever run make (un)install either, no?
 
  +1. I found myself many times typing make uninstall to no avail.
  Would be nice to have it back.

 Same here, would love to have it back.


Same here.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122206: [kio] Make tests optional

2015-01-29 Thread Vishesh Handa 


 On Jan. 23, 2015, 8:58 p.m., David Faure wrote:
  Not sure why this is suddenly triggering many philosophical discussions 
  about what users should be doing (IMHO, give them choice, this is 
  opensource).
  Similar changes have been done in most other frameworks long ago, this is 
  most certainly consistent.
  (see e.g. kcoreaddons - the find_package(Qt5Test) is being done in the 
  autotests subfolder, the same could be done here).
 
 Vishesh Handa wrote:
 It's not about users, it's about developers/packagers. We're not forcing 
 them to run the tests, we're telling them to compile them. They always have a 
 choice by modifying the code, we as upstream shouldn't be making it easier 
 for them to skip the most of basic of quality tests.
 
 Martin Gräßlin wrote:
 @Vishesh: as I went through the same thing I point you to 
 https://git.reviewboard.kde.org/r/117393/ - it was a discussion for the same 
 on KWin and now I think it was good that we accepted the solution in the end. 
 Maybe the reasoning provided there helps to understand the packagers needs.

@Martin: I do prefer the solution in the kwin patch. This one is really messy.

Though I still don't agree with their reasons.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122206/#review74633
---


On Jan. 22, 2015, 7:48 p.m., Andreas Sturmlechner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122206/
 ---
 
 (Updated Jan. 22, 2015, 7:48 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kio
 
 
 Description
 ---
 
 [kio] Make tests optional
 This is a small patch to CMakeLists.txt to only depend on Qt5Test if 
 BUILD_TESTING.
 
 
 Diffs
 -
 
   CMakeLists.txt 7fe0be5d4b2d7d9475a7844b4f8d93fc2f0a00c3 
 
 Diff: https://git.reviewboard.kde.org/r/122206/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Andreas Sturmlechner
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Milian Wolff 
On Thursday 29 January 2015 11:56:51 Kevin Ottens wrote:
 On Thursday 29 January 2015 09:49:58 Ivan Čukić wrote:
  Hi all,
  
  So, the thread died out again.
  
  Who is in favour of the following:
  - Require MSVC10 like (aka status quo)
  - Require MSVC11
  - Require MSVC12
 
 My opinion is still the same on this matter: VS2012 (aka MSVC11).

+1
-- 
Milian Wolff
m...@milianw.de
http://milianw.de
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120185: Look for kdesu in the correct location

2015-01-29 Thread Marco Martin 


 On Jan. 29, 2015, 3:01 p.m., Marco Martin wrote:
  any updates on that?
  
  here the patch works correctly after i make kdesu to be installed under 
  CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 instead of CMAKE_INSTALL_FULL_LIBEXECDIR
  
  I would push this asap, since kdesu in Plasma 5 is *still* broken.
  if CMAKE_INSTALL_FULL_LIBEXECDIR_KF5 is ok (that seems where it's the 
  safest from a coinstallability pov), i'll move where kdesu is installed as 
  well
 
 Marco Martin wrote:
 as in, would still need http://paste.opensuse.org/67799408

now kdesu is in CMAKE_INSTALL_FULL_LIBEXECDIR_KF5


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120185/#review74983
---


On Oct. 4, 2014, 3:32 p.m., Maarten De Meyer wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120185/
 ---
 
 (Updated Oct. 4, 2014, 3:32 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Bugs: 338755
 https://bugs.kde.org/show_bug.cgi?id=338755
 
 
 Repository: kio
 
 
 Description
 ---
 
 kdesu is installed in libexec/ look for it there first. I left the 
 findExecutable search as a backup.
 Is looking in CMAKE_INSTALL_FULL_LIBEXECDIR correct? Or will kde-cli-tools be 
 installed in libexec/kf5?
 
 Insert 'kdesu' at the end to show a nicer error. If we leave this part out 
 the error is Could not launch 'root' which is somewhat correct but not as 
 easy to figure out as Could not launch 'kdesu'
 
 Also added an unrelated QFile::decodeName() call.
 
 
 Diffs
 -
 
   autotests/krununittest.cpp b1da9aa 
   src/core/desktopexecparser.cpp 9510697 
 
 Diff: https://git.reviewboard.kde.org/r/120185/diff/
 
 
 Testing
 ---
 
 Created .desktop file with X-KDE-SubstituteUID=true
 Now I can launch it as root and when I remove kdesu I got a normal error 
 message.
 
 Unit test no longer skips because kdesu is not found.
 
 
 Thanks,
 
 Maarten De Meyer
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-29 Thread Albert Astals Cid 


 On gen. 29, 2015, 7:46 a.m., David Faure wrote:
  Shouldn't splitArgs be fixed instead? After all a real shell would not 
  split on that character, would it?

That is indeed a good question. Bash doesn't seem to need the quotes, but i 
don't know about other shells, and i figured out adding some extra quotes for 
safety isn't really a problem and it's actually easier to fix and will have 
less regressions (since i want this backported to kdelibs too). But if you 
really prefer change in splitArgs I can have a look.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122300/#review74967
---


On gen. 28, 2015, 11:24 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122300/
 ---
 
 (Updated gen. 28, 2015, 11:24 p.m.)
 
 
 Review request for KDE Frameworks, David Faure, Eike Hein, and Michael Pyne.
 
 
 Bugs: 343380
 https://bugs.kde.org/show_bug.cgi?id=343380
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 We need to also quote spaces like the Unicode character 'IDEOGRAPHIC SPACE' 
 (U+3000) in KShell::quoteArg since KShell::splitArgs is using QChar::isSpace 
 to decide when a new argument starts, without the quoting, one argument will 
 get turned into two
 
 
 Diffs
 -
 
   autotests/kshelltest.cpp 451bbe9 
   src/lib/util/kshell_unix.cpp e0e884f 
 
 Diff: https://git.reviewboard.kde.org/r/122300/diff/
 
 
 Testing
 ---
 
 New test passes, bug 343380 is fixed
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122313: Expose to world whether KPty has been built with utempter library

2015-01-29 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122313/
---

Review request for KDE Frameworks and David Faure.


Repository: kpty


Description
---

Equivalent to https://svn.reviewboard.kde.org/r/2468/
It was lost in KF5 porting, and it was directly used to determine whether 
kwrited should be built as module, or executable (in this case, it would be a 
SUID binary, which Qt5 no longer -by default- allows)


Diffs
-

  CMakeLists.txt 7fe77da7b0bc97c6f64db4fcc63ef7831fa065b1 
  KF5PtyConfig.cmake.in 04bde7bffd209b57e755a66278025ee8b6453770 
  cmake/FindUTEMPTER.cmake PRE-CREATION 
  src/CMakeLists.txt caf2f0ba87ad4173af9860ae369b43d50ffd219f 
  src/ConfigureChecks.cmake f52be3f5e031c73dd7d26296622c14c9d69db42c 

Diff: https://git.reviewboard.kde.org/r/122313/diff/


Testing
---

built, cmake configuration looks ok.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122300: Fix quoteArgs for spaces that are not the regular space

2015-01-29 Thread David Faure 


 On Jan. 29, 2015, 7:46 a.m., David Faure wrote:
  Shouldn't splitArgs be fixed instead? After all a real shell would not 
  split on that character, would it?
 
 Albert Astals Cid wrote:
 That is indeed a good question. Bash doesn't seem to need the quotes, but 
 i don't know about other shells, and i figured out adding some extra quotes 
 for safety isn't really a problem and it's actually easier to fix and will 
 have less regressions (since i want this backported to kdelibs too). But if 
 you really prefer change in splitArgs I can have a look.

Hmm ok, yeah, I guess extra quoting doesn't hurt. This code exists to avoid 
quoting everything single argument since that would look awful, but in corner 
cases like this, no harm done indeed.

I don't object to this patch, but I still think splitArgs has a corner case 
bug, if it's splitting where it shouldn't.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122300/#review74967
---


On Jan. 28, 2015, 11:24 p.m., Albert Astals Cid wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122300/
 ---
 
 (Updated Jan. 28, 2015, 11:24 p.m.)
 
 
 Review request for KDE Frameworks, David Faure, Eike Hein, and Michael Pyne.
 
 
 Bugs: 343380
 https://bugs.kde.org/show_bug.cgi?id=343380
 
 
 Repository: kcoreaddons
 
 
 Description
 ---
 
 We need to also quote spaces like the Unicode character 'IDEOGRAPHIC SPACE' 
 (U+3000) in KShell::quoteArg since KShell::splitArgs is using QChar::isSpace 
 to decide when a new argument starts, without the quoting, one argument will 
 get turned into two
 
 
 Diffs
 -
 
   autotests/kshelltest.cpp 451bbe9 
   src/lib/util/kshell_unix.cpp e0e884f 
 
 Diff: https://git.reviewboard.kde.org/r/122300/diff/
 
 
 Testing
 ---
 
 New test passes, bug 343380 is fixed
 
 
 Thanks,
 
 Albert Astals Cid
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel