Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-05 Thread Bhushan Shah
On Feb. 3, 2015, 11:10 p.m., Ivan Čukić wrote: This does fix the switching, but I don't agree it is the right place for it (I don't like that this plugin exists at all tbh). When switching the activities, there needs to be a (UI) feedback - the switcher needs to show up. That means

Change in kio[master]: cleanup: simplify fooPtr != NULL and related

2015-02-05 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/362 Change subject: cleanup: simplify fooPtr != NULL and related .. cleanup: simplify fooPtr != NULL and related Also use nullptr on

Re: Review Request 122438: Notiy config leak fix try 2

2015-02-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/ --- (Updated Feb. 5, 2015, 9:34 p.m.) Status -- This change has been

Re: Review Request 122438: Notiy config leak fix try 2

2015-02-05 Thread Xuetian Weng
On Feb. 5, 2015, 10:31 a.m., Mark Gaiser wrote: src/knotificationplugin.h, line 60 https://git.reviewboard.kde.org/r/122438/diff/1/?file=347092#file347092line60 Why wait? You can do that now and deprecate this function, right? You just can't remove it till KF6.

Re: Review Request 122438: Notiy config leak fix try 2

2015-02-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75460 --- Ship it! Thank you! - Martin Klapetek On Feb. 5, 2015,

Re: KDE Frameworks Sprint

2015-02-05 Thread Cornelius Schumacher
On Wednesday 04 February 2015 01:33:00 Aleix Pol wrote: Do we want a KDE Frameworks sprint? I think it could be interesting, at least to recapitulate about the first year of KF5, find what we liked and decide how to keep going. Who would be interested? I would be interested, especially

Re: Review Request 122430: add optional properties rangeMax and rangeMin

2015-02-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- (Updated Feb. 5, 2015, 9:50 a.m.) Status -- This change has been

Review Request 122438: Notiy config leak fix try 2

2015-02-05 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/ --- Review request for KDE Frameworks and Martin Klapetek. Repository:

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

2015-02-05 Thread Matthew Dawson
On Jan. 27, 2015, 3:55 p.m., Matthew Dawson wrote: Unforunately, this cause test system failures in the the kconfigskeletontest test suite. I'm not sure why this should create issues there. However, I have a partial solution that avoids creating a full KSharedConfig. Instead,

Review Request 122445: an if-statement at KDesktopFile::locateLocal is not build correctly

2015-02-05 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122445/ --- Review request for KDE Frameworks, Cornelius Schumacher, Nicolás Alvarez,

Re: KDE Frameworks Sprint

2015-02-05 Thread Albert Astals Cid
El Dimecres, 4 de febrer de 2015, a les 01:33:00, Aleix Pol va escriure: Hello, Do we want a KDE Frameworks sprint? I think it's a great idea. I think it could be interesting, at least to recapitulate about the first year of KF5, find what we liked and decide how to keep going. Who

Re: Review Request 122438: Notiy config leak fix try 2

2015-02-05 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75461 --- src/knotificationplugin.h

strange problem with KConfig

2015-02-05 Thread Marco Martin
Hi all, I was investigating this bug.. https://bugs.kde.org/show_bug.cgi?id=343583 but after digging and digging, it looks like more and more an issue in KConfig.. basically if there is a config file in a system-wide location (to give default configs that would then be overridden by whatever