Review Request 122576: Introduce KMoreTools

2015-02-15 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta.

Re: Web shortcuts context menu

2015-02-15 Thread Eike Hein
On 02/15/2015 06:12 PM, Alex Merry wrote: http://wstaw.org/m/2015/02/15/ctx.png That link doesn't work - could you attach it to an email, please? Attached. Alex Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then

2015-02-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/#review76057 --- Ship it! I am still no sure, if that is the best way to go,

Web shortcuts context menu

2015-02-15 Thread Eike Hein
Hi, about two years(?) ago I wrote a Web Shortcuts context menu for Konversation: http://wstaw.org/m/2015/02/15/ctx.png This code subsequently got copied to at least Okular and Konsole, perhaps others - making it an obvious can- didate for moving into Frameworks instead so it can be shared

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

2015-02-15 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122579/ --- (Updated Feb. 16, 2015, Mitternacht) Review request for KDE Frameworks

Jenkins build became unstable: ktexteditor_stable_qt5 #49

2015-02-15 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_stable_qt5/49/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

2015-02-15 Thread Friedrich W. H. Kossebau
On Feb. 15, 2015, 10:37 nachm., David Faure wrote: Nice, love unittests. Most of the new code in kzip.cpp is a copy of the contents of the previous while loop, though. Is there any chance for extracting this into a helper method, to avoid the duplication? It would facilitate

Re: Review Request 122551: New feature: Open all recent files

2015-02-15 Thread Thomas Murach
On Feb. 13, 2015, 9:42 nachm., Gregor Mi wrote: This only covers your point 3): You added a menu item Open all recent files. What about hide it by default and let the client (kate, kaffeine etc.) decide if it should be shown or not by - e.g. with .setOpenAllMenuItemVisible(true);

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2015-02-15 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated Feb. 15, 2015, 6:27 p.m.) Review request for KDE Frameworks.

Re: kio and scheme://

2015-02-15 Thread Mark Gaiser
On Sun, Feb 15, 2015 at 8:00 PM, Àlex Fiestas afies...@kde.org wrote: On Tuesday 04 November 2014 21:47:36 you wrote: On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: Hi there There are quite a few places where the following code is found: if (!url.path().endsWith('/')) {

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2015-02-15 Thread Àlex Fiestas
On Feb. 9, 2015, 7:24 p.m., David Faure wrote: This should not be done if the slave has provided a UDS_MIME_TYPE. E.g. kio_smb sends mimetypes that derive from inode/directory, such as application/x-smb-server and application/x-smb-workgroup. If you think this works with the current

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2015-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review76082 --- Ship it! Ah I see. Good! Thanks for the tests, I'm

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

2015-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122579/#review76084 --- Nice, love unittests. Most of the new code in kzip.cpp is a

Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then

2015-02-15 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/#review76088 --- kate/src/kateapp.cpp

Build failed in Jenkins: kdelibs4support_master_qt5 #328

2015-02-15 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/328/changes Changes: [scripty] Upgrade KF5 version to 5.8.0. -- [...truncated 1027 lines...] [ 39%] Building CXX object src/CMakeFiles/KF5KDELibs4Support.dir/kdeui/kaction.cpp.o [ 39%] Building CXX

Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5

2015-02-15 Thread Albert Astals Cid
El Divendres, 13 de febrer de 2015, a les 08:49:10, Marko Käning va escriure: Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5: Because there's no such thing as kde-baseapps stable-kf5-qt5, your scripts assume there is, but that's

Re: OSX/CI: kde-baseapps fails to build for branch-group stable-kf5-qt5

2015-02-15 Thread Marko Käning
Hi Albert, On 15 Feb 2015, at 23:12 , Albert Astals Cid aa...@kde.org wrote: El Divendres, 13 de febrer de 2015, a les 08:49:10, Marko Käning va escriure: Hi Albert, I just realised that kde-baseapps fails on OSX/CI when being build for branch group stable-kf5-qt5: Because there's no

Re: Review Request 122579: Stop failing on ZIP files with redundant data descriptors

2015-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122579/#review76100 --- Ship it! Thanks :-) - David Faure On Feb. 16, 2015,