Re: Review Request 121317: Add JSON metadata to the kded modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76698 --- Oops, what happened here? Did I forget to review this? Having json metadata for all kded modules sounds like a great idea (especially since kiod requires that, so if some move later to kiod, it will have to be done). - David Faure On Feb. 26, 2015, 6:53 p.m., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 26, 2015, 6:53 p.m.) Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repository: kio Description --- Add JSON metadata to the kded modules Diffs - src/kssld/kssld.cpp e3e503af996b411325fab10eb9b3daf5d9617bae src/kssld/CMakeLists.txt 564602ca73a849758906639b5f07665c995c9a21 src/kpasswdserver/kpasswdserver.cpp 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 src/kpasswdserver/CMakeLists.txt 21e5c2d17358b3d1233c753d15284cdc790423e0 src/kpac/proxyscout.cpp 375f77503272e700929433c44086f4e213502c6e src/kpac/CMakeLists.txt 7e6ce1f6cdb992b2ce45ab895aea72df24955fe2 src/kioexec/main.cpp f0e282394c4f65df0bf52141290d37ba6b32ad8c src/ioslaves/http/kcookiejar/kcookieserver.cpp c441496dff316d4e94a4cccdfd46615cd76a7238 src/ioslaves/http/kcookiejar/CMakeLists.txt 890a35bcc24ca043844257f3d2cdd0941ddd1d17 Diff: https://git.reviewboard.kde.org/r/121317/diff/ Testing --- the converted modules can be loaded Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave
On Feb. 25, 2015, 10:24 a.m., Vishesh Handa wrote: sftp/kio_sftp.cpp, line 247 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247 The code indentation seems wrong. Emmanuel Pescosta wrote: Just followed the coding style (1 tab - 2 spaces) from kio_sftp.cpp Should I use the frameworks coding style instead? Ah. I didn't see the rest of the file. Probbaly best to follow it, like you have :) - Vishesh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review76592 --- On Feb. 18, 2015, 11:14 a.m., Emmanuel Pescosta wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/ --- (Updated Feb. 18, 2015, 11:14 a.m.) Review request for KDE Frameworks and Andreas Schneider. Repository: kio-extras Description --- Implemented SlaveBase::GetFileSystemFreeSpace to enable free space information in sftp ioslave. Diffs - sftp/kio_sftp.h e088472 sftp/kio_sftp.cpp 057fcd4 Diff: https://git.reviewboard.kde.org/r/122621/diff/ Testing --- Works Thanks, Emmanuel Pescosta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1031
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1032
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. There, I fixed it. https://git.reviewboard.kde.org/r/122729/ Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/#review76685 --- src/services/kservicetypetrader.h https://git.reviewboard.kde.org/r/122732/#comment52817 I'll update this to use a lambda src/services/kservicetypetrader.h https://git.reviewboard.kde.org/r/122732/#comment52818 This section can probably be deleted - Alex Richardson On Feb. 26, 2015, 7:44 nachm., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- (Updated Feb. 26, 2015, 7:44 nachm.) Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: kservice Description --- These are a lot more flexible and less error-prone and will eventually allow us to remove the trader query language in KF6 once all users in KService are gone. REVIEW: 122732 Diffs - autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122733: Fix path traversal checks in KPackage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kpackage Description --- They did not canonicalize the package base directory path so it would always fail when the package base path contained symlinks Diffs - src/kpackage/package.cpp eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing --- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122732: Add std::function overloads for KServiceTypeTrader
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122732/ --- Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: kservice Description --- These are a lot more flexible and less error-prone and will eventually allow us to remove the trader query language in KF6 once all users in KService are gone. REVIEW: 122732 Diffs - autotests/ksycocathreadtest.cpp fbd889b28a32397fbf9245827ff8b54405b82e3d autotests/kservicetest.cpp d46f868185c3bf45138d80d04f4eb0d2840de9ca src/services/kservicetypetrader.h 8e46812c2eeddca225e978a4dd55aa4cc5e902d0 src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af Diff: https://git.reviewboard.kde.org/r/122732/diff/ Testing --- Unit tests pass There are still some more classes that use the string based checks, I'll add a std::function overload to them as well once this has been approved. Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/#review76681 --- Ping? - Alex Richardson On Dez. 24, 2014, 1:23 nachm., Alex Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- (Updated Dez. 24, 2014, 1:23 nachm.) Review request for KDE Frameworks, David Faure and Nicolás Alvarez. Repository: kconfigwidgets Description --- Not sure if MSVC has the necessary type_traits working, but can't test that now since it don't have a Windows machine available. Diffs - autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 Diff: https://git.reviewboard.kde.org/r/121218/diff/ Testing --- The newly added unit test passes Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283/ --- (Updated Feb. 26, 2015, 6:49 nachm.) Review request for KDE Frameworks, David Faure and Nicolás Alvarez. Repository: kxmlgui Description --- Allow using new style connect in KActionCollection::add[Action]() Diffs (updated) - src/kactioncollection.h 5ff9a7781a4455c5d1ed79d366efd290f0879e9d Diff: https://git.reviewboard.kde.org/r/121283/diff/ Testing --- Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121317: Add JSON metadata to the kded modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/ --- (Updated Feb. 26, 2015, 6:53 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks, David Faure and Sebastian Kügler. Repository: kio Description --- Add JSON metadata to the kded modules Diffs - src/kssld/kssld.cpp e3e503af996b411325fab10eb9b3daf5d9617bae src/kssld/CMakeLists.txt 564602ca73a849758906639b5f07665c995c9a21 src/kpasswdserver/kpasswdserver.cpp 7bd34cc1286acb48e2e0060d97b7fad4cd0a4388 src/kpasswdserver/CMakeLists.txt 21e5c2d17358b3d1233c753d15284cdc790423e0 src/kpac/proxyscout.cpp 375f77503272e700929433c44086f4e213502c6e src/kpac/CMakeLists.txt 7e6ce1f6cdb992b2ce45ab895aea72df24955fe2 src/kioexec/main.cpp f0e282394c4f65df0bf52141290d37ba6b32ad8c src/ioslaves/http/kcookiejar/kcookieserver.cpp c441496dff316d4e94a4cccdfd46615cd76a7238 src/ioslaves/http/kcookiejar/CMakeLists.txt 890a35bcc24ca043844257f3d2cdd0941ddd1d17 Diff: https://git.reviewboard.kde.org/r/121317/diff/ Testing --- the converted modules can be loaded Thanks, Alex Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122590: Guard kglobalaccel against QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76686 --- Ping, Frameworks people? - Kai Uwe Broulik On Feb. 16, 2015, 12:25 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 16, 2015, 12:25 nachm.) Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Repository: kglobalaccel Description --- KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it. Diffs - src/kglobalaccel.h 4a5595f src/kglobalaccel.cpp df85547 src/kglobalaccel_p.h b1528dc Diff: https://git.reviewboard.kde.org/r/122590/diff/ Testing --- screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122590: Guard kglobalaccel against QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76687 --- src/kglobalaccel.h https://git.reviewboard.kde.org/r/122590/#comment52819 from https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ You cannot: Remove a virtual function, even if it is a reimplementation of a virtual function from the base class -- you can make it do nothing though. - David Edmundson On Feb. 16, 2015, 12:25 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 16, 2015, 12:25 p.m.) Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Repository: kglobalaccel Description --- KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it. Diffs - src/kglobalaccel.h 4a5595f src/kglobalaccel.cpp df85547 src/kglobalaccel_p.h b1528dc Diff: https://git.reviewboard.kde.org/r/122590/diff/ Testing --- screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122590: Guard kglobalaccel against QApplication
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/ --- (Updated Feb. 26, 2015, 9:39 nachm.) Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Changes --- Add back eventFilter method for BC but let it do nothing Repository: kglobalaccel Description --- KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it. Diffs (updated) - src/kglobalaccel.h 4a5595f src/kglobalaccel.cpp d123af4 src/kglobalaccel_p.h b1528dc Diff: https://git.reviewboard.kde.org/r/122590/diff/ Testing --- screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
El Dijous, 26 de febrer de 2015, a les 16:55:17, Martin Klapetek va escriure: On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. There, I fixed it. https://git.reviewboard.kde.org/r/122729/ Cheers So we still need a KPeople release, which is still in playground so noone has properly reviewed it, and you want to speed-turn it into a frameworks in 1 day. Do you actually have anyone to review it in such notice? At least sanitize the headers? This feels like rush, rush and rush. KDE Applications schedule has been set for months, I've sent various reminders about the freeze dates, and yet, here we are, post freeze with unresolved issues, why are we doing this now and not last week? Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
