Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77675 --- src/org.kde.JobViewV3.xml

Re: Review Request 122937: Preserve translation domain when merging KXmlGui files

2015-03-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122937/#review77663 --- Ship it! Ship It! - David Faure On March 14, 2015, 11:46

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77674 --- Bump - David Rosca On March 15, 2015, 4:56 p.m., David

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really a

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really a

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really a

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Aleix Pol Gonzalez
On March 17, 2015, 4:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- (Updated March 18, 2015, 1:07 p.m.) Review request for KDE Frameworks

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really a

Re: Review Request 122937: Preserve translation domain when merging KXmlGui files

2015-03-18 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122937/ --- (Updated March 18, 2015, 12:30 p.m.) Status -- This change has been

Re: Review Request 123034: [Plasma-framework] Search for KF5Service in cmake config

2015-03-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123034/#review77692 --- Ship it! Ship It! - Marco Martin On March 18, 2015, 5:34

Re: Review Request 120393: [kdelibs4support] Kill dead code

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:24 p.m.) Review request for KDE Frameworks,

Re: Review Request 123032: Search for public dep in KPeople's cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/ --- (Updated March 18, 2015, 7:30 p.m.) Review request for KDE Frameworks

Review Request 123030: Let KHtml be useable w/o searching for private deps

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123030/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Review Request 123034: [Plasma-framework] Search for KF5Service in cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123034/ --- Review request for KDE Frameworks and Marco Martin. Repository:

Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 122313: Expose to world whether KPty has been built with utempter library

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122313/#review77694 --- ping - Hrvoje Senjan On Jan. 29, 2015, 7:54 p.m., Hrvoje

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/#review77698 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 5, 2015,

Review Request 123032: Search for public dep in KPeople's cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 123033: [KPackage] Search for KF5CoreAddons in cmake config

2015-03-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123033/#review77691 --- Ship it! Ship It! - Marco Martin On March 18, 2015, 5:34

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/#review77693 --- ping - Hrvoje Senjan On March 5, 2015, 8:41 p.m., Hrvoje

Re: Review Request 123032: Search for public dep in KPeople's cmake config

2015-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/#review77696 --- You can use KPeople without Qt5Widgets, I don't think this is

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Christophe Giboudeaux
On March 18, 2015, 7:40 p.m., Christophe Giboudeaux wrote: KF5KrossConfig.cmake.in, line 9 https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9 Are you sure ? ./ui/actioncollectionview.h:27:#include QWidget Hrvoje Senjan wrote: this is

Re: Review Request 122828: Be more explicit regarding KBookmarks deps

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122828/ --- (Updated March 18, 2015, 8:36 p.m.) Status -- This change has been

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Hrvoje Senjan
On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote: KF5KrossConfig.cmake.in, line 9 https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9 Are you sure ? ./ui/actioncollectionview.h:27:#include QWidget Hrvoje Senjan wrote: this is

Re: Review Request 120393: [kdelibs4support] Kill dead code

2015-03-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/#review77714 --- I'm all for getting rid of the Nepomuk code. However, I'm not

Jenkins build is back to normal : ktexteditor_stable_qt5 #57

2015-03-18 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_stable_qt5/57/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : ktexteditor_master_qt5 #786

2015-03-18 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/786/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122206: [kio] Make tests optional

2015-03-18 Thread Ben Cooksley
On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Review Request 123033: [KPackage] Search for KF5CoreAddons in cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123033/ --- Review request for KDE Frameworks and Marco Martin. Repository: kpackage

Re: Review Request 120393: [kdelibs4support] Kill dead code

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- (Updated March 18, 2015, 7:17 p.m.) Review request for KDE Frameworks,

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/#review77700 --- KF5KrossConfig.cmake.in

Build failed in Jenkins: ktexteditor_master_qt5 #785

2015-03-18 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/785/changes Changes: [mikisabate] vimode: handle the nop mapping properly. -- [...truncated 1194 lines...] Generating moc_bug313759.cpp Generating moc_testutils.cpp Scanning dependencies of target

Build failed in Jenkins: ktexteditor_stable_qt5 #56

2015-03-18 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_stable_qt5/56/changes Changes: [mikisabate] vimode: handle the nop mapping properly. -- [...truncated 1203 lines...] Generating moc_script_test_base.cpp Generating moc_testutils.cpp Generating moc_bug317111.cpp

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Hrvoje Senjan
On March 18, 2015, 8:40 p.m., Christophe Giboudeaux wrote: KF5KrossConfig.cmake.in, line 9 https://git.reviewboard.kde.org/r/123031/diff/1/?file=355503#file355503line9 Are you sure ? ./ui/actioncollectionview.h:27:#include QWidget this is now similar (reverse) as with

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123031/ --- (Updated March 18, 2015, 9:13 p.m.) Review request for KDE Frameworks.

Re: Review Request 123034: [Plasma-framework] Search for KF5Service in cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123034/ --- (Updated March 18, 2015, 8:28 p.m.) Status -- This change has been

Re: Review Request 123033: [KPackage] Search for KF5CoreAddons in cmake config

2015-03-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123033/ --- (Updated March 18, 2015, 8:26 p.m.) Status -- This change has been