Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Laurent Montel
> On mars 31, 2015, 5:07 matin, Laurent Montel wrote: > > Yes but your review doesn't fix bug no ? > > You add more debug but it doesn't fix bug no ? > > For me it's better that you create a review about a fix not just add debug > > and wait that it will fix no ? > > Gregor Mi wrote: > Hi L

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Gregor Mi
> On March 31, 2015, 5:07 a.m., Laurent Montel wrote: > > Yes but your review doesn't fix bug no ? > > You add more debug but it doesn't fix bug no ? > > For me it's better that you create a review about a fix not just add debug > > and wait that it will fix no ? Hi Laurent, sorry for the confu

Re: libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Albert Astals Cid
El Dimarts, 31 de març de 2015, a les 22:32:10, Jan Grulich va escriure: > On Tuesday 31 of March 2015 21:55 Albert Astals Cid wrote: > > El Dimarts, 31 de març de 2015, a les 13:15:30, Jan Grulich va escriure: > > > Hi, > > > > > > we have finally moved libmm-qt library to frameworks and renamed

Re: libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Jan Grulich
On Tuesday 31 of March 2015 21:55 Albert Astals Cid wrote: > El Dimarts, 31 de març de 2015, a les 13:15:30, Jan Grulich va escriure: > > Hi, > > > > we have finally moved libmm-qt library to frameworks and renamed it to > > modemmanager-qt. It's now going to be released together with KDE > > Fram

Re: libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Albert Astals Cid
El Dimarts, 31 de març de 2015, a les 13:15:30, Jan Grulich va escriure: > Hi, > > we have finally moved libmm-qt library to frameworks and renamed it to > modemmanager-qt. It's now going to be released together with KDE Frameworks > 5 and not with Plasma 5 as it was until now. The upcoming releas

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-03-31 Thread Alex Merry
On Tuesday 31 March 2015 20:29:25 Alex Merry wrote: > On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > > Problem tldr: target A links library B, A doesn't get the includes of > > link libraries of B by default. e.g. A links B, B links karchive, A > > doesn't have access to the karchive hea

Re: cmake CMP0028 & missing targets - what does one do about it?

2015-03-31 Thread Alex Merry
On Thursday 19 March 2015 14:16:35 Harald Sitter wrote: > Problem tldr: target A links library B, A doesn't get the includes of > link libraries of B by default. e.g. A links B, B links karchive, A > doesn't have access to the karchive headers. also if karchive wasn't > found in a super-scope of A

Re: libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Jan Grulich
It should compile, just because we don't use Qt5 signals/slot syntax everywhere, but some signals won't work because they have changed it's signature and it would make plasma-nm to not update ModemManager properties like signal strength. Jan On Tuesday 31 of March 2015 12:23 Jonathan Riddell w

Re: libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Jonathan Riddell
Congratulations Would a recompile do or is the source incompatible with Plasmaßnm 5.2.2 Jonathan On Tue, Mar 31, 2015 at 01:15:30PM +0200, Jan Grulich wrote: > Hi, > > we have finally moved libmm-qt library to frameworks and renamed it to > modemmanager-qt. It's now going to be released toge

libmm-qt moved to frameworks/modemmanager-qt

2015-03-31 Thread Jan Grulich
Hi, we have finally moved libmm-qt library to frameworks and renamed it to modemmanager-qt. It's now going to be released together with KDE Frameworks 5 and not with Plasma 5 as it was until now. The upcoming release is not ABI/API compatible with the previous releases, so if you are going to k