Re: KDateTimeEdit is broken (but unused)

2015-04-19 Thread Christoph Feck
On Saturday 18 April 2015 23:21:59 David Faure wrote: In a KDateTimeEdit, changing the date in the date combo (whether by typing or selecting e.g. next month in the popupmenu), does NOT change the value of date(), which uses its own member variable, unaffected by user interaction. [...] This

Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-19 Thread Simeon Bird
On April 19, 2015, 4:27 a.m., Simeon Bird wrote: Hi everyone, Sorry to bother you, but may I please commit this? It's been a while. The kdelibs version had some positive reviews. Thanks, Simeon Albert Astals Cid wrote: Any reason why we should not fix this in kdelibs

Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-19 Thread Simeon Bird
On April 19, 2015, 4:27 a.m., Simeon Bird wrote: Hi everyone, Sorry to bother you, but may I please commit this? It's been a while. The kdelibs version had some positive reviews. Thanks, Simeon Albert Astals Cid wrote: Any reason why we should not fix this in kdelibs

Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-19 Thread Albert Astals Cid
On abr. 19, 2015, 4:27 a.m., Simeon Bird wrote: Hi everyone, Sorry to bother you, but may I please commit this? It's been a while. The kdelibs version had some positive reviews. Thanks, Simeon Albert Astals Cid wrote: Any reason why we should not fix this in kdelibs

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-19 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated April 19, 2015, 7:46 p.m.) Review request for KDE Frameworks

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-19 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341/ --- (Updated April 19, 2015, 7:49 p.m.) Review request for KDE Frameworks

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2015-04-19 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/ --- (Updated April 19, 2015, 7:20 p.m.) Status -- This change has been

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-19 Thread Andrius da Costa Ribas
On Nov. 10, 2014, 9:41 p.m., David Faure wrote: lib/konq/src/konq_historyentry.h, line 57 https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57 const ref, no? Andrius da Costa Ribas wrote: before I try to fix the pending issues: what are we going to

Review Request 123436: Add unit test for KIO::AccessManager

2015-04-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123436/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 123436: Add unit test for KIO::AccessManager

2015-04-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123436/ --- (Updated April 20, 2015, 3:12 a.m.) Review request for KDE Frameworks.

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79237 --- Approach looks correct to me, but can be simplified (see

Re: Review Request 123419: CodingStyle for autotests

2015-04-19 Thread Guy Maurel
On April 18, 2015, 10:04 p.m., David Faure wrote: Looks ok but it's strange to quote a wiki page called *kdepim*. This isn't kdepim. You are right. I continue the work I do for kdepim. Where should I put the informations? - Guy

Re: KDateTimeEdit is broken (but unused)

2015-04-19 Thread David Faure
On Sunday 19 April 2015 09:54:14 Christoph Feck wrote: On Saturday 18 April 2015 23:21:59 David Faure wrote: In a KDateTimeEdit, changing the date in the date combo (whether by typing or selecting e.g. next month in the popupmenu), does NOT change the value of date(), which uses its own

Re: Review Request 123419: CodingStyle for autotests

2015-04-19 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123419/ --- (Updated April 19, 2015, 2:52 p.m.) Status -- This change has been

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121079/ --- (Updated Abril 19, 2015, 3:13 p.m.) Status -- This change has been

Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas
On Fev. 12, 2015, 10:54 p.m., Albert Astals Cid wrote: Patch doesn't apply, please rebase superseded by RR https://git.reviewboard.kde.org/r/123270/, discarding this one. - Andrius da Costa --- This is an automatically generated

Re: Review Request 123419: CodingStyle for autotests

2015-04-19 Thread David Faure
On April 18, 2015, 8:04 p.m., David Faure wrote: Looks ok but it's strange to quote a wiki page called *kdepim*. This isn't kdepim. Guy Maurel wrote: You are right. I continue the work I do for kdepim. Where should I put the informations? rename the page to Scripts for

Re: Review Request 121599: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-19 Thread Albert Astals Cid
On abr. 19, 2015, 4:27 a.m., Simeon Bird wrote: Hi everyone, Sorry to bother you, but may I please commit this? It's been a while. The kdelibs version had some positive reviews. Thanks, Simeon Any reason why we should not fix this in kdelibs too? - Albert