Re: Review Request 123452: Expose KJob::capabilities property

2015-04-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123452/#review79421 --- Ship it! Ship It! - Kevin Funk On April 21, 2015, 4:24

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-24 Thread Milian Wolff
On April 23, 2015, 11:33 p.m., Alex Richardson wrote: src/lib/io/kdirwatch.cpp, line 303 https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303 Why this manual loop instead of strlen()? Does that mean that null characters in the middle are valid? Or, more

Re: Review Request 123479: Adapt to Qt 5.6 changes and prevent nullbytes in QStrings.

2015-04-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123479/ --- (Updated April 24, 2015, 12:06 p.m.) Status -- This change has been

Review Request 123490: Fix crash when using x11 functionality on platform wayland

2015-04-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123490/ --- Review request for KDE Frameworks. Bugs: 346496

kdepackages.h

2015-04-24 Thread Jonathan Riddell
kxmlgui has a file kdepackages.h which lists the products in bugzilla. This is used by the dialog in Help → Report Bug. It was horribly out of date so I've synced it with current bugzilla. David could you add to the release scripts to run make_kdepackages_updated.py in kxmlgui before release?

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Albert Astals Cid
On abr. 24, 2015, 3:36 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, lines 178-180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178 I think there should be an argument that could be passed to disable this (NO_TESTS?). Not all downstream

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Aleix Pol Gonzalez
On April 24, 2015, 8:47 p.m., Matthew Dawson wrote: autotests/kconfig_compiler/test13.cpp.ref, line 33 https://git.reviewboard.kde.org/r/123367/diff/7-8/?file=362762#file362762line33 Is there a reason this got moved back? Well, Modified needs to be called together with Changed,

Re: Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/#review79480 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123493: Fix leaky incubation controller

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/#review79481 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015,

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Albert Astals Cid
On abr. 24, 2015, 3:21 p.m., Kevin Funk wrote: Hm, this could cause problems in the case where you generate multiple .pri files which depend on each other within one project. Problem .pri files are not yet installed, thus the QT modules are not yet available. I suggest trying this

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
On April 24, 2015, 3:49 p.m., Kevin Funk wrote: modules/ECMGeneratePriFile.cmake, line 180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180 Just tested the patch myself on sonnet. The test indeed breaks if sonnet is not installed

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79451 --- Cool stuff! :) Maybe you can add some documentation

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79450 --- autotests/kconfig_compiler/test13.cpp.ref (line 18)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79460 --- modules/ECMGeneratePriFile.cmake (line 179)

Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 25, 2015, 3:39 a.m.) Review request for KDE Frameworks

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79483 --- Ok, I think this should be last set of comments. One thing I

Review Request 123492: Fix memory leak in AppletQuickItem

2015-04-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Alex Merry
On April 24, 2015, 3:36 p.m., Alex Merry wrote: modules/ECMGeneratePriFile.cmake, lines 178-180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178 I think there should be an argument that could be passed to disable this (NO_TESTS?). Not all downstream

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Albert Astals Cid
On abr. 24, 2015, 3:49 p.m., Kevin Funk wrote: modules/ECMGeneratePriFile.cmake, line 180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180 Just tested the patch myself on sonnet. The test indeed breaks if sonnet is not installed beforehand.

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 24, 2015, 6:56 p.m.) Review request for KDE Frameworks

Review Request 123493: Fix leaky incubation controller

2015-04-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/#review79452 --- Ship it! modules/ECMGeneratePriFile.cmake (line 174)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- (Updated abr. 24, 2015, 3:26 p.m.) Review request for Extra Cmake

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-24 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79473 --- Looks good, one last comment: