Re: Versioning of Frameworks

2015-04-29 Thread Christian Mollekopf
On Wed, Apr 29, 2015, at 11:03 AM, Martin Gräßlin wrote: On Wednesday 29 April 2015 09:35:12 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 12:11 AM, Aleix Pol wrote: On Tue, Apr 28, 2015 at 12:17 PM, Christian Mollekopf chrig...@fastmail.fm wrote: Hi Christian, I

Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 10:51 a.m.) Review request for KDE Frameworks

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-29 Thread Jan Grulich
On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote: It worked here, so it's a +1 from me. I just would like the extra-cmake-module maintainer to give the final ship it. Jan Grulich wrote: Hmm, I realized that this would break backward compatibility with plasma-nm, because in

Re: Versioning of Frameworks

2015-04-29 Thread Christian Mollekopf
On Wed, Apr 29, 2015, at 12:11 AM, Aleix Pol wrote: On Tue, Apr 28, 2015 at 12:17 PM, Christian Mollekopf chrig...@fastmail.fm wrote: Hi Christian, I understand your needs, I've seen similar complaints before. Letting frameworks depend on different versions could make sense, but I

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123542/ --- (Updated April 29, 2015, 8:23 a.m.) Review request for KDE Frameworks

Re: Review Request 123532: Add find modules for ModemManager and NetworkManager

2015-04-29 Thread Jan Grulich
On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote: It worked here, so it's a +1 from me. I just would like the extra-cmake-module maintainer to give the final ship it. Hmm, I realized that this would break backward compatibility with plasma-nm, because in plasma-nm we use

Re: Re: Versioning of Frameworks

2015-04-29 Thread Martin Gräßlin
On Wednesday 29 April 2015 09:35:12 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 12:11 AM, Aleix Pol wrote: On Tue, Apr 28, 2015 at 12:17 PM, Christian Mollekopf chrig...@fastmail.fm wrote: Hi Christian, I understand your needs, I've seen similar complaints before.

Re: Review Request 123542: [runtime] Move platform specific code into plugins

2015-04-29 Thread Martin Gräßlin
On April 28, 2015, 7:31 p.m., Alex Richardson wrote: src/runtime/globalshortcutsregistry.cpp, line 40 https://git.reviewboard.kde.org/r/123542/diff/1/?file=364188#file364188line40 You could use `KPluginLoader::forEachPlugin(org.kde.kglobalaccel5.platforms, [](const QString

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79667 --- Ship it! Ship It! src/kpackage/packageloader.h (line 59)

Re: Versioning of Frameworks

2015-04-29 Thread Christian Mollekopf
On Wed, Apr 29, 2015, at 01:29 PM, Martin Gräßlin wrote: On Wednesday 29 April 2015 12:19:18 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 11:03 AM, Martin Gräßlin wrote: On Wednesday 29 April 2015 09:35:12 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 12:11 AM, Aleix Pol

Re: Re: Versioning of Frameworks

2015-04-29 Thread Martin Gräßlin
On Wednesday 29 April 2015 12:19:18 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 11:03 AM, Martin Gräßlin wrote: On Wednesday 29 April 2015 09:35:12 Christian Mollekopf wrote: On Wed, Apr 29, 2015, at 12:11 AM, Aleix Pol wrote: On Tue, Apr 28, 2015 at 12:17 PM, Christian Mollekopf

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/ --- (Updated April 29, 2015, 12:12 p.m.) Status -- This change has been

Re: Versioning of Frameworks

2015-04-29 Thread Kevin Funk
On Tuesday, April 28, 2015 12:17:00 Christian Mollekopf wrote: Hey, For the Kolab Groupware Server we use some KDE libraries on the server. Servers being what they are, the libraries we require are often not available by default because the systems are too old, and we end-up backporting

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-29 Thread Kevin Funk
On April 24, 2015, 3:49 p.m., Kevin Funk wrote: modules/ECMGeneratePriFile.cmake, line 180 https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180 Just tested the patch myself on sonnet. The test indeed breaks if sonnet is not installed

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ --- (Updated April 29, 2015, 6:28 p.m.) Review request for KDE Frameworks

Re: Versioning of Frameworks

2015-04-29 Thread David Faure
On Wednesday 29 April 2015 15:00:32 Christian Mollekopf wrote: You don't have to maintain any other combinations that what you already do. Just because the cmake versions aren't automatically bumped doesn't mean you suddenly have to test every conceivable combination of versions. How can the

Re: Cannot debug ioslaves

2015-04-29 Thread David Faure
On Wednesday 29 April 2015 15:21:58 Aleix Pol wrote: Hi, I was looking into a problem, and ended up in this web page: https://techbase.kde.org/Development/Tutorials/Debugging/Debugging_IOSlaves After some greps, I realized most of it is gone. Anybody knows what's up with this? And if

Re: Versioning of Frameworks

2015-04-29 Thread David Faure
On Wednesday 29 April 2015 11:24:48 Kevin Funk wrote: Use-case: Potential contributor working on KDevelop: - Has KF5 installed from distro packages - KDevelop/KDevPlatform compiled from Git - There's a bug in ktexteditor (tier 3) - Likes to checkout just ktexteditor, fix the issue, compile,

Re: Versioning of Frameworks

2015-04-29 Thread Jeremy Whiting
Christian, David isn't the only one with these thoughts. I agree with everything he said, and was thinking about the dependency zoo also, but couldn't form the words until I read what he wrote. That's exactly what I was thinking. It would be like the old rpm dependency hell from early linux days

Re: Versioning of Frameworks

2015-04-29 Thread David Faure
On Tuesday 28 April 2015 12:17:00 Christian Mollekopf wrote: Our dependency tree is now indeed reduced, but if we want to update a single library, we are forced to update all libraries, due to the version-lock caused by periodic bumping of dependencies. You say at the end of the mail that you

Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-29 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123556/#review79698 --- src/kpackage/packageloader.cpp (line 273)

Re: Review Request 123491: Add a test that checks the modules we're depending on exist

2015-04-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123491/ --- (Updated abr. 29, 2015, 11:23 p.m.) Status -- This change has been

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/#review79704 --- autotests/accessmanagertest.cpp (line 79)

Re: Cannot debug ioslaves

2015-04-29 Thread Aleix Pol
On Wed, Apr 29, 2015 at 9:33 PM, David Faure fa...@kde.org wrote: On Wednesday 29 April 2015 15:21:58 Aleix Pol wrote: Hi, I was looking into a problem, and ended up in this web page: https://techbase.kde.org/Development/Tutorials/Debugging/Debugging_IOSlaves After some greps, I realized

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ --- (Updated April 30, 2015, 2:08 a.m.) Review request for KDE Frameworks

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

2015-04-29 Thread Aleix Pol Gonzalez
On April 30, 2015, 1:53 a.m., Mark Gaiser wrote: autotests/accessmanagertest.cpp, line 82 https://git.reviewboard.kde.org/r/123514/diff/2/?file=364611#file364611line82 The / should be a QDir::separator, no? Nope. Qt decodes the / accordingly. http://doc.qt.io/qt-5.4/qdir.html Qt

Re: Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567/#review79686 --- shouldn't something like this be provided by the

Cannot debug ioslaves

2015-04-29 Thread Aleix Pol
Hi, I was looking into a problem, and ended up in this web page: https://techbase.kde.org/Development/Tutorials/Debugging/Debugging_IOSlaves After some greps, I realized most of it is gone. Anybody knows what's up with this? And if there's anything we can do to debug an ioslave, anyway? Cheers!

Re: Review Request 123525: Remove bookmarks syncing from KFilePlacesModel and use user-places.xbel only.

2015-04-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123525/ --- (Updated April 29, 2015, 1:38 p.m.) Status -- This change has been

Re: Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Milian Wolff
On April 29, 2015, 1:55 p.m., Milian Wolff wrote: shouldn't something like this be provided by the distribution? doesn't make much sense to have it on non-arch systems, no? Anthony Vital wrote: I don't know but there are search providers for debian and opensuse already. ah ok,

Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 123523: KPropertiesDialog::KPropertiesDialog(urls) and KPropertiesDialog::showDialog(urls)

2015-04-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123523/ --- (Updated April 29, 2015, 1:38 p.m.) Status -- This change has been

Re: Review Request 123567: Add an Arch Linux package search provider

2015-04-29 Thread Anthony Vital
On avr. 29, 2015, 1:55 après-midi, Milian Wolff wrote: shouldn't something like this be provided by the distribution? doesn't make much sense to have it on non-arch systems, no? I don't know but there are search providers for debian and opensuse already. - Anthony