Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80228 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 11, 2015, 6:

Re: Review Request 123706: Add session management for KMainWindow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 8:38 p.m.) Status -- This change has been mar

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 8:37 p.m.) Status -- This change has been mar

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/#review80225 --- +1 - Mark Gaiser On mei 11, 2015, 4:55 p.m., Michael Palima

Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Descr

Kross module loading is broken since KF5.0.0

Hello, It all started this morning when I wanted to translate some Kwave in Lokalize... Long story short, while porting Kross from kdelibs4 into a KF5 framework there was a commit [1] that broke module loading. I'll tell you why it broke module loading. The commit was about naming of libraries/p

Re: Versioning of Frameworks

On Mon, May 11, 2015, at 02:42 PM, David Faure wrote: > On Monday 11 May 2015 11:57:02 Christian Mollekopf wrote: > > But that doesn't necessarily mean they can't be part of the same > > distribution mechanism. > > If you simply take a snapshot of all frameworks every month, then it > > shouldn'

Re: Versioning of Frameworks

On Monday 11 May 2015 11:57:02 Christian Mollekopf wrote: > But that doesn't necessarily mean they can't be part of the same > distribution mechanism. > If you simply take a snapshot of all frameworks every month, then it > shouldn't matter if > they changed or not. If no change has been made, th

Re: Review Request 123720: Fix autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/ --- (Updated May 11, 2015, 12:36 p.m.) Status -- This change has been ma

Re: Review Request 123720: Fix autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/#review80217 --- Ship it! Ship It! - David Faure On May 11, 2015, 7:58 a.m.

Re: Review Request 123706: Add session management for KMainWindow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80218 --- Ship it! Ship It! - David Faure On May 11, 2015, 8:20 a.m.

Re: Review Request 123720: Fix autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/#review80216 --- Ship it! Ship It! - David Edmundson On May 11, 2015, 7:58

Re: Versioning of Frameworks

On Mon, May 11, 2015, at 12:31 AM, David Faure wrote: > On Monday 11 May 2015 00:13:27 Christian Mollekopf wrote: > > > Are you volunteering, or just making demands for others to do work for > > > you? > > > > I'm volunteering to do the maintenance and release engineering for the > > libraries

Re: changelog for 5.10

On Monday, May 11, 2015 00:48:37 David Faure wrote: > On Saturday 09 May 2015 13:00:54 Sebastian Kügler wrote: > > On Saturday, May 09, 2015 13:06:57 David Faure wrote: > > > On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: > > > > > > For the notification aspect of it, I think. > > > The

Re: Review Request 123706: Add session management for KMainWindow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 8:20 a.m.) Review request for KDE Frameworks and R

Re: Review Request 123595: Relax KUser test to allow for a "nogroup" group.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123595/ --- (Updated May 11, 2015, 8:02 a.m.) Review request for KDE Frameworks and M

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80203 --- Ship it! Ship It! - David Faure On May 11, 2015, 7:56 a.m.

Review Request 123720: Fix autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123720/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 123706: Add session management for KMainWindow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80202 --- Ship it! src/kmainwindow.cpp (line 154)

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 7:56 a.m.) Review request for KDE Frameworks and R

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80201 --- Ship it! Good solution, I like it! - David Faure On May 11

Re: Review Request 123707: Set session manager discard command

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 11, 2015, 7:52 a.m.) Status -- This change has been dis

Re: Review Request 123706: Add session management for KMainWindow

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 11, 2015, 7:52 a.m.) Review request for KDE Frameworks and R

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 11, 2015, 7:50 a.m.) Review request for KDE Frameworks and R

Re: Review Request 123707: Set session manager discard command

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80198 --- isLocalFile() makes everyone think of QUrl::isLocalFile(), i.e

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

> On May 10, 2015, 10:43 p.m., David Faure wrote: > > src/core/kfileitem.cpp, line 1115 > > > > > > I had the same thought as Milian... but I wonder why I wrote that > > comment. m_strText is the displayName, m