On May 21, 2015, 1:31 p.m., Milian Wolff wrote:
src/klocalizedstring.cpp, line 23
https://git.reviewboard.kde.org/r/123867/diff/1/?file=370328#file370328line23
shouldn't this be
#include cmath
Bhushan Shah wrote:
ah yeah.
meh; didn't fix it..
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/#review80680
---
Ship it!
Ship It!
src/klocalizedstring.cpp (line 23)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123867/
---
(Updated May 21, 2015, 8:19 a.m.)
Status
--
This change has been
On May 21, 2015, 1:31 p.m., Milian Wolff wrote:
src/klocalizedstring.cpp, line 23
https://git.reviewboard.kde.org/r/123867/diff/1/?file=370328#file370328line23
shouldn't this be
#include cmath
ah yeah.
- Bhushan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123857/
---
(Updated May 21, 2015, 11:36 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 21, 2015, 10:52 a.m.)
Review request for KDE Frameworks and
Hi,
The current ki18n/docs/programmers-guide.md says that a
TranslationDomain field in .kcfgc file can be used to set the
translation domain. But in fact, KConfig's kconfig_compiler_kf5 does
not read that field.
Is there a plan to revive support for TranslationDomain in
kconfig_compiler_kf5, or
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/
---
Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review80698
---
LGTM in general, but could you please add/update a unit test
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/#review80695
---
Ship it!
Awesome. I love the test!
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
---
(Updated May 21, 2015, 4:02 p.m.)
Review request for KDE Frameworks and
11 matches
Mail list logo