Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

2015-05-22 Thread Chusslove Illich
On Мај 21, 2015, 5:29 по п., Matthew Dawson wrote: LGTM in general, but could you please add/update a unit test to test all the possible cominbations of the translation? That would make the test depend on the Ki18n framework, which is not acceptable for tier 1 frameworks. Alternatively,

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

2015-05-22 Thread Matthew Dawson
On May 21, 2015, 11:29 a.m., Matthew Dawson wrote: LGTM in general, but could you please add/update a unit test to test all the possible cominbations of the translation? Chusslove Illich wrote: That would make the test depend on the Ki18n framework, which is not acceptable for