Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81225 --- LGTM Thanks! It's also used by the wallpaper config. I guess

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread David Edmundson
On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: src/qmlcontrols/kquickcontrols/ColorButton.qml, line 54 https://git.reviewboard.kde.org/r/124014/diff/1/?file=378857#file378857line54 You probably want to add an alias for the showAlphaChannel, title, and currentColor

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 9 - Still Failing!

2015-06-05 Thread no-reply
Check console output at https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/9/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread David Edmundson
On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: LGTM Thanks! It's also used by the wallpaper config. I guess the IconButton used by Kickoff and folderview could also be moved to KQC I guess the IconButton used by Kickoff and folderview could also be moved to KQC Yes please.

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 8 - Fixed!

2015-06-05 Thread no-reply
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread David Edmundson
On June 5, 2015, 11:12 a.m., Kai Uwe Broulik wrote: src/qmlcontrols/kquickcontrols/ColorButton.qml, line 54 https://git.reviewboard.kde.org/r/124014/diff/1/?file=378857#file378857line54 You probably want to add an alias for the showAlphaChannel, title, and currentColor

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » OSX,clang - Build # 14 - Still Failing!

2015-06-05 Thread no-reply
Check console output at https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/14/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Milian Wolff
Hey all, as the subject says - how should KGlobalSettings::fixedFont and the like be ported? QFont(monospace)? Thanks -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___

Re: How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Christoph Cullmann
Hi, http://doc.qt.io/qt-5/qfontdatabase.html#SystemFont-enum QFont QFontDatabase::systemFont(SystemFont type) or? - Ursprüngliche Mail - Hey all, as the subject says - how should KGlobalSettings::fixedFont and the like be ported? QFont(monospace)? Thanks -- Milian Wolff

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review81233 --- for qstyle based stuff we are depending on the qt

Re: How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Milian Wolff
On Friday 05 June 2015 17:50:05 Christoph Cullmann wrote: Hi, http://doc.qt.io/qt-5/qfontdatabase.html#SystemFont-enum QFont QFontDatabase::systemFont(SystemFont type) Sounds good, thanks! Hey all, as the subject says - how should KGlobalSettings::fixedFont and the like be

Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » OSX,clang - Build # 4 - Fixed!

2015-06-05 Thread no-reply
We thank you for fixing your build!___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
On May 7, 2015, 7:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » OSX,NoX11,clang - Build # 9 - Still Failing!

2015-06-05 Thread no-reply
Check console output at https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=OSX,Variation=NoX11,compiler=clang/9/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/ --- (Updated June 6, 2015, 4:59 a.m.) Status -- This change has been

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123669/#review81254 --- Ship it! Ship It! - Marco Martin On May 6, 2015, 11:21