Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review81662 --- Rohan, can you test it on the offended platform? (compile and

Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/ --- Review request for KDE Frameworks and Rohan Garg. Repository:

Re: Review Request 124066: Recognize X-KDE-FormFactor as stringlist

2015-06-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/#review81661 --- ping. - Sebastian Kügler On June 17, 2015, 11 p.m.,

Re: Future frameworks releases

2015-06-22 Thread Albert Astals Cid
El Diumenge, 14 de juny de 2015, a les 20:53:51, Alexander Potashev va escriure: 2015-06-11 21:20 GMT+03:00 Sebastian Kügler se...@kde.org: Introducing exceptions increases the complexity of dealing with frameworks, their value really is in shared processes and requirements. I am

Re: KCoreaddons build failiure on ARM

2015-06-22 Thread David Faure
On Sunday 21 June 2015 15:04:58 Michael Pyne wrote: On Fri, June 19, 2015 20:40:39 Rohan Garg wrote: Hi I'm trying to compile kcoreaddons on ARM with clang and I'm hitting this build failiure : 06:22:27 ../../../src/lib/io/kfilesystemtype.cpp:112:10: error: case value evaluates to

Re: KCoreaddons build failiure on ARM

2015-06-22 Thread Alexander Potashev
2015-06-22 13:18 GMT+03:00 David Faure fa...@kde.org: I don't follow. How does 0x858458F6 not fit into an int, even on a 32 bit machine? OK, this is just about signed/unsigned, not about really wider. So yeah the bug is that glibc should use unsigned int there instead, but the issue you

Re: KCoreaddons build failiure on ARM

2015-06-22 Thread Michael Pyne
On Mon, June 22, 2015 12:18:27 David Faure wrote: On Sunday 21 June 2015 15:04:58 Michael Pyne wrote: On Fri, June 19, 2015 20:40:39 Rohan Garg wrote: Hi I'm trying to compile kcoreaddons on ARM with clang and I'm hitting this build failiure : 06:22:27

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

2015-06-22 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review81689 --- Ship it! I'd prefer `unsigned long` to `unsigned long int`

Re: Review Request 124138: Install kconfig_compiler into libexec

2015-06-22 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/#review81690 --- Ship it! Ship It! - Harald Sitter On June 21, 2015, 4:15

Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

2015-06-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123872/ --- (Updated June 22, 2015, 1:13 p.m.) Status -- This change has been