---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124147/
---
(Updated July 7, 2015, 8:29 a.m.)
Review request for KDE Frameworks.
On July 2, 2015, 9:47 a.m., David Faure wrote:
src/ioslaves/http/kcookiejar/kcookieserver.cpp, line 68
https://git.reviewboard.kde.org/r/124147/diff/2/?file=380949#file380949line68
This would be worth a qWarning too.
And then I would still return a non-null string, so
On July 2, 2015, 9:47 a.m., David Faure wrote:
src/ioslaves/http/kcookiejar/kcookieserver.cpp, line 68
https://git.reviewboard.kde.org/r/124147/diff/2/?file=380949#file380949line68
This would be worth a qWarning too.
And then I would still return a non-null string, so
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/#review82195
---
src/knotificationmanager.cpp (line 87)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82192
---
src/plugins/voikko/voikkoclient.cpp (line 28)
On July 7, 2015, 5:10 p.m., Alex Richardson wrote:
src/knotificationmanager.cpp, line 89
https://git.reviewboard.kde.org/r/124281/diff/2/?file=383580#file383580line89
Use `KPluginLoader::findPlugins` or `KPluginLoader::instantiatePlugins`
and then do the qobject_cast to avoid
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/
---
(Updated July 7, 2015, 9 p.m.)
Review request for KDE Frameworks and
On July 7, 2015, 7:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
src/plugins/voikko/voikkodict.cpp, line 125
https://git.reviewboard.kde.org/r/124282/diff/3/?file=383592#file383592line125
if (replacements.contains(word)) {
suggestions.append(word);
}
On July 7, 2015, 9:38 p.m., Mark Gaiser wrote:
src/knotificationmanager.cpp, line 89
https://git.reviewboard.kde.org/r/124281/diff/3/?file=383605#file383605line89
Don't you have a memory leak here?
You have a list of pointers which you own here, but QList doesn't know
that.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/#review82179
---
Looks good to me otherwise
src/knotificationmanager.cpp
On July 7, 2015, 9:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
src/plugins/voikko/voikkoclient.cpp, line 32
https://git.reviewboard.kde.org/r/124282/diff/3/?file=383588#file383588line32
I prefer to error out early («if (!dictionaries) return;»), less
indentation and state
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124220/#review82168
---
Seems kwindowsystem master doesn't build now (against Qt 5.5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/
---
Review request for KDE Frameworks and Martin Gräßlin.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124212/
---
(Updated July 7, 2015, 11:31 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124220/
---
(Updated July 7, 2015, 11:31 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124222/
---
(Updated July 7, 2015, 11:34 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124266/
---
(Updated July 7, 2015, 11:35 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124133/
---
(Updated July 7, 2015, 11:26 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/#review82175
---
I like it!
- Martin Gräßlin
On July 7, 2015, 2:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 7, 2015, 2 ip)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/#review82174
---
src/plugins/voikko/voikkoclient.h (line 37)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
On July 7, 2015, 2:16 p.m., Hrvoje Senjan wrote:
Seems kwindowsystem master doesn't build now (against Qt 5.5 at least):
```
[ 55s] In file included from
/home/abuild/rpmbuild/BUILD/kwindowsystem-5.12.0git.20150707T133122~569a723/src/kwindowinfo.cpp:21:0:
[ 55s]
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/#review82172
---
src/knotificationmanager.cpp (line 87)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124282/
---
(Updated heinä 7, 2015, 2:44 ip)
Review request for KDE Frameworks and
On July 7, 2015, 3:56 p.m., Aleix Pol Gonzalez wrote:
src/knotificationmanager.cpp, line 89
https://git.reviewboard.kde.org/r/124281/diff/1/?file=383552#file383552line89
Would it make any sense to remove this altogether?
If nobody is using it, it sounds useless.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124281/
---
(Updated July 7, 2015, 4:42 p.m.)
Review request for KDE Frameworks and
On heinä 7, 2015, 2:11 ip, Aleix Pol Gonzalez wrote:
src/plugins/voikko/voikkodict.cpp, line 261
https://git.reviewboard.kde.org/r/124282/diff/1/?file=383564#file383564line261
qCDebug(SONNET_VOIKKO) Loaded words.size() replacements
from the user dictionary.;
Same
28 matches
Mail list logo
