Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

2015-07-19 Thread Alexander Potashev
> On Июль 19, 2015, 10:26 п.п., Aleix Pol Gonzalez wrote: > > Are you sure this is correct? > > > > It should be: install(TARGETS ${plugin} DESTINATION > > ${PLUGIN_INSTALL_DIR}/kross) and then have kross only looking into that > > directory. Good idea, but we'll need to extend the list of se

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

2015-07-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124398/#review82672 --- Are you sure this is correct? It should be: install(TARGETS $

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

2015-07-19 Thread Alexander Potashev
> On Июль 19, 2015, 8:52 п.п., Albert Astals Cid wrote: > > Does this break co-installability with kdelibs4 based kross-plugins? No, it doesn't, unless it was broken already in some distributions. Given the distro uses separate installation paths for Qt5 and Qt4, the these plugins will go into

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
> On Juli 19, 2015, 7:59 nachm., Kai Uwe Broulik wrote: > > +1 from my side > > > > Looking really nice, I wonder why I didn't think of this earlier :) thanks :) I'll wait for your patches to land and then rebase/push :) - Bernhard ---

Re: Review Request 123031: Let Kross be useable w/o searching for private deps

2015-07-19 Thread Alexander Potashev
> On Июнь 14, 2015, 10:36 п.п., Alexander Potashev wrote: > > Please add "find_dependency(Qt5Core @REQUIRED_QT_VERSION@)" for > > completeness. > > > > Build of KrossUi currently cannot be disabled. If we wanted to aim server > > environments without QtWidgets, then we first need to make Kross

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

2015-07-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124398/#review82666 --- Does this break co-installability with kdelibs4 based kross-pl

Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

2015-07-19 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124398/ --- Review request for KDE Frameworks. Repository: kross Description --

Change in kio[master]: Add move semantics for UDSEntry. This also makes room for mo...

2015-07-19 Thread Mark Gaiser (Code Review)
Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/474 Change subject: Add move semantics for UDSEntry. This also makes room for more performance improvements. .. Add move semantics for UDSE

Change in kio[master]: Replace QVector with std::vector for Field storage. That ena...

2015-07-19 Thread Mark Gaiser (Code Review)
Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/475 Change subject: Replace QVector with std::vector for Field storage. That enables more efficient filling of fields via emplace_back and using move semantics where an rvalue was used. .

Change in kio[master]: Store the UDS field number in the Field struct. On x86 this ...

2015-07-19 Thread Mark Gaiser (Code Review)
Mark Gaiser has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/473 Change subject: Store the UDS field number in the Field struct. On x86 this is free because memory wasn't optimally used. Before: sizeof(Field) = 16 After: sizeof(Field) = 16

Re: Review Request 121861: Remove obsolate class KFileSystemWatcher, which is handled by Windows implementation of Qt5 QFileSystemWatcher.

2015-07-19 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121861/ --- (Updated July 19, 2015, 10:17 p.m.) Review request for KDE Frameworks.

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82663 --- +1 from my side Looking really nice, I wonder why I didn't th

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:06 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
> On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: > > Please include a screenshot for UI changes. > > > > Also please wait until Review 122488 is merged to save me another rebase > > headache. Of course :) I'll wait till your Review is merged. Just wanted to get some comments if I'm on

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:04 nachm.) Review request for KDE Frameworks an

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82653 --- Please include a screenshot for UI changes. Also please wait

Review Request 124397: Add today button to calendar

2015-07-19 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bug

Re: Review Request 124384: Fix build with Qt < 5.4

2015-07-19 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124384/ --- (Updated July 19, 2015, 10:30 a.m.) Status -- This change has been m

Re: Review Request 124386: Fix build with Qt < 5.4

2015-07-19 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124386/ --- (Updated July 19, 2015, 10:30 a.m.) Status -- This change has been m

Re: Review Request 124384: Fix build with Qt < 5.4

2015-07-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124384/#review82633 --- Ship it! Ship It! - Martin Gräßlin On July 18, 2015, 11:02

Re: Review Request 124386: Fix build with Qt < 5.4

2015-07-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124386/#review82632 --- Ship it! Ship It! - Martin Gräßlin On July 18, 2015, 11:09