Re: Review Request 124414: Fix kbuildsycoca5 --global

> On jūlijs 22, 2015, 2:20 a.m., Aleix Pol Gonzalez wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 686 > > > > > > Would it work by using `qunsetenv`? > > > > It looks like XDG_DATA_HOME is just bein

Re: Review Request 124414: Fix kbuildsycoca5 --global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/#review82795 --- src/kbuildsycoca/kbuildsycoca.cpp (line 686)

Review Request 124414: Fix kbuildsycoca5 --global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 18:59:04 + Build duration: 47 sec CHANGE SET Revision 50c0a31944a40aecd05a564f23f7bd2

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 16 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 18:39:42 + Build duration: 1 min 12 sec CHANGE SET Revision ba267253dbaeac32bb033e2f5

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- (Updated July 21, 2015, 6:39 p.m.) Status -- This change has been ma

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. > > Martin Klapetek wrote: > Why would you think? The wh

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:56:40 + Build duration: 1 min 52 sec CHANGE SET Revision b449460131aa342ff8405e50834

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 18 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:00:43 + Build duration: 4 sec CHANGE SET No changes ___

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 18 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:00:43 + Build duration: 2.6 sec CHANGE SET No changes __

Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 7:27 p.m.) Review request for KDE Frameworks, Àle

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 144 > > > > > > You should deallocate hash here if it is not null, otherwise you have a > > memory leak. > > Martin K

Re: Review Request 124413: Enable PAM opening KWallet again

> On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: > > src/runtime/kwalletd/main.cpp, line 113 > > > > > > You should use strncmp instead of strcmp. Why would you think? The whole string is being compared, wha

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 55 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/55/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 21 Jul 2015 15:33:13 + Build duration: 6 min 37 sec CHANGE SET

Re: Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- src/runtime/kwalletd/main.cpp (line 113)

Review Request 124413: Enable PAM opening KWallet again

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet