Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-08-21 Thread David Faure
> On Aug. 18, 2015, 9:47 p.m., David Faure wrote: > > I'm still very surprised by the use case. How are you getting the full path > > to an application .desktop file without using the KService framework? It > > sounds like parsing all application desktop files by hand, which sounds > > horribl

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

2015-08-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Aug 2015 23:54:15 + Build duration: 5 min 16 sec CHANGE SET Revision 34db090da151cc2d8327b921af902c94c7ed

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

2015-08-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Aug 2015 23:54:15 + Build duration: 5 min 16 sec CHANGE SET Revision 34db090da151cc2d8327b921af902c94c7ed

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84166 --- Ship it! Ship It! - Jeremy Whiting On Aug. 21, 2015, 3:35

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 9:35 nachm.) Review request for KDE Frameworks, P

Re: Review Request 124856: Call newInstance from the child on first invocation

2015-08-21 Thread Thiago Macieira
> On Ago. 21, 2015, 8:08 a.m., David Faure wrote: > > I thought the idea was "there's no race, because as long as the recipient > > doesn't go to the event loop, it won't be processing any incoming messages > > anyway"? > > Albert Astals Cid wrote: > But with Thiago's patches dbus runs in

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84164 --- Maybe add a comment saying where these numbers come from? - A

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84163 --- Ship it! Ship It! - David Edmundson On Aug. 21, 2015, 9:23

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- (Updated Aug. 21, 2015, 9:23 nachm.) Review request for KDE Frameworks, P

Review Request 124872: Default to Breeze colors

2015-08-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/ --- Review request for KDE Frameworks, Plasma and KDE Usability. Repository:

Re: Review Request 124856: Call newInstance from the child on first invocation

2015-08-21 Thread Albert Astals Cid
> On ago. 21, 2015, 8:08 a.m., David Faure wrote: > > I thought the idea was "there's no race, because as long as the recipient > > doesn't go to the event loop, it won't be processing any incoming messages > > anyway"? > > Albert Astals Cid wrote: > But with Thiago's patches dbus runs in

Re: QIcon::fromTheme(xxx, someFallback)

2015-08-21 Thread Olivier Goffart
On Friday 21. August 2015 10:05:09 David Faure wrote: > Hi Olivier, > > I've been trying to fix performance problems with QIcon::fromTheme("foo") > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more > precisely, that fallback argument. > > KMail (and all similar large apps

Re: Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux, gcc - Build # 65 - Unstable!

2015-08-21 Thread David Faure
On Friday 21 August 2015 08:46:28 no-re...@kde.org wrote: > TestSuite.kiofilewidgets-kfileplacesmodeltest Nooo :-( The QSet ordering problem is still there, even with qputenv("QT_HASH_SEED", 0); qputenv("QT_NO_CPU_FEATURE", "1"); running before main(). Giuseppe - it's all your fa

Re: QIcon::fromTheme(xxx, someFallback)

2015-08-21 Thread David Faure
On Friday 21 August 2015 10:53:29 Olivier Goffart wrote: > On Friday 21. August 2015 10:05:09 David Faure wrote: > > Hi Olivier, > > > > I've been trying to fix performance problems with QIcon::fromTheme("foo") > > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more > > prec

Re: Review Request 124856: Call newInstance from the child on first invocation

2015-08-21 Thread David Faure
> On Aug. 21, 2015, 8:08 a.m., David Faure wrote: > > I thought the idea was "there's no race, because as long as the recipient > > doesn't go to the event loop, it won't be processing any incoming messages > > anyway"? > > Albert Astals Cid wrote: > But with Thiago's patches dbus runs in

Re: QIcon::fromTheme(xxx, someFallback)

2015-08-21 Thread Volker Krause
On Friday 21 August 2015 10:53:29 Olivier Goffart wrote: > On Friday 21. August 2015 10:05:09 David Faure wrote: > > Hi Olivier, > > > > I've been trying to fix performance problems with QIcon::fromTheme("foo") > > when using KIconEngine, and I'm hitting a wall due to the QIcon API - more > > prec

Re: Review Request 124856: Call newInstance from the child on first invocation

2015-08-21 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/#review84149 --- Makes sense! - Thiago Macieira On Ago. 21, 2015, 4:06 p.m.,

Re: Review Request 124856: Call newInstance from the child on first invocation

2015-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/ --- (Updated ago. 21, 2015, 4:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 124856: Be a bit stubborn calling newInstance

2015-08-21 Thread Albert Astals Cid
> On ago. 21, 2015, 8:08 a.m., David Faure wrote: > > I thought the idea was "there's no race, because as long as the recipient > > doesn't go to the event loop, it won't be processing any incoming messages > > anyway"? But with Thiago's patches dbus runs in a thread so that's not true anymore

Re: Review Request 124856: Be a bit stubborn calling newInstance

2015-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/ --- (Updated ago. 21, 2015, 4:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 124856: Be a bit stubborn calling newInstance

2015-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/ --- (Updated ago. 21, 2015, 4:05 p.m.) Review request for KDE Frameworks and

Re: Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux, gcc - Build # 32 - Fixed!

2015-08-21 Thread Scarlett Clark
I committed some new triggers that should hopefully work. Please let me know if you still get double emails. Thanks, Scarlett On Tue, Aug 18, 2015 at 6:55 AM, Scarlett Clark < scarlett.gately.cl...@gmail.com> wrote: > Ok, not quite that simple. If I disable failure then it will not complain > wh

Re: Jenkins-kde-ci: ksshaskpass Plasma-5.4 stable-kf5-qt5 » Linux, gcc - Build # 1 - Successful!

2015-08-21 Thread Scarlett Clark
Fixed, thank you Scarlett On Aug 21, 2015 1:14 AM, "Luigi Toscano" wrote: > Il 21 agosto 2015 10:06:59 CEST, David Faure ha scritto: > > On Thursday 20 August 2015 13:20:50 no-re...@kde.org wrote: > > > > > > GENERAL INFO > > > > > > BUILD SUCCESS > > > Build URL: > > > https://build.kde.org/job

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 65 - Unstable!

2015-08-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Aug 2015 08:41:11 + Build duration: 5 min 11 sec CHANGE SET Revision d61b0cea135f0a1ff54377aeafc7b119407

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 65 - Unstable!

2015-08-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 21 Aug 2015 08:41:11 + Build duration: 5 min 11 sec CHANGE SET Revision d61b0cea135f0a1ff54377aeafc7b119407

Re: Jenkins-kde-ci: ksshaskpass Plasma-5.4 stable-kf5-qt5 » Linux, gcc - Build # 1 - Successful!

2015-08-21 Thread Luigi Toscano
Il 21 agosto 2015 10:06:59 CEST, David Faure ha scritto: > On Thursday 20 August 2015 13:20:50 no-re...@kde.org wrote: > > > > GENERAL INFO > > > > BUILD SUCCESS > > Build URL: > https://build.kde.org/job/ksshaskpass%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ > > Project: PLATF

Re: Review Request 124856: Be a bit stubborn calling newInstance

2015-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/#review84129 --- I thought the idea was "there's no race, because as long as th

Re: Jenkins-kde-ci: ksshaskpass Plasma-5.4 stable-kf5-qt5 » Linux, gcc - Build # 1 - Successful!

2015-08-21 Thread David Faure
On Thursday 20 August 2015 13:20:50 no-re...@kde.org wrote: > > GENERAL INFO > > BUILD SUCCESS > Build URL: > https://build.kde.org/job/ksshaskpass%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Thu, 20 Aug 2015 12:23:33 +

QIcon::fromTheme(xxx, someFallback)

2015-08-21 Thread David Faure
Hi Olivier, I've been trying to fix performance problems with QIcon::fromTheme("foo") when using KIconEngine, and I'm hitting a wall due to the QIcon API - more precisely, that fallback argument. KMail (and all similar large apps) calls QIcon::fromTheme() for many actions on startup, most of w