Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 30 - Failure!

2015-09-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 06:49:10 + Build duration: 1 min 37 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 29 - Unstable!

2015-09-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/29/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 06:49:10 + Build duration: 3 min 29 sec CHANGE SET

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 31 - Still unstable!

2015-09-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/31/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 07:01:15 + Build duration: 3 min 13 sec CHANGE SET No changes

Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread David Faure
> On Sept. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- (Updated Sept. 11, 2015, 4:27 p.m.) Review request for KDE Frameworks

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- (Updated Sept. 11, 2015, 7:07 p.m.) Review request for KDE Frameworks

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/#review85209 --- Ship it! Ship It! - Marco Martin On Sept. 11, 2015, 5:07

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 32 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/32/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 07:20:20 + Build duration: 3 min 0 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 32 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/32/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 07:20:20 + Build duration: 3 min 0 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 30 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 07:20:20 + Build duration: 2 min 18 sec CHANGE SET

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 30 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/30/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 11 Sep 2015 07:20:20 + Build duration: 2 min 18 sec CHANGE SET

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-11 Thread David Faure
On Thursday 10 September 2015 19:29:23 Michael Pyne wrote: > On Thu, September 10, 2015 09:16:11 David Faure wrote: > > On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > > > I tried to optimize it by 'caching' the isNull value in QIconPrivate. > > > > > > But then the test failed:

Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-11 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125154/ --- Review request for KDE Frameworks and Lukáš Tinkl. Bugs: 350758

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-11 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125154/#review85165 --- +1 - Luca Beltrame On Set. 11, 2015, 8:28 a.m., Xuetian

Re: Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 29 - Unstable!

2015-09-11 Thread Martin Gräßlin
Hi, I investigated the issue this morning and I think I pushed a working fix for it. Unfortunately I'm not 100 % as: * tests are timing depending * individual test case are not atomic If we hit the problem again, I'll disable the test and replace it by one which has atomic test cases.

Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

changelog for KF 5.14

2015-09-11 Thread David Faure
Please review. The very last one, "plasma frameworks" doesn't seem very readable to me, but maybe that's just because I don't follow it much. ### In many frameworks * Rename private classes to avoid exporting them accidentally ### Baloo * Add org.kde.baloo interface to root object for backward

Re: Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125104/ --- (Updated Sept. 11, 2015, 8:28 p.m.) Status -- This change has been

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-11 Thread Jean-Baptiste Mardelle
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote: > > +1 Kdenlive is also affected by this issue, as described in bug #346413 Pressing "Esc" allows to dismiss the invisible file dialog and regain control of the app. However I tested the proposed patch and it does not solve the problem for

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Sep 2015 21:17:30 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85220 --- Hmm, this seems to break kservicetest's testKSycocaUpdate()

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Sep 2015 21:17:30 + Build duration: 1 min 44 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125144: Provide enabled property for QIconItem.

2015-09-11 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125144/ --- (Updated Sept. 11, 2015, 10:27 a.m.) Status -- This change has been

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread Albert Astals Cid
> On set. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Review Request 125158: add logic to use icons for default xdg user dirs

2015-09-11 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- Review request for KDE Frameworks. Bugs: 352498

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 33 - Failure!

2015-09-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Sep 2015 10:27:55 + Build duration: 1 min 18 sec CHANGE SET Revision

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-11 Thread Xuetian Weng
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote: > > +1 > > Jean-Baptiste Mardelle wrote: > Kdenlive is also affected by this issue, as described in bug #346413 > Pressing "Esc" allows to dismiss the invisible file dialog and regain > control of the app. > However I tested the

Re: Review Request 125106: Minor optimizations

2015-09-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- (Updated set. 11, 2015, 11:56 p.m.) Review request for KDE Frameworks

Re: Review Request 125148: Call parent ::event()

2015-09-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125148/ --- (Updated Sept. 11, 2015, 12:29 p.m.) Status -- This change has been

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread David Edmundson
> On Sept. 11, 2015, 12:56 p.m., Albert Astals Cid wrote: > > src/kbuildsycoca/kbuildsycoca.cpp, line 370 > > > > > > .lock() calls scare me, this will block forever if say kbuildsycoca > > crashed, right? > >

Review Request 125164: Fix misbehavior when canceling a job

2015-09-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85178 --- src/kbuildsycoca/kbuildsycoca.cpp (line 368)

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-11 Thread Samuel Gaist
> On Sept. 7, 2015, 7:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically wrong. We are now binding finding

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 87 - Successful!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Sep 2015 14:11:54 + Build duration: 12 min CHANGE SET Revision e8d1813254eebfe73d61e12a3f02f24b76fba93d by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 80 - Successful!

2015-09-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Sep 2015 14:11:54 + Build duration: 10 min CHANGE SET Revision e8d1813254eebfe73d61e12a3f02f24b76fba93d