Review Request 125514: Add a web shortcut manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review86315 --- src/kcollapsiblegroupbox.h (line 21)

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

> On Oct. 3, 2015, 8:40 p.m., David Edmundson wrote: > > src/kcrash.cpp, line 686 > > > > > > I don't think you need the -1 here. > > David Faure wrote: > I don't find the manpage for getcwd very precise on

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 21:29:59 + Build duration: 2 min 16 sec CHANGE SET Revision cc64cd1cb803449107e453f5b4a3bce860a133

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 89 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 21:29:59 + Build duration: 2 min 16 sec CHANGE SET Revision cc64cd1cb803449107e453f5b4a3bce860a133

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 21:29:59 + Build duration: 2 min 10 sec CHANGE SET Revision cc64cd1cb803449107e453f5b4a3bce

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 21:29:59 + Build duration: 2 min 10 sec CHANGE SET Revision cc64cd1cb803449107e453f5b4a3bce

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/ --- (Updated Oct. 3, 2015, 9:03 p.m.) Status -- This change has been mar

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

> On Oct. 3, 2015, 8:40 p.m., David Edmundson wrote: > > src/kcrash.cpp, line 686 > > > > > > I don't think you need the -1 here. I don't find the manpage for getcwd very precise on that topic, so better safe t

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/#review86313 --- Ship it! src/kcrash.cpp (line 686)

Re: Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125502/ --- (Updated Oct. 3, 2015, 8:37 p.m.) Status -- This change has been mar

Re: Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125502/#review86312 --- Ship it! Ship It! - David Edmundson On Oct. 3, 2015, 8:29

Re: Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125502/ --- (Updated Oct. 3, 2015, 8:29 p.m.) Review request for KDE Frameworks and H

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/ --- (Updated Oct. 3, 2015, 8:24 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

> On Oct. 3, 2015, 6:21 p.m., David Edmundson wrote: > > src/kcrash.cpp, line 655 > > > > > > +201 ? Hmm, good point. - David --- This is an automatica

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/ --- (Updated Oct. 3, 2015, 7:59 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 125511: Add missing documentation for argument to LAUNCHER_EXEC_NEW

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125511/#review86310 --- Thanks - but add (optional) to the docs, it's treated a bit di

Review Request 125511: Add missing documentation for argument to LAUNCHER_EXEC_NEW

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125511/ --- Review request for KDE Frameworks. Repository: kinit Description --

Re: Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125502/#review86304 --- +1 from me src/kcrash.cpp (line 120)

Re: Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/#review86305 --- src/kcrash.cpp (line 655)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 88 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 12:58:41 + Build duration: 2 min 58 sec CHANGE SET Revision 0ec8cf95d33c0c62d2096c81d0c32155e66c7

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 83 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 12:58:36 + Build duration: 2 min 42 sec CHANGE SET Revision 0ec8cf95d33c0c62d2096c81d0c321

Re: Review Request 125484: Allow to clear completion history

> On Oct. 2, 2015, 8:43 p.m., David Faure wrote: > > Looks ok to me, except that KHistoryComboBox also adds such a menu item to > > the KLineEdit popup. Can you check if it has it twice now? I would expect > > so. In that case you could remove the action+slot from KHistoryComboBox > > then? (c

Re: Review Request 125484: Allow to clear completion history

> On oct. 2, 2015, 8:43 après-midi, David Faure wrote: > > Looks ok to me, except that KHistoryComboBox also adds such a menu item to > > the KLineEdit popup. Can you check if it has it twice now? I would expect > > so. In that case you could remove the action+slot from KHistoryComboBox > > th

Re: Review Request 125484: Allow to clear completion history

> On oct. 2, 2015, 8:43 après-midi, David Faure wrote: > > Looks ok to me, except that KHistoryComboBox also adds such a menu item to > > the KLineEdit popup. Can you check if it has it twice now? I would expect > > so. In that case you could remove the action+slot from KHistoryComboBox > > th

Re: Review Request 125484: Allow to clear completion history

> On oct. 2, 2015, 8:43 après-midi, David Faure wrote: > > Looks ok to me, except that KHistoryComboBox also adds such a menu item to > > the KLineEdit popup. Can you check if it has it twice now? I would expect > > so. In that case you could remove the action+slot from KHistoryComboBox > > th

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/ --- (Updated Oct. 3, 2015, 1:38 p.m.) Review request for KDE Frameworks and C

Re: Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125504/ --- (Updated Oct. 3, 2015, 1:16 p.m.) Review request for KDE Frameworks and M

Review Request 125504: KServiceTypeProfile: remove unnecessary factory creation.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125504/ --- Review request for KDE Frameworks and Milian Wolff. Bugs: 353360 http

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

> On Oct. 3, 2015, 8:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defini

Review Request 125503: KCrash: pass cwd to kdeinit when auto-restarting the app via kdeinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125503/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defin

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

> On Oct. 3, 2015, 10:08 a.m., David Faure wrote: > > I just realized another problem with this approach: since the latest > > libkonq release installs konqpopupmenuplugin.desktop already, this patch > > will make the next KIO release conflict with that last libkonq release > > (which by defin

Review Request 125502: Add KCrash::initialize() so that apps and the platform plugin can explicitly enable KCrash.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125502/ --- Review request for KDE Frameworks and Harald Sitter. Repository: kcrash

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote: > > src/knotifyconfigwidget.h, line 73 > > > > > > This function name for a setter looks weird to me. > > setDefaults() > > reset() > > restoreDefaul

Re: Review Request 125418: Add method to revert knotifyconfigwidget to default notifications

> On Sept. 27, 2015, 8:21 a.m., Sune Vuorela wrote: > > src/knotifyconfigwidget.h, line 73 > > > > > > This function name for a setter looks weird to me. > > setDefaults() > > reset() > > restoreDefaul

Re: Review Request 125106: Minor optimizations

> On Oct. 3, 2015, 12:28 a.m., Matthew Dawson wrote: > > src/core/kdesktopfile.cpp, line 307 > > > > > > Since this gets converted to a QString immediately, should this not be > > a QStringLiteral? There doesn'

Re: Review Request 125106: Minor optimizations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86288 --- Ship it! Ship It! - Milian Wolff On Sept. 11, 2015, 11:56

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 09:32:02 + Build duration: 6 min 35 sec CHANGE SET Revision ffe46c917e2f760d91f87d275e9d

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 96 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/96/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 09:32:02 + Build duration: 6 min 35 sec CHANGE SET Revision ffe46c917e2f760d91f87d275e9d

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 09:32:02 + Build duration: 6 min 14 sec CHANGE SET Revision ffe46c917e2f760d91f87d275e9d17caeac

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 03 Oct 2015 09:32:02 + Build duration: 6 min 14 sec CHANGE SET Revision ffe46c917e2f760d91f87d275e9d17caeac

Re: [ktexteditor] /: fix unit completion_test

On Saturday 03 October 2015 09:31:39 Christoph Cullmann wrote: > an other problem > was that we skipped all tests if we have no ksycoca, which is a stupid idea > imho > as this will just hide the problems locally for you Yes, and in addition ksycoca is now created on demand, so indeed such checks

[ktexteditor] /: fix unit completion_test

Git commit ffe46c917e2f760d91f87d275e9d17caeacad7c8 by Christoph Cullmann. Committed on 03/10/2015 at 09:31. Pushed by cullmann into branch 'master'. fix unit completion_test the problem was the countItems, not sure since how long this was broken, an other problem was that we skipped all tests i

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

> On Sept. 28, 2015, 8:34 p.m., Olivier Goffart wrote: > > src/widgets/koverlayiconplugin.desktop, line 3 > > > > > > Do you have any example of plugins using this new way so that i can get > > inspiration from it

Re: KTextEditor unittests still broken!

Hi, will take care of it today. Thanks for the reminder. Greetings Christoph - Am 3. Okt 2015 um 10:54 schrieb David Faure fa...@kde.org: > Guys, KTextEditor is the worst KF5 framework now, for a month, in terms of > unittests. > It's been broken for a month, and nobody replied to my previo

KTextEditor unittests still broken!

Guys, KTextEditor is the worst KF5 framework now, for a month, in terms of unittests. It's been broken for a month, and nobody replied to my previous email on the topic. Everything else is green, KTextEditor is the only framework which is not - on the day of the release, two months in a row. h

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- I just realized another problem with this approach: since the

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

> On Oct. 2, 2015, 8:35 p.m., David Faure wrote: > > Sending Activate to a running Unique process is not a failure, so > > NoExitOnFailure should not affect it. > > > > If you need a "no exit, ever" flag, then I would recommend adding a > > separate flag for that. I'm not sure I understand the

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/ --- (Updated Okt. 3, 2015, 7:50 vorm.) Review request for KDE Frameworks and

Re: Problem investigating a heap-use-after-free in kwindowsystem

On Friday, October 2, 2015 8:38:20 PM CEST Michael Pyne wrote: > On Fri, October 2, 2015 23:59:00 Albert Astals Cid wrote: > > El Friday 02 October 2015, a les 22:24:00, Martin Graesslin va escriure: > > > Hi all, > > > > > > I added a new unit test to kwin today [1] and it failed on the CI system