Re: Review Request 124698: KPasswordDialog: allow the user to show the password

2015-10-21 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124698/#review87214 --- Update: the fix for QTBUG 39660, which landed in Qt 5.5.1,

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, line 172 > > > > > > looks like you removed an empty line > > Boudhayan Gupta wrote: > I don't understand this issue. Removed

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87206 --- src/kwindoweffects.h (line 167)

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/ --- (Updated Oct. 21, 2015, 2:57 p.m.) Status -- This change has been

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:08 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, line 172 > > > > > > looks like you removed an empty line I don't understand this issue. Removed an empty line? - Boudhayan

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/ --- (Updated Oct. 21, 2015, 8:53 p.m.) Review request for KDE Frameworks and

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
> On Oct. 21, 2015, 4:49 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

breeze icons default and its inheritance

2015-10-21 Thread Harald Sitter
Aloha! So, yesterday I switched the default kiconthemes theme from oxygen to breeze [1] to get all builtin defaults of frameworks to be breeze rather than oxygen. Alas, as it turns out breeze icons do not inherit from oxygen for a while now, which has the very unfortunate disadvantage of

Re: breeze icons default and its inheritance

2015-10-21 Thread Luca Beltrame
Il Thu, 22 Oct 2015 07:28:09 +0200, Harald Sitter ha scritto: > temporarily revert kiconthemes commit until breeze-icons with a I would suggest this for the moment while a fix is sought. It's been causing crashes in KMail because the fallback fails and KPixmapSequence accesses invalid data ->

icons packages with frameworks

2015-10-21 Thread Jonathan Riddell
Oxygen icons used to be part of KDE Applications and it's regeneration by the VDG has it moved to Plasma as part of desktop integration, this gives us problems with the version numbers going from 15.04 to 5.5 and I plan to rename it to oxygen-icons-plasma as a result. It's been suggested that

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87207 --- src/kwindoweffects.cpp (line 95)

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
> On Oct. 21, 2015, 8:19 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87212 --- Out of curiosity, why was it made only of commented

Re: icons packages with frameworks

2015-10-21 Thread Albert Astals Cid
El Wednesday 21 October 2015, a les 18:36:04, Harald Sitter va escriure: > On Wed, Oct 21, 2015 at 6:17 PM, Jonathan Riddell wrote: > > Oxygen icons used to be part of KDE Applications and it's regeneration > > by the VDG has it moved to Plasma as part of desktop integration,

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Boudewijn Rempt
On Wed, 21 Oct 2015, Alexander Neundorf wrote: Maybe Qt could be shared ? No, no, no. Absolutely not. Every application on Windows should bring its own dependencies and all of them. Any attempt at anything else is a misguided deviation from the platform's way of working and will bring

Re: icons packages with frameworks

2015-10-21 Thread Martin Graesslin
On Wednesday, October 21, 2015 4:17:57 PM CEST Jonathan Riddell wrote: > Oxygen icons used to be part of KDE Applications and it's regeneration > by the VDG has it moved to Plasma as part of desktop integration, this > gives us problems with the version numbers going from 15.04 to 5.5 and > I plan

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, > Hello, > > On Wednesday 21 October 2015 09:26:35 Christoph Cullmann wrote: >> Hi, >> ;=) Yeah, fluffy, e.g. I would call dbus "non-reasonable", as it requires >> some daemon to be running, even if we would have per application install >> daemons. I would call stuff reasonable that is

Re: [KDE/Mac] Question to experienced Mac devs about goal of Windows/Mac frameworks

2015-10-21 Thread René J . V . Bertin
On Wednesday October 21 2015 11:30:46 Jaroslaw Staniek wrote: >- Looking at competition is always good. Do these MS Office/Adobe apps use >dbus? I don't think so, and my suggestion to look at commercial software suites was unrelated to the use of dbus. It was made with deployment in mind,

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, >> What's important to realize is that deployment under Windows works different > >> to deployment under Linux: In Linux, you have the package manager which > >> automatically drags in all correct dependencies and you are fine. > >> > >> In Windows, such a package manager does not exist.

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

2015-10-21 Thread René J . V . Bertin
On Wednesday October 21 2015 22:12:00 Christoph Cullmann wrote: > Maybe, but actually, even with the most dumb application bundle I have > created ATM > all stuff together is around 50 MB compressed and installed 125 MB. > > This includes a more or less complete Qt (with webkit, some debug

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Kevin Ottens
Hello, On Wednesday 21 October 2015 21:06:02 Christoph Cullmann wrote: > >> > If it is linked to runtime dependencies, I think you ought to not only > >> > look at the Tier but also the Type. Only frameworks of the "functional" > >> > type have no such dependencies. > >> > >> Perhaps. > > > >

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Alexander Neundorf
On Wednesday, October 21, 2015 13:08:46 Dominik Haumann wrote: > On Tue, Oct 20, 2015 at 8:23 PM, Christoph Cullmann wrote: > > I think that is more or less what we had in the past with the "kdewin" > > installer, that is like the cygwin installer pulling in all stuff you >

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Alexander Neundorf
On Wednesday, October 21, 2015 22:48:52 Christoph Cullmann wrote: > Hi, > > > On Wednesday, October 21, 2015 22:12:00 Christoph Cullmann wrote: > > > > ... > > > >> And the big benefit: One can install my alpha crashy something quality > >> Kate > >> > >> bundle with its Qt something version

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Alexander Neundorf
On Wednesday, October 21, 2015 22:12:00 Christoph Cullmann wrote: ... > And the big benefit: One can install my alpha crashy something quality Kate > bundle with its Qt something version and some imaginary Krita bundle that > is installed in parallel will NOT be borked! are you more or less

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, > On Wednesday, October 21, 2015 22:12:00 Christoph Cullmann wrote: > > ... > >> And the big benefit: One can install my alpha crashy something quality Kate > >> bundle with its Qt something version and some imaginary Krita bundle that > >> is installed in parallel will NOT be borked! >

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 45 - Unstable!

2015-10-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Oct 2015 22:48:51 + Build duration: 1 min 58 sec CHANGE SET Revision

Review Request 125750: Reduce some allocations

2015-10-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/ --- Review request for KDE Frameworks and Sebastian Kügler. Repository:

Re: Review Request 125750: Reduce some allocations

2015-10-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/ --- (Updated Oct. 22, 2015, 4:05 a.m.) Review request for KDE Frameworks and

Re: Review Request 125750: Reduce some allocations

2015-10-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/#review87237 --- Ship it! Ship It! - Sebastian Kügler On Oct. 22, 2015,

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Martin Gräßlin
> On Oct. 21, 2015, 4:49 p.m., Boudhayan Gupta wrote: > > src/platforms/xcb/kwindoweffects_x11.h, line 26 > > > > > > This was my idea, which sitter also liked and is used in Phonon. The > > idea is that every

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 47 - Still Unstable!

2015-10-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 00:09:17 + Build duration: 1 min 59 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 46 - Still Unstable!

2015-10-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 00:09:17 + Build duration: 1 min 51 sec CHANGE SET Revision

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

2015-10-21 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- (Updated Oct. 22, 2015, 12:31 a.m.) Status -- This change has been

Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

2015-10-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review87175 --- Ship it! Ship It! - Albert Astals Cid On oct. 21, 2015,

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Kevin Ottens
Hello, On Wednesday 21 October 2015 08:13:42 Christoph Cullmann wrote: > > On Tuesday 20 October 2015 19:49:54 Aleix Pol wrote: > >> 3) non-existing stuff? really? Let's rephrase it as: "Frameworks will > >> only be advertised as available on a platform if they are just require > >> Qt or other

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, > Hello, > > On Wednesday 21 October 2015 08:13:42 Christoph Cullmann wrote: >> > On Tuesday 20 October 2015 19:49:54 Aleix Pol wrote: >> >> 3) non-existing stuff? really? Let's rephrase it as: "Frameworks will >> >> only be advertised as available on a platform if they are just require >>

Re: [KDE/Mac] Question to experienced Mac devs about goal of Windows/Mac frameworks

2015-10-21 Thread René J . V . Bertin
On Wednesday October 21 2015 11:30:46 Jaroslaw Staniek wrote: > ​I don't think separating community this way is acceptable. Or categorising > people. There are smart people that can have multiple hats. > Even for example, less advanced OS X users have right to demand native UI > styling on the

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/ --- (Updated Oct. 21, 2015, 10:29 a.m.) Review request for KDE Frameworks

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Ralf Habacker
> Christoph Cullmann hat am 20. Oktober 2015 um 16:49 > geschrieben: > That works only, if the applications bundle their ui files in resources, too, > otherwise, they just won't be found > and the applications break, unless you patch again Qt to look in non-standard >

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Gregor M
I think that is more or less what we had in the past with the "kdewin" installer, that is like the cygwin installer pulling in all stuff you need and a set of applications in some common prefix. I am not sure that was such a success, compared to what e.g. Krita, Marble, Digikam and others do:

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Ralf Habacker
Am 21.10.2015 um 08:14 schrieb Christoph Cullmann: > Hi, > >>> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: >>> Regarding dbus especifically, I see the problem in 2). You can bundle >>> it, but then if it's already ran by another process the other one will >>> have

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, > Am 21.10.2015 um 08:14 schrieb Christoph Cullmann: >> Hi, >> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: Regarding dbus especifically, I see the problem in 2). You can bundle it, but then if it's already ran by another process the other one will

Re: [KDE/Mac] Question to experienced Mac devs about goal of Windows/Mac frameworks

2015-10-21 Thread Jaroslaw Staniek
On 21 October 2015 at 10:20, René J.V. wrote: > T,FTFY :) > > Seriously, how many people on here are Mac developers with significant > experience targeting native OS X APIs, and how many have significant > experience using Macs as Unix-based workstations with a true,

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Dominik Haumann
On Tue, Oct 20, 2015 at 8:23 PM, Christoph Cullmann wrote: > I think that is more or less what we had in the past with the "kdewin" > installer, > that is like the cygwin installer pulling in all stuff you need and a set of > applications > in some common prefix. > > I am

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87199 --- Ship it! Ship It! - Jeremy Whiting On Oct. 21, 2015, 4:29

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-21 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/#review87193 --- Ping ? - R.Harish Navnit On Oct. 12, 2015, 12:24 a.m.,

Re: Review Request 125656: Drop empty files

2015-10-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87196 --- +1, I like this solution to the problem! - Martin Gräßlin

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

2015-10-21 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/ --- (Updated Oct. 21, 2015, 5:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 125449: Add support for desktop file name to KAboutData

2015-10-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125449/#review87172 --- @David: any comment on it? I don't want to push without your

Re: Review Request 125720: set default theme to breeze rather than oxygen

2015-10-21 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125720/ --- (Updated Oct. 21, 2015, 6:07 a.m.) Status -- This change has been

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, >> Aleix Pol hat am 20. Oktober 2015 um 19:49 geschrieben: >> Regarding dbus especifically, I see the problem in 2). You can bundle >> it, but then if it's already ran by another process the other one will >> have to be used, which is where the dbus mess starts. > There is

Re: Question about goal of Windows/Mac frameworks

2015-10-21 Thread Christoph Cullmann
Hi, > Hello, > > On Tuesday 20 October 2015 19:49:54 Aleix Pol wrote: >> 3) non-existing stuff? really? Let's rephrase it as: "Frameworks will >> only be advertised as available on a platform if they are just require >> Qt or other available dependencies on the platform". For example, >>

Re: [KDE/Mac] Question to experienced Mac devs about goal of Windows/Mac frameworks

2015-10-21 Thread René J . V . Bertin
T,FTFY :) Seriously, how many people on here are Mac developers with significant experience targeting native OS X APIs, and how many have significant experience using Macs as Unix-based workstations with a true, integrated desktop? Think of significant as "going back to before the last few,

Re: Review Request 125449: Add support for desktop file name to KAboutData

2015-10-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125449/#review87182 --- Ship it! ah sorry I skipped that one when I saw it was