Re: Review Request 125779: properly handle middle click in navigatormenu

2015-10-25 Thread Ilia Kats
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/ --- (Updated Oct. 25, 2015, 8:23 a.m.) Review request for KDE Frameworks.

Review Request 125784: fix windows compilation of autotests

2015-10-25 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125784/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/#review87359 --- Ship it! Ship It! - Emmanuel Pescosta On Oct. 25, 2015,

Re: Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/#review87362 --- Ping anyone? ;=) - Christoph Cullmann On Oct. 23, 2015,

Review Request 125790: Recognize image/vnd.adobe.photoshop

2015-10-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/ --- Review request for KDE Frameworks. Repository: kimageformats

Re: Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

2015-10-25 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/#review87363 --- Ship it! Ship It! - Jeremy Whiting On Oct. 23, 2015,

Re: Review Request 125784: fix windows compilation of autotests

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125784/#review87358 --- Looks ok to me. - Christoph Cullmann On Oct. 25, 2015,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

2015-10-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 25 Oct 2015 10:38:27 + Build duration: 6 min 37 sec CHANGE SET Revision 9891e43c6cb009280b5090d87d73d4e8ca9ddbcd

Re: Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/ --- (Updated Oct. 25, 2015, 12:39 p.m.) Status -- This change has been

Re: Review Request 125590: Patch for kimageformats that handles xcfgz / xcfbz2 (compressed GIMP) images (read-only).

2015-10-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125590/#review87357 --- Thanks for this! The code generally looks pretty good, but

Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/ --- Review request for KDE Frameworks. Repository: kio-extras Description

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/ --- (Updated Oct. 25, 2015, 12:02 p.m.) Status -- This change has been

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125788/#review87360 --- Ship it! Ship It! - David Edmundson On Oct. 25, 2015,

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 142 - Fixed!

2015-10-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/142/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 25 Oct 2015 10:38:27 + Build duration: 6 min 37 sec CHANGE SET Revision 9891e43c6cb009280b5090d87d73d4e8ca9ddbcd

Re: Review Request 125797: protocoltojson application

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/#review87382 --- I think one needs to add a outer scope with some

Re: Question about goal of Windows/Mac frameworks

2015-10-25 Thread Ralf Habacker
> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 > geschrieben: > For Krita, we decided ages ago to simply open a browser on the userbase > manual of Krita. Yes, it is conceivable that there are people who use > Krita without internet access who still need help, it's just

Re: Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

2015-10-25 Thread Christoph Cullmann
> On Oct. 25, 2015, 5:09 p.m., David Faure wrote: > > So every app (packaged this way) will need a copy of the .protocol files > > and the kioslave executable... > > > > I much preferred the solution we talked about previously, where .protocol > > files would be embedded (as JSON) into the

Re: Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

2015-10-25 Thread David Faure
> On Oct. 25, 2015, 5:09 p.m., David Faure wrote: > > So every app (packaged this way) will need a copy of the .protocol files > > and the kioslave executable... > > > > I much preferred the solution we talked about previously, where .protocol > > files would be embedded (as JSON) into the

Re: Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

2015-10-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/#review87371 --- So every app (packaged this way) will need a copy of the

Review Request 125797: protocoltojson application

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Re: Review Request 125784: fix windows compilation of autotests

2015-10-25 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125784/#review87368 --- Ship it! It really doesn't compile, just ship it, better

Re: Review Request 125784: fix windows compilation of autotests

2015-10-25 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125784/ --- (Updated Oct. 25, 2015, 4:42 p.m.) Status -- This change has been

Review Request 125795: Add KCollapsibleGroupBox

2015-10-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125795/ --- Review request for KDE Frameworks and Alex Merry. Repository:

Re: Review Request 125778: Allow kio .protocol files to be app local and local kioslave deployment

2015-10-25 Thread Christoph Cullmann
> On Oct. 25, 2015, 5:09 p.m., David Faure wrote: > > So every app (packaged this way) will need a copy of the .protocol files > > and the kioslave executable... > > > > I much preferred the solution we talked about previously, where .protocol > > files would be embedded (as JSON) into the

Re: Review Request 125795: Add KCollapsibleGroupBox

2015-10-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125795/#review87379 --- Ship it! Ship It! - Alex Merry On Oct. 25, 2015, 6:18