Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

2015-12-06 Thread David Faure
> On Dec. 6, 2015, 11:19 a.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than > > file:///tmp/. I consider this a bug (when

Re: Review Request 125915: Drop runtime dependency on QApplication

2015-12-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125915/ --- (Updated Dec. 6, 2015, 6:20 p.m.) Status -- This change has been

Re: Review Request 126038: Add protocol info to KIO plugin metadata

2015-12-06 Thread David Faure
> On Nov. 12, 2015, 4:12 p.m., Christoph Cullmann wrote: > > Hi, > > > > I did the same in https://git.reviewboard.kde.org/r/125869/ but I still > > need to fix the i18n issue, first :/ > > Andrew McCann wrote: > Ahh, indeed you did. > > Should I abandon this? or do I 'add' it to

Re: OS X : org.kde.klauncher5 was not provided by any .service files

2015-12-06 Thread David Faure
On Tuesday 24 November 2015 00:27:01 René J.V. Bertin wrote: > > "KLauncher could not be reached via D-Bus. Error when calling > kdeinit_exec_wait:\nThe name org.kde.klauncher5 was not provided by any > .service files\n" kdeinit5 is supposed to fork and exec klauncher5 on startup, and then

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-06 Thread David Faure
> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Jenkins-kde-ci: kitemmodels master kf5-qt5 » Linux,gcc - Build # 29 - Aborted!

2015-12-06 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kitemmodels%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 13:00:51 + Build duration: 2 min 3 sec CHANGE SET Revision

Jenkins-kde-ci: kitemmodels master stable-kf5-qt5 » Linux,gcc - Build # 26 - Aborted!

2015-12-06 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kitemmodels%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 13:02:39 + Build duration: 0.43 sec CHANGE SET No changes

Jenkins-kde-ci: kitemmodels master kf5-qt5 » Linux,gcc - Build # 30 - Successful!

2015-12-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemmodels%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 14:14:19 + Build duration: 3 min 33 sec CHANGE SET Revision

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/#review89183 --- src/kedittoolbar.cpp (line 770)

Jenkins-kde-ci: kitemmodels master stable-kf5-qt5 » Linux,gcc - Build # 27 - Successful!

2015-12-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kitemmodels%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 14:12:31 + Build duration: 1 min 59 sec CHANGE SET Revision

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2015-12-06 Thread David Faure
> On Nov. 2, 2015, 8:08 a.m., David Faure wrote: > > Ah I see, forget what I said about HTTP proxy. > > > > About the missing argument, it would indeed be useful for this code: > > http://lxr.kde.org/source/extragear/network/konversation/src/irc/server.cpp > > Add a separate method, for BC

Re: Review Request 125800: OS X build and warning fix

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125800/#review89165 --- Ship it! Ship It! - David Faure On Oct. 27, 2015, 11:01

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review89164 --- Ship it! another round of low-level code review; but I'd say

Re: KNotifications filters

2015-12-06 Thread David Faure
On Thursday 24 September 2015 20:35:24 Jeremy Whiting wrote: > If so I guess the logical place for it would be a TTS group in > kdeglobals, does that make sense? Stay away from kdeglobals :-) It forces every app to parse that stuff even if they don't need it. Framework-specific config can go

Re: Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126245/#review89163 --- Ship it! Yep, looks 100% correct. I'm surprised that there

Re: Review Request 125762: External extractor plugin support for KFileMetaData

2015-12-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/#review89174 --- If you're planning on pushing this please push it to a

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

2015-12-06 Thread David Faure
> On Dec. 6, 2015, 11:19 a.m., David Faure wrote: > > OK I debugged this further, and I found why this didn't match my > > expectations of the QUrl behaviour: > > > > QUrl::fromLocalFile("/tmp/.") leads to file:///tmp rather than > > file:///tmp/. I consider this a bug (when

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

2015-12-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/#review89168 --- OK I debugged this further, and I found why this didn't match

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-06 Thread René J . V . Bertin
On Sunday December 06 2015 14:51:40 David Faure wrote: > Here is an easy way to test this: do the same change for kiod in kio (it's > like a mini kded) and then > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > should bring up a password dialog. OK, hope to get around to doing that

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2015-12-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 19:56:35 + Build duration: 4 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 171 - Fixed!

2015-12-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/171/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 06 Dec 2015 19:56:35 + Build duration: 4 min 56 sec CHANGE SET Revision

Re: kpty/utempter

2015-12-06 Thread David Faure
On Monday 30 November 2015 20:21:23 René J.V. Bertin wrote: > I've had a quick look, and it appears that it shouldn't be overly hard to > port libutempter to OS X (which has setutxent, pututxline etc. instead of > "x-less" counterparts on Linux). > > Question is, how useful is this in KPty?

Re: kpty/utempter

2015-12-06 Thread René J . V . Bertin
On Sunday December 06 2015 21:52:21 David Faure wrote: > > Question is, how useful is this in KPty? > > `utempter is a privileged helper program that writes utmp/wtmp entries for > unprivileged programs.` I can read, you know ;) > > Does utmp or wtmp exist on OSX? > Hmm, yes, but deprecated

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

2015-12-06 Thread David Faure
On Sunday 06 December 2015 21:55:44 René J.V. Bertin wrote: > On Sunday December 06 2015 14:51:40 David Faure wrote: > > > Here is an easy way to test this: do the same change for kiod in kio (it's > > like a mini kded) and then > > cd kio/tests ; ./listjobtest ftp://t...@upload.kde.org > >

Re: kpty/utempter

2015-12-06 Thread David Faure
On Sunday 06 December 2015 22:00:09 René J.V. Bertin wrote: > On Sunday December 06 2015 21:52:21 David Faure wrote: > > > > Question is, how useful is this in KPty? > > > > `utempter is a privileged helper program that writes utmp/wtmp entries for > > unprivileged programs.` > > I can read,