Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Icons Missing

Hi, Firstly sorry for breaking threading (I'm not on list and couldn't find a easy way to reply, please cc me in replies). I am the enlightenment maintainer for openSUSE and I am hitting the same issues running many of the programs I use daily under enlightenment (Dolphin, kate, ...). In

system tray test?

Hi, Does KF5 provide any classes above Qt's for putting up and controlling an icon (with/out menu) in the "system tray"? If so, is there a simple test app I can try? Reason I'm asking: kwalletmanager5 isn't showing a systray interface like kwalletmanager(4) does. Not on OS X (where Qt5's

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

Hi Mark, Sorry to jump in the discussion. It's totally fine you found frameworkintegration currently also useful for other desktop. But in this specific case, if you want to achieve the same feature in some other desktop, it would be better to make a fork of frameworkintegration. Currently

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Review Request 126312: Add xcb variant for static KStartupInfo::sendFoo methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126312/ --- Review request for KDE Frameworks, kwin and David Faure. Repository:

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: system tray test?

On Friday, December 11, 2015 12:19:51 PM René J.V. Bertin wrote: > Does KF5 provide any classes above Qt's for putting up and controlling an > icon (with/out menu) in the "system tray"? If so, is there a simple test > app I can try? > > Reason I'm asking: kwalletmanager5 isn't showing a systray

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Review Request 126313: Use an xcb for interaction with KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126313/ --- Review request for KDE Frameworks and David Faure. Repository: kinit

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:42 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 1:59 p.m.) Review request for KDE Software on

Re: Review Request 126246: Add test for dynamically changing file definitions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89354 --- Ship it! Ship It! autotests/packagestructuretest.cpp (line

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126308/ --- (Updated Dec. 11, 2015, 5:26 p.m.) Review request for KDE Software on

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 61 > > > > > > unrelated and it won't leak, since the cleanup is done by the > > parent/child relation ("this" passed

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 11, 2015, 2:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 36 > > > > > > unrelated and not required Not required indeed, but related in the sense that it removes any ambiguity

kwidgetsaddons on OS X: menus become menu items

Hi, After building kate I'm seeing repeating messages like the ones below on the calling terminal, using either Kate or KWrite. This also happens with Christoph's bundle(d) build. (I've patched my Qt build to be more informative though). void QCocoaMenu::insertNative(QCocoaMenuItem *,

Re: kwidgetsaddons on OS X: menus become menu items

On Friday December 11 2015 23:55:35 René J.V. Bertin wrote: KActionMenu being derived from QWidgetAction I wonder if the following blurb from the QWidgetAction documentation is relevant here: OS X: If you add a widget to a menu in the application's menu bar on OS X, the widget will be added

Review Request 126314: Port klauncher to xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126314/ --- Review request for KDE Frameworks and David Faure. Repository: kinit

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/#review89369 --- i had the similar problem after commit f35e514 (only empty

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Dec 2015 17:28:27 + Build duration: 1 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Dec 2015 17:28:27 + Build duration: 1 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 28 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 11 Dec 2015 17:28:27 + Build duration: 56 sec CHANGE SET No changes

kdebugdialog5 crashing on exit (FYI)

Hi, I mentioned having crashes on exit with kdebugdialog5 a couple of days ago, deep in Qt territory. At first I thought the culprit was my implementation of a "KdeMacPlatformTheme" that inherits from the regular KdePlatformTheme. Then I noticed that kdebugdialog5 also crashes on exit on

Re: Review Request 126246: Add test for dynamically changing file definitions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/ --- (Updated Dec. 11, 2015, 6:03 p.m.) Status -- This change has been

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 10, 2015, 11:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogButtonBoxPrivate::createButton() seems to

Re: system tray test?

Sebastian Kügler wrote: > Not sure what exactly you mean with "putting up and controlling an icon in the > system tray", but we do have a status notifier test app, you can find it in: > plasma-workspace/applets/systemtray/tests/statusnotifier Heh, that must be because I asked the question in one

Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126320/ --- Review request for KDE Frameworks, Plasma and Alex Richardson.