Re: Review Request 126509: Silence Coverity warning about risk of buffer overflow by shrinking source buffer and using qstrncpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126509/#review90079 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 25, 2015,

Review Request 126508: kdesu: Fix fd leaks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126508/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Review Request 126508: kdesu: Fix fd leaks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126508/#review90078 --- Ship it! And more things than you'd think still use

Review Request 126509: Silence Coverity warning about risk of buffer overflow by shrinking source buffer and using qstrncpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126509/ --- Review request for KDE Frameworks. Repository: kinit Description

Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/ --- Review request for KDE Frameworks and David Faure. Repository: kio

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 25 Dec 2015 03:53:22 + Build duration: 1 min 28 sec CHANGE SET Revision

Re: Review Request 126508: kdesu: Fix fd leaks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126508/ --- (Updated Dec. 25, 2015, 3:54 a.m.) Status -- This change has been

Re: Review Request 126509: Silence Coverity warning about risk of buffer overflow by shrinking source buffer and using qstrncpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126509/ --- (Updated Dec. 25, 2015, 3:53 a.m.) Status -- This change has been

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 32 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 25 Dec 2015 03:53:22 + Build duration: 1 min 28 sec CHANGE SET Revision

Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/ --- Review request for KDE Frameworks. Repository: kdelibs4support

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Dec. 24, 2015, 10:30 a.m., Christian Ehrlicher wrote: > > src/lib/io/kurlmimedata.cpp, line 59 > > > > > > const? Or would this be an ABI breakage? Yes, that can't be changed now. Not because of ABI, but

Re: KHolidays as Framework (redux)

On Thu, Dec 24, 2015 at 1:28 PM, John Layt wrote: > Hi, > > It's xmas holidays, so it must be time to poke a stick at KHolidays again > for inclusion as a Framework. As far as I am aware there are no outstanding > porting issues with KHolidays and it is ready for review to be

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90080 --- If making the destructor virtual doesn't break ABI, I'd vote

Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- Review request for KDE Frameworks, KDE Usability, Christoph Feck, David

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/ --- (Updated Dec. 24, 2015, 5:55 p.m.) Review request for KDE Frameworks,

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review90049 --- src/lib/io/kbackup.cpp (line 114)

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Дек. 24, 2015, 11:58 д.п.) Review request for KDE Frameworks

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 24, 2015, 9:30 д.п., Christian Ehrlicher wrote: > > I corrected the warning Clazy, so what about the first three issues, I do not know anything. 4 issue is fixed. - Andrey --- This is an automatically generated e-mail. To

KHolidays as Framework (redux)

Hi, It's xmas holidays, so it must be time to poke a stick at KHolidays again for inclusion as a Framework. As far as I am aware there are no outstanding porting issues with KHolidays and it is ready for review to be included as a Tier 1 Framework in the next possible release. What's the next

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review90060 --- src/lib/io/kbackup.cpp (line 86)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 183 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/183/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Dec 2015 13:39:20 + Build duration: 4 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 191 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Dec 2015 13:39:20 + Build duration: 5 min 17 sec CHANGE SET Revision 99ebe0e6450297b209881b957df9b5a1258d98ee

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the