Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-28 Thread Marco Martin
> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 28, 2015, 9:37 a.m.) Review request for Build System, KDE

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-28 Thread Kai Uwe Broulik
> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

2015-12-28 Thread Andrey Cygankov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/ --- (Updated Dec. 28, 2015, 1:40 p.m.) Status -- This change has been

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:50:07 + Build duration: 1 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:50:07 + Build duration: 1 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 25 - Failure!

2015-12-28 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/25/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 15:13:52 + Build duration: 1 min 33 sec CHANGE SET Revision

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 33 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:50:07 + Build duration: 49 sec CHANGE SET Revision 15e16c09a672d82a52fee0bc2cc8a6d8d0eb3269

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- (Updated Dec. 28, 2015, 2:20 p.m.) Review request for KDE Frameworks.

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 38 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 14:40:12 + Build duration: 1 min 19 sec CHANGE SET Revision 27b24ea8d1925aec843ac337617a1b18469b8dfa

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 38 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 14:40:12 + Build duration: 1 min 19 sec CHANGE SET Revision 27b24ea8d1925aec843ac337617a1b18469b8dfa

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

2015-12-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/#review90216 --- I'd say 'Ship it' on this, or wait for D. Faure. (iirc, he is

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 27 - Failure!

2015-12-28 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 15:13:52 + Build duration: 1 min 8 sec CHANGE SET Revision

Re: Review Request 126343: KPluginMetaData: Add fields used by KAboutData and introduce conversion function

2015-12-28 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126343/ --- (Updated Dec. 28, 2015, 4:08 p.m.) Status -- This change has been

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 16:15:57 + Build duration: 2 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 28 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 16:15:57 + Build duration: 2 min 18 sec CHANGE SET Revision

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review90237 --- Could you post a patch with the JSON files? I'll look into

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 16:15:57 + Build duration: 58 sec CHANGE SET Revision

Jenkins-kde-ci: threadweaver master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-12-28 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/threadweaver%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 16:15:57 + Build duration: 58 sec CHANGE SET Revision

Re: Review Request 126185: Make the KAppTemplate CMake module global

2015-12-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90260 --- Ship it! OK, just one line break in the docs, then it can go

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 76 - Failure!

2015-12-28 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 22:37:24 + Build duration: 1 min 26 sec CHANGE SET Revision

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:14 nachm.) Review request for KDE Frameworks,

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Dec. 28, 2015, 7:25 p.m.) Review request for KDE Frameworks,

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

2015-12-28 Thread Christoph Cullmann
> On Dec. 28, 2015, 5:20 p.m., Alex Richardson wrote: > > Could you post a patch with the JSON files? I'll look into implementing the > > translations then. Hi, atm my local build is broken, so no new patch, but I have attached the converted trash.protocol result. - Christoph

Re: Splitting KActivities, 2nd attempt...

2015-12-28 Thread David Faure
Sounds good overall, but one question: On Sunday 08 November 2015 12:04:54 Ivan Čukić wrote: > Hi everybody, > > We have a few problems at the moment because all the activities > components are in a single repository. Sometimes dependencies of the > service creep up into the library, builds

Review Request 126555: Remove unused variable in KConfigPrivate

2015-12-28 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126555/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Review Request 126556: Ensure group is unescaped properly in kconf_update.

2015-12-28 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126556/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:34 nachm.) Review request for KDE Frameworks,