Re: Review Request 126403: Get rid of QApplication dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 2, 2016, 9:57 a.m.) Review request for KDE Frameworks,

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/#review90435 --- src/properties.h (line 215)

Re: Review Request 126426: Add a warning color to kwalletd's password dialogs

> On Jan. 1, 2016, 5:04 p.m., David Faure wrote: > > Ship It! David, could you have a look to RR 126505, before I ship this one? (btw, the 5.18 tagging is today?) - Elvis --- This is an automatically generated e-mail. To reply, visit:

closest equivalent to KApplicationPrivate::init() ?

Morning! Is there anything like a closest equivalent to KApplicationPrivate::init() in KF5 Frameworks? I added a "bring application to the foreground" call (to a KWindowSystem helper function) in there, which alleviated the issue of applications remaining somewhere in the background on OS X.

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 13:46:17 René J.V. Bertin wrote: > On Saturday January 02 2016 12:50:59 David Faure wrote: > > > > I added a "bring application to the foreground" call (to a KWindowSystem > > > helper function) in there, which alleviated the issue of applications > > > remaining

Re: Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/#review90441 --- Ship it! Ship It! - David Faure On Dec. 27, 2015, 2:40

Re: Review Request 126161: OS X housekeeping

> On Dec. 25, 2015, 2:42 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit_mac.mm, lines 662-666 > > > > > > I'd love to add `[NSApp activateIgnoringOtherApps:YES]` and/or `[NSApp > > unhide]` here, preceded

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

> On Jan. 2, 2016, 9:59 vorm., David Edmundson wrote: > > src/properties.h, line 215 > > > > > > adding an enum value in the middle breaks API where can I place it? the last entry of course must stay last. -

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: Review Request 126314: Port klauncher to xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126314/#review90445 --- Ship it! Ship It! - David Faure On Dec. 11, 2015, 3:10

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 7:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

test failures on http://ci-logs.kde.flaska.net

On Saturday 07 November 2015 21:42:33 Jan Kundrát wrote: > > > Can you the value of > > QMimeDatabase().mimeTypeForName("text/plain").preferredSuffix() > > on your system? Here's it's "txt", I suspect it's "doc" on your > > system. Not sure why yet > > though, but let's first check that. Ah, I

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 10:49:59 René J.V. Bertin wrote: > Morning! > > Is there anything like a closest equivalent to KApplicationPrivate::init() in > KF5 Frameworks? Yes, QApplicationPrivate::init() :-) > I added a "bring application to the foreground" call (to a KWindowSystem > helper

Re: Review Request 126161: OS X housekeeping

> On Dec. 25, 2015, 3:42 p.m., René J.V. Bertin wrote: > > src/kdeinit/kinit_mac.mm, lines 662-666 > > > > > > I'd love to add `[NSApp activateIgnoringOtherApps:YES]` and/or `[NSApp > > unhide]` here, preceded

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: Review Request 126170: [OS X] make kded5 an agent, and build it as a regular application instead of an app bundle

> On Dec. 2, 2015, 8:51 a.m., David Faure wrote: > > Please kind in mind that kded must be able to pop up dialogs, though. > > (cookie dialog, SSL cert messagebox + dialog, etc. etc.). > > > > If making it an "agent" doesn't prevent it from showing GUI elements now > > and then, then no

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 12:50:59 David Faure wrote: > > I added a "bring application to the foreground" call (to a KWindowSystem > > helper function) in there, which alleviated the issue of applications > > remaining somewhere in the background on OS X. > > I'm still keeping an eye out for

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 14:14:19 David Faure wrote: >Sounds to me like you're saying "better bring all apps to front than none". Yes, but also that I think that practice should be more subtle than that if we manage to use LaunchServices consistently where it's appropriate. Disregarding of

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, > Hi, > > > I have gotten a bit further. As I thought it is critical to have a correct > Info.plist (or else the event is never sent), and it isn't trivial to edit > that > file "in place" and have the system recognise its new content (easiest way is > to copy the entire app bundle in the

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/#review90467 --- Ship it! Ship It! - David Faure On Jan. 2, 2016, 4:02

Re: Review Request 126028: Add support for desktopFileName to NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126028/#review90472 --- Ship it! Sorry, forgot to review this earlier. The @since

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, > On Saturday January 02 2016 19:56:28 Christoph Cullmann wrote: > > Hi, > > >> I have added this now just to KateApp. >> >> https://quickgit.kde.org/?p=kate.git=commit=cd6ec201725cf627a336015d472c39f5ff73b2a7 > > Hmm, thanks for the hint with the Info.plist? You mean you already knew

Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/ --- Review request for KDE Frameworks. Repository: kitemviews Description

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: > Besides: No need for ifdefs, QFileOpenEvent is there on all platforms, just > without function. True, but there's no point in installing an event filter for it on platforms where the event never occurs. > But you are aware that

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday 02 January 2016 15:59:04 René J.V. Bertin wrote: > On Saturday January 02 2016 14:14:19 David Faure wrote: > >Maybe, maybe not, but what we need to continue this discussion is hard data. > >1) what does QProcess on Mac do (always in front, always in background, > >depends on whether

Re: Review Request 120139: kill warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120139/#review90476 --- IMHO the warning is not totally pointless, and it should be

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 19:56:28 Christoph Cullmann wrote: Hi, > I have added this now just to KateApp. > > https://quickgit.kde.org/?p=kate.git=commit=cd6ec201725cf627a336015d472c39f5ff73b2a7 Hmm, thanks for the hint with the Info.plist? You mean you already knew about the rest? :) >

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

> On Gen. 2, 2016, 7:31 p.m., Sune Vuorela wrote: > > Looks much better than my attempt over in > > https://git.reviewboard.kde.org/r/120139 Note my patch does not remove the warnings on close, although I found out how to avoid them: to the KWidgetItemDelegate construr, either pass a null

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/ --- (Updated Jan. 2, 2016, 4:02 p.m.) Review request for KDE Frameworks.

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, I have gotten a bit further. As I thought it is critical to have a correct Info.plist (or else the event is never sent), and it isn't trivial to edit that file "in place" and have the system recognise its new content (easiest way is to copy the entire app bundle in the Finder). You also

Re: closest equivalent to KApplicationPrivate::init() ?

On Saturday January 02 2016 17:14:07 David Faure wrote: > While I like the general approach of reading source code, what I meant here > was *testing*. > If it behaves like you want it to behave, that's perfect, no need to > understand every line of its code to assess that. OK, hard *empirical*

Re: Review Request 126610: kwidgetitemdelegate: properly cleanup widgets on index removal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review90477 --- Looks much better than my attempt over in

Re: Review Request 120139: kill warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120139/ --- (Updated Jan. 2, 2016, 7:32 p.m.) Status -- This change has been

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

Hi, > On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: > >> Besides: No need for ifdefs, QFileOpenEvent is there on all platforms, just >> without function. > > True, but there's no point in installing an event filter for it on platforms > where the event never occurs. That small

Re: [KDE/Mac] new year's resolution: opening files "the Mac way" (TM)

On Saturday January 02 2016 20:24:25 Christoph Cullmann wrote: Hi, Something else: is the KateApp supposed to be subclassable? In that case you may want to put the FileOpen event back into the queue rather than eating it (i.e. return false instead of true from the event filter), so that the

Re: Review Request 126474: Port QRegExp to QRegularExpression in kshorturifilter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126474/ --- (Updated Jan. 2, 2016, 10:32 p.m.) Status -- This change has been

Re: Review Request 126507: Fix leaked file description and potential use-after-free in kdelibs4support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126507/ --- (Updated Jan. 2, 2016, 11:29 p.m.) Status -- This change has been

Re: [KDE/Mac] "offending" menu items

Hi again, Remember those 2 menu items that caused repeating error messages on the terminal? Turns out that whatever it is that causes it exactly can in fact make the application crash (I saw that with Konsole), but I also found a workaround. Someone could have told me that this kind of action