Re: Review Request 126648: Allow to disable KArchive for internal usage

2016-01-06 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/ --- (Updated Gen. 6, 2016, 10:33 p.m.) Review request for Build System, KDE F

Re: Review Request 126648: Allow to disable KArchive for internal usage

2016-01-06 Thread Luigi Toscano
> On Gen. 6, 2016, 8:33 a.m., David Faure wrote: > > src/xslt_kde.cpp, line 17 > > > > > > I would suggest to add a qWarning() under this line, to warn at runtime > > in case this is ever called in a non-karchive

Re: Draft split for qpt plugin from frameworkintegration

2016-01-06 Thread Albert Astals Cid
El Friday 18 December 2015, a les 10:03:39, Martin Graesslin va escriure: > On Thursday, December 17, 2015 5:48:47 PM CET Martin Graesslin wrote: > > On Thursday, December 17, 2015 4:32:48 PM CET Aleix Pol wrote: > > > On Wed, Dec 16, 2015 at 4:12 PM, Martin Graesslin > > > > wrote: > > > > Hi al

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-06 Thread Martin Klapetek
> On Jan. 6, 2016, 3:59 p.m., Kai Uwe Broulik wrote: > > autotests/fakePMServer.cpp, line 23 > > > > > > PowerDevil never returns the same cookie more than once, ie. it's just > > ++m_cookieId; Well I don't thin

Re: Review Request 126385: PartManager: stop tracking a widget even if it is no longer a top level window

2016-01-06 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126385/ --- (Updated Jan. 6, 2016, 6:04 p.m.) Status -- This change has been mar

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-06 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/ --- (Updated Jan. 6, 2016, 5:34 p.m.) Review request for KDE Frameworks, kwin

Re: Review Request 126403: Get rid of QApplication dependency

2016-01-06 Thread Thomas Lübking
> On Jan. 4, 2016, 7:42 a.m., Martin Gräßlin wrote: > > anyone tested this on an "affected system"? > > Albert Astals Cid wrote: > I have not, I thought you had made it clear in the past you thought it > was a bad idea since it was all supposed to be widget based anyway. > > Thomas Lübking

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review90697 --- Nice! I'm wondering how could add additional platform support

Re: Review Request 126651: Fix wrong documentation for KIconTheme::iconPath

2016-01-06 Thread Holger Kaelberer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126651/ --- (Updated Jan. 6, 2016, 8:28 a.m.) Review request for KDE Frameworks. Re

Review Request 126651: Fix wrong documentation for KIconTheme::iconPath

2016-01-06 Thread Holger Kaelberer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126651/ --- Review request for KDE Frameworks. Repository: kiconthemes Description