Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/#review91089 --- +1 from me though maybe clearActions fits Qt conventions a

Review Request 126745: Fix karchive autotests on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126745/ --- Review request for KDE Frameworks. Repository: karchive Description

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Review Request 126747: Drop use of deprecated Qt functions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126747/ --- Review request for KDE Frameworks. Repository: polkit-qt-1 Description

Re: Review Request 126746: Fix compilation with Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126746/#review91098 --- CMakeLists.txt (line 36)

Re: Review Request 126746: Fix compilation with Qt5.6

> On Jan. 14, 2016, 5:48 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 36 > > > > > > Can't this be -std=c++11 by now? It possibly could, but I opted for copying the same line as

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/#review91095 --- Ship it! src/scriptengines/qml/plasmoid/appletinterface.h

Re: Review Request 126742: Add removeAllActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/#review91096 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (line

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Review Request 126746: Fix compilation with Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126746/ --- Review request for KDE Frameworks. Repository: polkit-qt-1 Description

Re: KIOGui ?

On Thursday 14 January 2016 02:53:09 Friedrich W. H. Kossebau wrote: > Am Mittwoch, 13. Januar 2016, 00:33:36 schrieb David Faure: > > I'm about to write a class to handle favicons in a KIO library, rather than > > using DBus communication to a (currently kded, could be kiod otherwise) > > module.

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 8:52 д.п.) Review request for KDE Frameworks and

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91055 --- does the svg stuff still workk? this script goes well

Re: Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126723/ --- (Updated Jan. 14, 2016, 11:02 a.m.) Status -- This change has been

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/ --- (Updated Jan. 14, 2016, 12:21 p.m.) Review request for KDE Frameworks

Reminder: Please add "Since" version info also to cmake macros and arguments

Hi, please remember to add some info about for which version of KF5 or ECM a new cmake macro or argument was added (or changed behaviour). So people with a newer version of ECM/KF5 installed on their system, but working on a software using ECM/KF5 with lower minimal version requirements can

Review Request 126737: Fix most Clazy warnings in KItemViews.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

> On Jan. 12, 2016, 10:49 p.m., David Faure wrote: > > Can I see the backtrace, with a description of how this gets triggered? I'm > > not sure the issue is fully understood (as shown by the use of "might" in > > the description...). > > > > Is the action being destroyed by clicking into a

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91051 --- tests/proxymodeltestapp/proxyitemselectionwidget.cpp (line

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Making polkit-qt-1 a tier1 framework

Hi all, I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. Reasons are: * kdesupport is basically what became tier1 in frameworks * it's used by other frameworks, e.g. KAuth (tier 2) and in kde/workspace * polkit-qt-1 is currently in a not really released state (last

Review Request 126742: Add removeAllActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 10:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to

Re: Making polkit-qt-1 a tier1 framework

On Thu, Jan 14, 2016 at 1:20 PM, Martin Gräßlin wrote: > Hi all, > > I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. > Reasons are: > > * kdesupport is basically what became tier1 in frameworks > * it's used by other frameworks, e.g. KAuth (tier 2) and

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91073 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016,

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to

Re: Review Request 126740: Add a script for optimizing svgs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91064 --- I have no problems to optimzie the svg files BUT my problem

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 5:48 a.m., Dirk Hohndel wrote: > > I think this is a good idea - but just a small side note, this does not > > solve the problem that my patch addressed; the external references to > > linearGradients are not removed by svgo > > > > /D Good to know! Maybe we should ask

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: Making polkit-qt-1 a tier1 framework

Hello, On Thursday, 14 January 2016 13:20:01 CET Martin Gräßlin wrote: > By moving it to frameworks we get closer to getting rid of kdesupport > and get the making releases problem solved once and for all: bug fixes > will get to users in a timely manner. > > Opinions? Personally I like it.

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 1:03 p.m., Sergio Martins wrote: > > Ship It! Can you push it in two different commits ? One for the QStringLiteral change and another for the isEmpty() - Sergio --- This is an automatically generated e-mail. To

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/#review91076 --- Ship it! Ship It! - Sergio Martins On Jan. 14, 2016,

Re: Making polkit-qt-1 a tier1 framework

On Thu, 14 Jan 2016 13:20:01 +0100, Martin Gräßlin wrote: Hi all, I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. Reasons are: * kdesupport is basically what became tier1 in frameworks * it's used by other frameworks, e.g. KAuth (tier 2) and

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 1:22 p.m., andreas kainz wrote: > > I have no problems to optimzie the svg files BUT my problem with the svg > > files is that they become more complex all the time last time the > > stylesheet, now optimization, > > > > I love scripts BUT it would be awesome for us

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/#review91067 --- Looks good, I'll add Sergio, he maybe can explain what the

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 9:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All

Re: Review Request 126740: Add a script for optimizing svgs

> On Jan. 14, 2016, 11:27 a.m., Marco Martin wrote: > > does the svg stuff still workk? > > this script goes well together the others i have (only in plasma-framework > > atm) to remove the hardcoded colors inkscape likes to put even when an > > element is using the stylesheet and the one to

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 1:03 p.m., Sergio Martins wrote: > > Ship It! > > Sergio Martins wrote: > Can you push it in two different commits ? One for the QStringLiteral > change and another for the isEmpty() Regarding the qDeleteAll(), the correct way is

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126397: [xcb] Safety check whether we have a QApplication in mapViewport

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126397/ --- (Updated Jan. 14, 2016, 2:59 p.m.) Status -- This change has been

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 1:35 p.m., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 2:03 p.m., Sergio Martins wrote: > > Ship It! > > Sergio Martins wrote: > Can you push it in two different commits ? One for the QStringLiteral > change and another for the isEmpty() > > Sergio Martins wrote: > Regarding the qDeleteAll(), the correct way is >

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/ --- (Updated Jan. 14, 2016, 11:04 p.m.) Status -- This change has been

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/#review91122 --- Ship it! do you have commit access? - David Edmundson On

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126742/ --- (Updated Jan. 15, 2016, 1:52 a.m.) Review request for KDE Frameworks and

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 1:03 п.п., Sergio Martins wrote: > > Ship It! > > Sergio Martins wrote: > Can you push it in two different commits ? One for the QStringLiteral > change and another for the isEmpty() > > Sergio Martins wrote: > Regarding the qDeleteAll(), the correct way is >

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126736: Fix all Clazy warnings in KFileMetadata.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126736/ --- (Updated Jan. 14, 2016, 11:15 p.m.) Status -- This change has been

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/ --- (Updated Jan. 14, 2016, 11:21 p.m.) Status -- This change has been

Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126750/ --- Review request for KDE Frameworks. Bugs: 355310

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126737/ --- (Updated Янв. 14, 2016, 10:40 п.п.) Review request for KDE Frameworks,

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Янв. 14, 2016, 12:07 д.п., Aleix Pol Gonzalez wrote: > > These look good. You wrote "most". Which warnings couldn't you fix? > > Andrey Cygankov wrote: > log file sent > > Aleix Pol Gonzalez wrote: > >

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Jan. 14, 2016, 11:16 p.m.) Status -- This change has been

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/ --- (Updated Янв. 14, 2016, 11 п.п.) Review request for KDE Frameworks and

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126750/#review91124 --- > The KIconDialog itself works fine, but the "Browse..." sub

Re: Review Request 126746: Fix compilation with Qt5.6

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126746/#review91112 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14, 2016,

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Янв. 14, 2016, 12:35 п.п., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >

Re: Making polkit-qt-1 a tier1 framework

Am 2016-01-14 18:40, schrieb David Edmundson: On Thu, Jan 14, 2016 at 12:20 PM, Martin Gräßlin wrote: Hi all, I want to suggest to move polkit-qt-1 [1] from kdesupport to frameworks. Reasons are: * kdesupport is basically what became tier1 in frameworks * it's used by

Re: Review Request 126737: Fix most Clazy warnings in KItemViews.

> On Jan. 14, 2016, 12:35 p.m., Aleix Pol Gonzalez wrote: > > Looks good, I'll add Sergio, he maybe can explain what the warning meant in > > the first place. > > > > Andrey, Are you sure you fixed all the warnings? I found some missing, for > > example: > >