Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 311 > > > > > > So this means that we either pass an empty image, or an outdated one? > >

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 395 > > > > > > DPI-dependent, could be shared with the above > > David Rosca wrote: >

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 311 > > > > > > So this means that we either pass an empty image, or an outdated one? > >

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 311 > > > > > > So this means that we either pass an empty image, or an outdated one? > >

Re: Review Request 126738: Remove external dependencies from svgs

2016-01-21 Thread Aleix Pol Gonzalez
> On Jan. 14, 2016, 5:51 a.m., Dirk Hohndel wrote: > > this will need to be done for dozens more SVGs - I sent the four that I > > needed for my app for review, but if this change gets accepted I'll > > volunteer to rewrite all of the SVGs that contain external references. It > > just seemed

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-21 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91416 --- optimize.svg.sh (line 1)

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91400 --- Ow nice, I recall working on this during the initial Plasma5

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 390 > > > > > > Q_FOREACH and const& > > David Rosca wrote: > But the value is not used

Re: Review Request 126738: Remove external dependencies from svgs

2016-01-21 Thread andreas kainz
> On Jan. 14, 2016, 4:51 vorm., Dirk Hohndel wrote: > > this will need to be done for dozens more SVGs - I sent the four that I > > needed for my app for review, but if this change gets accepted I'll > > volunteer to rewrite all of the SVGs that contain external references. It > > just seemed

Review Request 126836: DropArea: Fix correctly ignoring dragEnter event with preventStealing

2016-01-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126836/ --- Review request for KDE Frameworks. Repository: kdeclarative

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/ --- (Updated Jan. 21, 2016, 2:26 p.m.) Review request for KDE Frameworks.

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
> On Jan. 21, 2016, 2:47 p.m., Sebastian Kügler wrote: > > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 402 > > > > > > With many urls in the mimedata, this could produce a very wide pixmap. > > I

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/ --- (Updated Jan. 21, 2016, 3:06 p.m.) Status -- This change has been

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91417 --- Fix it, then Ship it!

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 72 - Fixed!

2016-01-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 15:07:14 + Build duration: 1 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 72 - Fixed!

2016-01-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 15:07:14 + Build duration: 1 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 73 - Fixed!

2016-01-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 15:07:14 + Build duration: 1 min 42 sec CHANGE SET Revision

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 73 - Fixed!

2016-01-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/73/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 15:07:14 + Build duration: 1 min 42 sec CHANGE SET Revision

Re: Review Request 126813: Fix build with older polkit

2016-01-21 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review91431 --- Looks good. - David Jarvie On Jan. 21, 2016, 4:24 p.m.,

Re: Deadlock in kded whith Qt 5.6

2016-01-21 Thread Thiago Macieira
On Thursday 21 January 2016 08:37:38 David Faure wrote: > > I didn't see any "invoking message spies" of the debug I left. Are you > > sure > > this had the hook installed? > > You mean the messageFilter? That's exactly the issue, that it's not getting > called. Therefore autoload doesn't happen.

Re: Deadlock in kded whith Qt 5.6

2016-01-21 Thread Ralf Habacker
Am 21.01.2016 um 08:37 schrieb David Faure: > > With this patch applied, here's one log for the first call > (autostart+autoload, doesn't work) > > http://www.davidfaure.fr/2016/first_call.txt > > and one log for the second call (kded already started, autoload works) > >

Re: Deadlock in kded whith Qt 5.6

2016-01-21 Thread Thiago Macieira
On Thursday 21 January 2016 08:37:38 David Faure wrote: > On Wednesday 20 January 2016 08:41:31 Thiago Macieira wrote: > > On Wednesday 20 January 2016 09:08:38 David Faure wrote: > > > > Can you run with QDBUS_DEBUG=1 and tell me the messages it prints? > > > > [cut] > > > > I didn't see any