Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andreas Hartmetz
On Mittwoch, 27. Januar 2016 17:21:33 CET Boudewijn Rempt wrote: [snip] > whether kglobalshortcuts is functional or not is besides the point: > the point is that whether it works or not it doesn't add any > functionality to the average application. Global shortcuts are useful > only for a very

Re: opening dialogs using a "foreign" WId

2016-01-27 Thread René J . V . Bertin
Martin Graesslin wrote: > That depends on the Wayland compositor. In Plasma (KWin) we will certainly > make sure this works properly. I'd appreciate if that could be done in a way that makes sense on other platforms too... > But yes currently it most likely will open > somewhere behind just

Re: KCoreAddons qml plugins

2016-01-27 Thread David Faure
On Wednesday 27 January 2016 18:19:49 Aleix Pol wrote: > Hi, > I would like to move KCoreAddons qml plugin into KCoreAddons. Now it's > KDeclarative where we are dumping all QML plugins. > > I think it's a good idea because: > - it simplifies usage the plugins for such frameworks (kcoreaddons is

API review: FavIconManager vs FavIconHostRequestJob

2016-01-27 Thread David Faure
I'm working on a replacement for the favicons kded module (which lives in libkonq), which will be a class in kio instead (proper C++ API certainly beats just a DBus interface as public API). I started from the DBus API of the kded module, cleaned up a number of things (in particular the awful

Re: kconfig question

2016-01-27 Thread Matthew Dawson
On Wednesday, January 27, 2016 10:32:50 AM EST Boudewijn Rempt wrote: > On Sat, 23 Jan 2016, David Faure wrote: > > (I don't mean "it's called KConfig" ;-) I mean what does the code using > > it, look like? I think this needs some debugging to find out where this > > "local" string comes from)

Re: Review Request 126887: Fix crash if KWindowSystem::mapViewport is called without a QCoreApplication

2016-01-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126887/ --- (Updated Jan. 27, 2016, 9:07 a.m.) Status -- This change has been

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126908: Change licence header from "Library GPL 2 or later" to "Lesser GPL 2.1 or later"

2016-01-27 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126908/#review91668 --- Ship it! Ship It! - Jonathan Riddell On Jan. 27, 2016,

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Boudewijn Rempt
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

KCoreAddons qml plugins

2016-01-27 Thread Aleix Pol
Hi, I would like to move KCoreAddons qml plugin into KCoreAddons. Now it's KDeclarative where we are dumping all QML plugins. I think it's a good idea because: - it simplifies usage the plugins for such frameworks (kcoreaddons is not the only one). - it ensures the code related to a feature is

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Boudewijn Rempt
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Boudewijn Rempt
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-27 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126675/ --- (Updated Jan. 27, 2016, 9:48 a.m.) Review request for KDE Frameworks and

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126895/ --- (Updated Jan. 27, 2016, 8:53 a.m.) Review request for KDE Frameworks.

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Andre Heinecke
> On Jan. 27, 2016, 7:02 a.m., Martin Gräßlin wrote: > > Just in case that there is misunderstanding going on: > > > > > Global Shortcuts (we don't have kded so this won't work for us anyway) > > > > Global shortcut handling does not depend on kded! > > > > Also I want to point out to > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-27 Thread Martin Gräßlin
> On Jan. 27, 2016, 8:02 a.m., Martin Gräßlin wrote: > > Just in case that there is misunderstanding going on: > > > > > Global Shortcuts (we don't have kded so this won't work for us anyway) > > > > Global shortcut handling does not depend on kded! > > > > Also I want to point out to > >

Re: opening dialogs using a "foreign" WId

2016-01-27 Thread René J . V . Bertin
Kai Uwe Broulik wrote: Hi, >> ‎Are there other platforms where WIds cannot be used for this kind of use >> case (MS Windows for instance)? > > Wayland.‎ So how do the dialogs behave when, say, kwalletmanager asks kwalletd to unlock a locked keychain and a password or passphrase is required?

Re: opening dialogs using a "foreign" WId

2016-01-27 Thread Martin Graesslin
On Wednesday, January 27, 2016 3:45:12 PM CET René J. V. Bertin wrote: > Kai Uwe Broulik wrote: > > Hi, > > >> ‎Are there other platforms where WIds cannot be used for this kind of use > >> case (MS Windows for instance)? > > > > Wayland.‎ > > So how do the dialogs behave when, say,

Re: Review Request 126903: Fix buddy widgets working with KFontRequester

2016-01-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126903/#review91664 --- +1 Smells like a bug in Qt? - Aleix Pol Gonzalez On Jan.

Re: kconfig question

2016-01-27 Thread Boudewijn Rempt
On Sat, 23 Jan 2016, David Faure wrote: Not sure this answers Boud's question, since he *is* seeing "Local" on Windows. He said: "I noticed that krita on windows wrote its kritarc to Roaming\local\ or Local\local " Hm, looks like that was a sideeffect of something else I tried, it's now in

Review Request 126903: Fix buddy widgets working with KFontRequester

2016-01-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126903/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Review Request 126908: Change licence header from "Library GPL 2 or later" to "Lesser GPL 2.1 or later"

2016-01-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126908/ --- Review request for KDE Frameworks and Jonathan Riddell. Repository: