Re: I'm missing the favicons interface

On Friday, February 19, 2016 11:04:21 PM CET David Faure wrote: > On Tuesday 16 February 2016 22:32:18 Robby Stephenson wrote: > > On Tue, Feb 16, 2016 at 5:00 PM, David Faure wrote: > > > I'm curious though, what's the use case for a large favicon? In KDE4 the > > > only > > >

Re: Review Request 127117: Reverse the filtering logic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/#review92625 --- Looks good, can you get a test case in the

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127127/ --- (Updated Feb. 22, 2016, 12:28 a.m.) Review request for KDE Frameworks

Re: RCC for icons - update: Re: Icons installed by apps

On 18 February 2016 at 18:25, Kåre Särs wrote: > On Thursday, February 18, 2016 02:51:58 PM René J.V. Bertin wrote: > > On Thursday February 18 2016 13:55:18 Jaroslaw Staniek wrote: > > >>> > since QIcon::fromTheme() apaprently isn't able to find app icons. > > > > Care to

Re: Review Request 126991: Try multiple authentication methods in case of failures

> On Feb. 21, 2016, 7:07 p.m., Andreas Hartmetz wrote: > > m_triedPasswords doesn't really tell the truth if the application didn't > > supply a password, right? It is not really a number of tried passwords, it > > is the state of a little state machine. In such cases, it is better to make >

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 113 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 19:27:32 + Build duration: 2 min 37 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 113 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 19:27:32 + Build duration: 2 min 37 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 19:27:32 + Build duration: 2 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 19:27:32 + Build duration: 2 min 5 sec CHANGE SET Revision

Re: Review Request 127131: kcoreaddons: Fix many clang warnings

> On Feb. 21, 2016, 6:49 p.m., Michael Pyne wrote: > > Jenkins has reported a build failure > > (https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/console), > > looks like we might have dueling compiler errors: > > > > 18:07:28 > >

Re: Review Request 127131: kcoreaddons: Fix many clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127131/#review92619 --- Jenkins has reported a build failure

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 117 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 17:40:21 + Build duration: 58 sec CHANGE SET Revision

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/#review92617 --- m_triedPasswords doesn't really tell the truth if the

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 112 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/112/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 21 Feb 2016 17:40:21 + Build duration: 50 sec CHANGE SET Revision

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127033/#review92618 --- src/plugins/hunspell/hunspelldict.cpp (line 40)

Re: Review Request 127131: kcoreaddons: Fix many clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127131/ --- (Updated Feb. 21, 2016, 5:39 p.m.) Status -- This change has been

Re: Review Request 127131: kcoreaddons: Fix many clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127131/#review92614 --- Fix it, then Ship it! Looked good to me (so marking as

Re: Review Request 127131: kcoreaddons: Fix many clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127131/#review92613 --- Ship it! Ship It! - David Edmundson On Feb. 21, 2016,

Review Request 127131: kcoreaddons: Fix many clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127131/ --- Review request for KDE Frameworks and Michael Pyne. Repository:

Re: Review Request 126774: Fix many warnings presented by clazy

> On Feb. 21, 2016, 4:52 a.m., Nick Shaforostoff wrote: > > src/core/kprotocolmanager.cpp, line 940 > > > > > > please revert back to QLatin1String, as there is a special overload for > > it. if you really want

Re: Review Request 126774: Fix many warnings presented by clazy

> On Feb. 21, 2016, 4:52 a.m., Nick Shaforostoff wrote: > > src/core/kprotocolinfofactory.cpp, line 114 > > > > > > please use QLatin1String here: there is a special overload for it Yes I already fixed the

Re: Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

On Saturday, February 20, 2016 11:22:48 AM CET Andreas Cord-Landwehr wrote: > Hi, I want to propose to move the KColorScheme class from the KConfigWidgets > famework to the KGuiAddons framework. > > Reasons: > * that would reduce dependencies of KIconThemes and make it > - a Tier 2 framework