Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-02-25 Thread Martin Gräßlin
> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > I don't like the introduction of the SCRAPBOOK. The repository is not the > > place for dead and old code. That's what git already supports with keeping > > the whole history. > > > > We have some autotests for kwindowsystem. Could you

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review92798 --- Ship it! Looks like I totally misunderstood this change.

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Stephen Kelly
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Nicolás Alvarez
> On Feb. 24, 2016, 4:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Aleix Pol Gonzalez
> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Stephen Kelly
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127090: Clean KWalletQuery cmake file

2016-02-25 Thread Aleix Pol Gonzalez
> On Feb. 25, 2016, 7:39 p.m., Hrvoje Senjan wrote: > > This is not 100% correct. KF5DocTools is searched nowhere, so doc subdir is > > now never added. Good catch! Fixed: http://commits.kde.org/kwallet-framework/3ea2c94aa2ab7e01962ad4fb64e1232f9f8e7a55 - Aleix

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Aleix Pol Gonzalez
> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-02-25 Thread René J . V . Bertin
> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > I don't like the introduction of the SCRAPBOOK. The repository is not the > > place for dead and old code. That's what git already supports with keeping > > the whole history. > > > > We have some autotests for kwindowsystem. Could you

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92783 --- src/externalextractor.cpp (line 104)

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Stephen Kelly
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-25 Thread Albert Vaca Cintora
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review92780 --- Ship it! I don't see a reason not to change it. It makes

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/#review92777 --- The logic is more or less sound. You'll have to solve these

Re: Review Request 127090: Clean KWalletQuery cmake file

2016-02-25 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127090/#review92774 --- This is not 100% correct. KF5DocTools is searched nowhere,

Re: Review Request 127179: Add external extractor plugin support

2016-02-25 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127179/ --- (Updated Feb. 25, 2016, 6:32 p.m.) Review request for Baloo, KDE

Re: Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

2016-02-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127180/#review92773 --- Ah so that's it! I think I'm hit by the same issue on my

Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

2016-02-25 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127180/ --- Review request for KDE Frameworks. Repository: kinit Description

Review Request 127177: Compilation fixes for MSVC (2013)

2016-02-25 Thread Thomas Friedrichsmeier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127177/ --- Review request for KDE Frameworks and kdewin. Repository: ki18n

Review Request 127178: Added writer plugin support

2016-02-25 Thread Varun Joshi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127178/ --- Review request for Baloo, KDE Frameworks, Boudhayan Gupta, and Vishesh

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

2016-02-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127121/ --- (Updated Feb. 25, 2016, 12:16 a.m.) Status -- This change has been