> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote:
> > I don't like the introduction of the SCRAPBOOK. The repository is not the
> > place for dead and old code. That's what git already supports with keeping
> > the whole history.
> >
> > We have some autotests for kwindowsystem. Could you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92798
---
Ship it!
Looks like I totally misunderstood this change.
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
> On Feb. 24, 2016, 4:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
> On Feb. 25, 2016, 7:39 p.m., Hrvoje Senjan wrote:
> > This is not 100% correct. KF5DocTools is searched nowhere, so doc subdir is
> > now never added.
Good catch! Fixed:
http://commits.kde.org/kwallet-framework/3ea2c94aa2ab7e01962ad4fb64e1232f9f8e7a55
- Aleix
> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote:
> > I don't like the introduction of the SCRAPBOOK. The repository is not the
> > place for dead and old code. That's what git already supports with keeping
> > the whole history.
> >
> > We have some autotests for kwindowsystem. Could you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127179/#review92783
---
src/externalextractor.cpp (line 104)
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> >
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would
> > expect the libs go in the same place, but maybe the plugins are affected by
> > this? Can you be more specific?
> >
> > Thanks,
>
> Aleix Pol
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92780
---
Ship it!
I don't see a reason not to change it.
It makes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127179/#review92777
---
The logic is more or less sound. You'll have to solve these
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127090/#review92774
---
This is not 100% correct. KF5DocTools is searched nowhere,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127179/
---
(Updated Feb. 25, 2016, 6:32 p.m.)
Review request for Baloo, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127180/#review92773
---
Ah so that's it! I think I'm hit by the same issue on my
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127180/
---
Review request for KDE Frameworks.
Repository: kinit
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127177/
---
Review request for KDE Frameworks and kdewin.
Repository: ki18n
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127178/
---
Review request for Baloo, KDE Frameworks, Boudhayan Gupta, and Vishesh
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127121/
---
(Updated Feb. 25, 2016, 12:16 a.m.)
Status
--
This change has been
20 matches
Mail list logo