Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92881 --- You lost the changes to the other files, in the diff. (missin

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92878 --- sorry, but I don't understand what this review request is abo

Re: Review Request 127211: Properly use static QMaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92877 --- Ship it! Ship It! - Kevin Funk On Feb. 28, 2016, 9:52 p

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/#review92875 --- Ship it! Please put the change into master not into the Pl

Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/ --- Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Mart

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92874 --- src/sycoca/kbuildsycoca.cpp (line 236)

Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/ --- (Updated Feb. 29, 2016, 1:13 a.m.) Review request for KDE Frameworks. C

Re: Review Request 127214: Remove some warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/ --- (Updated Feb. 29, 2016, 1:06 a.m.) Status -- This change has been ma

Re: Review Request 127214: Remove some warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/#review92873 --- Ship it! Ship It! - David Edmundson On Feb. 28, 2016, 1

Review Request 127214: Remove some warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Feb. 28, 2016, 11:22 p.m.) Status -- This change has been m

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review92872 --- Ship it! I'll fix the issues pointed out by Kai and commit

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/plasma/private/packages.cpp, line 99 > > > > > > QByteArrayLiteral and below QByteArrayLiteral is a weird thing, let's not get there. - Aleix ---

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi Albert, 2016-02-28 11:54 GMT+01:00 Albert Astals Cid: > El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced everywhere right now, I think >>

Re: Review Request 126765: Fix some Clazy warnings in KTextEditor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126765/ --- (Updated Feb. 28, 2016, 10:18 p.m.) Status -- This change has been m

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-26 13:25 GMT+01:00 Jan Kundrát: > On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: >> >> This becomes a problem if the read-only data that the QString refers >> to are not there any more, which can happen if the QString was stored >> in a global static object from one

Re: Review Request 126765: Fix some Clazy warnings in KTextEditor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126765/#review92867 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 16, 2016

Review Request 127211: Properly use static QMaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/ --- Review request for Kate and KDE Frameworks. Repository: ktexteditor Des

Re: Review Request 126769: Fix all Clazy warnings in KDED.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126769/ --- (Updated Feb. 28, 2016, 9:38 p.m.) Status -- This change has been ma

Re: Review Request 126772: Fix some Clazy warnings in KService

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126772/ --- (Updated Feb. 28, 2016, 9:30 p.m.) Status -- This change has been ma

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92862 --- src/lib/kaboutdata.cpp (line 993)

Review Request 127210: Fix warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127210/ --- Review request for KDE Frameworks and KDEPIM. Repository: kpeople Descr

Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > > > > > Why? > > Xuetian Weng wrote: > Actually this check is not so reliable if the icon is not rendered with

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated Feb. 28, 2016, 6:15 p.m.) Review request for KDE Software on Mac

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 28, 2016, 5:15 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 127201: Fix svg icon path resolving in IconItem

> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 253 > > > > > > This should be `QSize(32, 32)` as the comment says? I indented to use a size without exact match. > On Feb

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

On Sun, Feb 28, 2016 at 9:50 AM, Stephen Kelly wrote: > Aleix Pol Gonzalez wrote: >>> I think it would be good to have changes be better understood, >>> otherwise we end up with lots of mess. However, it looks like several >>> people really want this, and I don't want to stand in the w

Re: Review Request 127204: [KHintSettings] Disable setting the palette on-the-fly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127204/#review92848 --- Why not fix this in Qt? What's the associated Qt bug report,

Re: QString -> QStringLiteral conversions might make applications crash on exit

El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: > Hi everyone, > > sorry if most of you know about this already, but since it seems that > QStringLiterals are being introduced everywhere right now, I think > that it is important to raise awareness about the fact that thi

Review Request 127204: [KHintSettings] Disable setting the palette on-the-fly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127204/ --- Review request for KDE Frameworks, David Edmundson and Hugo Pereira Da Cost

Review Request 127205: Add stubs to allow compilation on Android.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson.

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92843 --- autotests/iconitemtest.cpp (line 133)

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

Aleix Pol Gonzalez wrote: >> I think it would be good to have changes be better understood, >> otherwise we end up with lots of mess. However, it looks like several >> people really want this, and I don't want to stand in the way. > > I don't mind spending some time to explain it