Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez
> On March 12, 2016, 8:26 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.h, line 31 > > > > > > appletquickitem.h is now installed as a public header, <> include > > should be fixed somehow Eh,

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93455 --- src/plasmaquick/appletquickitem.h (line 31)

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Luigi Toscano
> On Mar. 12, 2016, 4:07 p.m., Christoph Feck wrote: > > Can someone confirm the issue is still present with Qt 5.6? > > > > Unless it is, I suggest to not work around the Qt bug, because the release > > of Qt 5.6 is imminent and this fix does not reach our users earlier. Don't we still

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127353/#review93449 --- Can someone confirm the issue is still present with Qt 5.6?

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 4 p.m.) Review request for KDE Frameworks and

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127353/ --- (Updated Март 12, 2016, 4:53 след обяд) Review request for KDE

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93447 --- Ship it! Ship It! - Sebastian Kügler On March 12,

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 2:13 p.m.) Review request for KDE Frameworks

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

2016-03-12 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127353/ --- (Updated Март 12, 2016, 1:49 след обяд) Review request for KDE

Re: Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

2016-03-12 Thread Elvis Angelaccio
> On March 12, 2016, 9:44 a.m., Elvis Angelaccio wrote: > > Please note that the bug is in QLineEdit: > > https://bugreports.qt.io/browse/QTBUG-48806 > > > > What happens to your workaround if you run Qt 5.6? > > Anthony Fieroni wrote: > Current code wants to hide echo icon on startup,

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93444 --- Ship it! for me is a ship it, modulo just calling it just

Re: KWayland as framework

2016-03-12 Thread Ivan Čukić
> Opinions? comments? +1 from me. I guess it needs to be reviewed before it is moved to frameworks, but that should not take much time (I'd say, it will take exactly two weeks ;) ) Cheers Ivan ___ Kde-frameworks-devel mailing list

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Marco Martin
> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote: > > src/plasma/private/packages.cpp, line 46 > > > > > > I'd just go for test.qml or perhaps even autotest.qml test.qml would be good if the abstract name

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-03-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93442 --- Fix it, then Ship it! Like my other review: if we want

Re: Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

2016-03-12 Thread Anthony Fieroni
> On Март 12, 2016, 11:44 преди обяд, Elvis Angelaccio wrote: > > Please note that the bug is in QLineEdit: > > https://bugreports.qt.io/browse/QTBUG-48806 > > > > What happens to your workaround if you run Qt 5.6? Current code wants to hide echo icon on startup, no? Nothings changed, just

KWayland as framework

2016-03-12 Thread Marco Martin
Hi all, As you know in this moment a central effort of the Plasma team is to port the essential bits and pieces of the workspace (such as KWin, plasmashell and various helper bits) to Wayland in order to provide a good usable desktop experience on Wayland before the end of the year. A central

Re: Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

2016-03-12 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127353/#review93433 --- Please note that the bug is in QLineEdit:

Review Request 127353: [KPasswordDialog] echo icon is drawn over clear button

2016-03-12 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127353/ --- Review request for KDE Frameworks and Christoph Feck. Repository: